Title: [137089] trunk/Source/WebCore
- Revision
- 137089
- Author
- [email protected]
- Date
- 2012-12-09 11:00:58 -0800 (Sun, 09 Dec 2012)
Log Message
Remove unused code in GObject DOM bindings generator
https://bugs.webkit.org/show_bug.cgi?id=104490
Reviewed by Martin Robinson.
* bindings/scripts/CodeGeneratorGObject.pm:
(GenerateProperties): Remove code to install event listeners and
signals.
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (137088 => 137089)
--- trunk/Source/WebCore/ChangeLog 2012-12-09 18:55:30 UTC (rev 137088)
+++ trunk/Source/WebCore/ChangeLog 2012-12-09 19:00:58 UTC (rev 137089)
@@ -1,3 +1,14 @@
+2012-12-09 Carlos Garcia Campos <[email protected]>
+
+ Remove unused code in GObject DOM bindings generator
+ https://bugs.webkit.org/show_bug.cgi?id=104490
+
+ Reviewed by Martin Robinson.
+
+ * bindings/scripts/CodeGeneratorGObject.pm:
+ (GenerateProperties): Remove code to install event listeners and
+ signals.
+
2012-12-09 Zan Dobersek <[email protected]>
Unreviewed update for the GObject bindings after r137074 and r137078.
Modified: trunk/Source/WebCore/bindings/scripts/CodeGeneratorGObject.pm (137088 => 137089)
--- trunk/Source/WebCore/bindings/scripts/CodeGeneratorGObject.pm 2012-12-09 18:55:30 UTC (rev 137088)
+++ trunk/Source/WebCore/bindings/scripts/CodeGeneratorGObject.pm 2012-12-09 19:00:58 UTC (rev 137089)
@@ -31,8 +31,6 @@
my $defineTypeMacro = "G_DEFINE_TYPE";
my $defineTypeInterfaceImplementation = ")";
my @txtEventListeners = ();
-my @txtInstallEventListeners = ();
-my @txtInstallSignals = ();
my @txtInstallProps = ();
my @txtSetProps = ();
my @txtGetProps = ();
@@ -671,23 +669,6 @@
push(@cBodyProperties, "\n");
}
- if (scalar @txtInstallEventListeners > 0) {
- $implContent = << "EOF";
-static void ${lowerCaseIfaceName}_constructed(GObject* object)
-{
- G_OBJECT_CLASS(${lowerCaseIfaceName}_parent_class)->constructed(object);
-EOF
- push(@cBodyProperties, $implContent);
- push(@cBodyProperties, "\n");
- push(@cBodyProperties, @txtInstallEventListeners);
-
- $implContent = << "EOF";
-}
-
-EOF
- push(@cBodyProperties, $implContent);
- }
-
# Add a constructor implementation only for direct subclasses of Object to make sure
# that the WebCore wrapped object is added only once to the DOM cache. The DOM garbage
# collector works because Node is a direct subclass of Object and the version of
@@ -716,7 +697,7 @@
EOF
push(@cBodyProperties, $implContent);
- if ($parentImplClassName eq "Object" || scalar @txtInstallEventListeners > 0 || $numProperties > 0) {
+ if ($parentImplClassName eq "Object" || $numProperties > 0) {
push(@cBodyProperties, " GObjectClass* gobjectClass = G_OBJECT_CLASS(requestClass);\n");
if ($parentImplClassName eq "Object") {
@@ -725,10 +706,6 @@
push(@cBodyProperties, " gobjectClass->finalize = ${lowerCaseIfaceName}_finalize;\n");
}
- if (scalar @txtInstallEventListeners > 0) {
- push(@cBodyProperties, " gobjectClass->constructed = ${lowerCaseIfaceName}_constructed;\n");
- }
-
if ($numProperties > 0) {
if (scalar @writeableProperties > 0) {
push(@cBodyProperties, " gobjectClass->set_property = ${lowerCaseIfaceName}_set_property;\n");
@@ -737,11 +714,6 @@
push(@cBodyProperties, "\n");
push(@cBodyProperties, @txtInstallProps);
}
-
- if (scalar @txtInstallSignals > 0) {
- push(@cBodyProperties, "\n");
- push(@cBodyProperties, @txtInstallSignals);
- }
}
$implContent = << "EOF";
}
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes
