Title: [137423] trunk/Source/WebKit2
- Revision
- 137423
- Author
- [email protected]
- Date
- 2012-12-11 23:41:08 -0800 (Tue, 11 Dec 2012)
Log Message
[EFL][WK2] Duplicated WebPageGroup initialization
https://bugs.webkit.org/show_bug.cgi?id=103229
Patch by Jinwoo Song <[email protected]> on 2012-12-11
Reviewed by Kenneth Rohde Christiansen.
WebPageGroup does not need to be created in creating EwkView when the pageGroupRef is 0
because the default WebPageGroup(m_defaultPageGroup) is created in WebContext constructor.
As a side effect on the duplicated initialization, pageGroupID increases even when the EwkView
is created with default context.
* UIProcess/API/efl/ewk_view.cpp:
(createEwkView):
Modified Paths
Diff
Modified: trunk/Source/WebKit2/ChangeLog (137422 => 137423)
--- trunk/Source/WebKit2/ChangeLog 2012-12-12 07:36:07 UTC (rev 137422)
+++ trunk/Source/WebKit2/ChangeLog 2012-12-12 07:41:08 UTC (rev 137423)
@@ -1,3 +1,19 @@
+2012-12-11 Jinwoo Song <[email protected]>
+
+ [EFL][WK2] Duplicated WebPageGroup initialization
+ https://bugs.webkit.org/show_bug.cgi?id=103229
+
+ Reviewed by Kenneth Rohde Christiansen.
+
+ WebPageGroup does not need to be created in creating EwkView when the pageGroupRef is 0
+ because the default WebPageGroup(m_defaultPageGroup) is created in WebContext constructor.
+
+ As a side effect on the duplicated initialization, pageGroupID increases even when the EwkView
+ is created with default context.
+
+ * UIProcess/API/efl/ewk_view.cpp:
+ (createEwkView):
+
2012-12-11 Sam Weinig <[email protected]>
Add API to set the maximum number of processes allowed in a WKContext
Modified: trunk/Source/WebKit2/UIProcess/API/efl/ewk_view.cpp (137422 => 137423)
--- trunk/Source/WebKit2/UIProcess/API/efl/ewk_view.cpp 2012-12-12 07:36:07 UTC (rev 137422)
+++ trunk/Source/WebKit2/UIProcess/API/efl/ewk_view.cpp 2012-12-12 07:41:08 UTC (rev 137423)
@@ -507,8 +507,10 @@
}
ASSERT(!smartData->priv);
- RefPtr<WebPageGroup> pageGroup = pageGroupRef ? toImpl(pageGroupRef) : WebPageGroup::create();
- smartData->priv = new EwkViewImpl(ewkView, context, pageGroup, behavior);
+
+ // Default WebPageGroup is created in WebContext constructor if the pageGroupRef is 0,
+ // so we do not need to create it here.
+ smartData->priv = new EwkViewImpl(ewkView, context, toImpl(pageGroupRef), behavior);
return ewkView;
}
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes
