Title: [137425] trunk
Revision
137425
Author
[email protected]
Date
2012-12-11 23:54:30 -0800 (Tue, 11 Dec 2012)

Log Message

REGRESSION(r137408): breaks chromium's browser tests which use WebKitShadowRoot (Requested by hayato on #webkit).
https://bugs.webkit.org/show_bug.cgi?id=104770

Unreviewed, build fix.

Source/WebCore:

* dom/ShadowRoot.idl:
* page/DOMWindow.idl:

LayoutTests:

* fast/js/global-constructors-expected.txt:
* platform/efl/fast/js/global-constructors-expected.txt:
* platform/gtk/fast/js/global-constructors-expected.txt:

Modified Paths

Diff

Modified: trunk/LayoutTests/ChangeLog (137424 => 137425)


--- trunk/LayoutTests/ChangeLog	2012-12-12 07:49:39 UTC (rev 137424)
+++ trunk/LayoutTests/ChangeLog	2012-12-12 07:54:30 UTC (rev 137425)
@@ -1,3 +1,14 @@
+2012-12-11  Hayato Ito  <[email protected]>
+
+        REGRESSION(r137408): breaks chromium's browser tests which use WebKitShadowRoot (Requested by hayato on #webkit).
+        https://bugs.webkit.org/show_bug.cgi?id=104770
+
+        Unreviewed, build fix.
+
+        * fast/js/global-constructors-expected.txt:
+        * platform/efl/fast/js/global-constructors-expected.txt:
+        * platform/gtk/fast/js/global-constructors-expected.txt:
+
 2012-12-11  Sheriff Bot  <[email protected]>
 
         Unreviewed, rolling out r137333, r137344, r137364, and

Modified: trunk/LayoutTests/fast/js/global-constructors-expected.txt (137424 => 137425)


--- trunk/LayoutTests/fast/js/global-constructors-expected.txt	2012-12-12 07:49:39 UTC (rev 137424)
+++ trunk/LayoutTests/fast/js/global-constructors-expected.txt	2012-12-12 07:54:30 UTC (rev 137425)
@@ -329,6 +329,7 @@
 FAIL WebKitIntent.toString() should be [object WebKitIntentConstructor]. Was [object IntentConstructor].
 FAIL WebKitMutationObserver.toString() should be [object WebKitMutationObserverConstructor]. Was [object MutationObserverConstructor].
 PASS WebKitPoint.toString() is '[object WebKitPointConstructor]'
+FAIL WebKitShadowRoot.toString() should be [object WebKitShadowRootConstructor]. Was [object ShadowRootConstructor].
 PASS WebKitTransitionEvent.toString() is '[object WebKitTransitionEventConstructor]'
 PASS WebSocket.toString() is '[object WebSocketConstructor]'
 PASS WheelEvent.toString() is '[object WheelEventConstructor]'

Modified: trunk/LayoutTests/platform/efl/fast/js/global-constructors-expected.txt (137424 => 137425)


--- trunk/LayoutTests/platform/efl/fast/js/global-constructors-expected.txt	2012-12-12 07:49:39 UTC (rev 137424)
+++ trunk/LayoutTests/platform/efl/fast/js/global-constructors-expected.txt	2012-12-12 07:54:30 UTC (rev 137425)
@@ -335,6 +335,7 @@
 FAIL WebKitIntent.toString() should be [object WebKitIntentConstructor]. Was [object IntentConstructor].
 FAIL WebKitMutationObserver.toString() should be [object WebKitMutationObserverConstructor]. Was [object MutationObserverConstructor].
 PASS WebKitPoint.toString() is '[object WebKitPointConstructor]'
+FAIL WebKitShadowRoot.toString() should be [object WebKitShadowRootConstructor]. Was [object ShadowRootConstructor].
 PASS WebKitTransitionEvent.toString() is '[object WebKitTransitionEventConstructor]'
 PASS WebSocket.toString() is '[object WebSocketConstructor]'
 PASS WheelEvent.toString() is '[object WheelEventConstructor]'

Modified: trunk/LayoutTests/platform/gtk/fast/js/global-constructors-expected.txt (137424 => 137425)


--- trunk/LayoutTests/platform/gtk/fast/js/global-constructors-expected.txt	2012-12-12 07:49:39 UTC (rev 137424)
+++ trunk/LayoutTests/platform/gtk/fast/js/global-constructors-expected.txt	2012-12-12 07:54:30 UTC (rev 137425)
@@ -328,6 +328,7 @@
 PASS WebKitCSSTransformValue.toString() is '[object WebKitCSSTransformValueConstructor]'
 FAIL WebKitMutationObserver.toString() should be [object WebKitMutationObserverConstructor]. Was [object MutationObserverConstructor].
 PASS WebKitPoint.toString() is '[object WebKitPointConstructor]'
+FAIL WebKitShadowRoot.toString() should be [object WebKitShadowRootConstructor]. Was [object ShadowRootConstructor].
 PASS WebKitTransitionEvent.toString() is '[object WebKitTransitionEventConstructor]'
 PASS WebSocket.toString() is '[object WebSocketConstructor]'
 PASS WheelEvent.toString() is '[object WheelEventConstructor]'

Modified: trunk/Source/WebCore/ChangeLog (137424 => 137425)


--- trunk/Source/WebCore/ChangeLog	2012-12-12 07:49:39 UTC (rev 137424)
+++ trunk/Source/WebCore/ChangeLog	2012-12-12 07:54:30 UTC (rev 137425)
@@ -1,3 +1,13 @@
+2012-12-11  Hayato Ito  <[email protected]>
+
+        REGRESSION(r137408): breaks chromium's browser tests which use WebKitShadowRoot (Requested by hayato on #webkit).
+        https://bugs.webkit.org/show_bug.cgi?id=104770
+
+        Unreviewed, build fix.
+
+        * dom/ShadowRoot.idl:
+        * page/DOMWindow.idl:
+
 2012-12-11  Sheriff Bot  <[email protected]>
 
         Unreviewed, rolling out r137333, r137344, r137364, and

Modified: trunk/Source/WebCore/dom/ShadowRoot.idl (137424 => 137425)


--- trunk/Source/WebCore/dom/ShadowRoot.idl	2012-12-12 07:49:39 UTC (rev 137424)
+++ trunk/Source/WebCore/dom/ShadowRoot.idl	2012-12-12 07:54:30 UTC (rev 137425)
@@ -26,6 +26,8 @@
 
 [
     Conditional=SHADOW_DOM,
+    Constructor(in Element host),
+    ConstructorRaisesException,
     JSGenerateToJSObject
 ] interface ShadowRoot : DocumentFragment {
     readonly attribute Element activeElement;
@@ -45,4 +47,3 @@
     NodeList getElementsByTagNameNS(in [TreatNullAs=NullString,Optional=DefaultIsUndefined] DOMString namespaceURI,
                                     in [Optional=DefaultIsUndefined] DOMString localName);
 };
-

Modified: trunk/Source/WebCore/page/DOMWindow.idl (137424 => 137425)


--- trunk/Source/WebCore/page/DOMWindow.idl	2012-12-12 07:49:39 UTC (rev 137424)
+++ trunk/Source/WebCore/page/DOMWindow.idl	2012-12-12 07:54:30 UTC (rev 137425)
@@ -401,6 +401,7 @@
     attribute EntityConstructor Entity;
     attribute EntityReferenceConstructor EntityReference;
     attribute ProcessingInstructionConstructor ProcessingInstruction;
+    [Conditional=SHADOW_DOM, V8EnabledAtRuntime=shadowDOM] attribute ShadowRootConstructor WebKitShadowRoot;
     [Conditional=SHADOW_DOM, V8EnabledAtRuntime=shadowDOM] attribute HTMLContentElementConstructor HTMLContentElement;
     [Conditional=SHADOW_DOM, V8EnabledAtRuntime=shadowDOM] attribute HTMLShadowElementConstructor HTMLShadowElement;
 
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to