Title: [139592] trunk/Tools
- Revision
- 139592
- Author
- [email protected]
- Date
- 2013-01-14 01:30:03 -0800 (Mon, 14 Jan 2013)
Log Message
Sheriffbot command aliases need test cases
https://bugs.webkit.org/show_bug.cgi?id=106754
Patch by Alan Cutter <[email protected]> on 2013-01-14
Reviewed by Eric Seidel.
* Scripts/webkitpy/tool/commands/sheriffbot_unittest.py:
(SheriffBotTest.test_command_aliases):
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (139591 => 139592)
--- trunk/Tools/ChangeLog 2013-01-14 09:23:31 UTC (rev 139591)
+++ trunk/Tools/ChangeLog 2013-01-14 09:30:03 UTC (rev 139592)
@@ -1,3 +1,13 @@
+2013-01-14 Alan Cutter <[email protected]>
+
+ Sheriffbot command aliases need test cases
+ https://bugs.webkit.org/show_bug.cgi?id=106754
+
+ Reviewed by Eric Seidel.
+
+ * Scripts/webkitpy/tool/commands/sheriffbot_unittest.py:
+ (SheriffBotTest.test_command_aliases):
+
2013-01-13 Alan Cutter <[email protected]>
Allow users to misspell the "sheriffs" command in sheriffbot
Modified: trunk/Tools/Scripts/webkitpy/tool/commands/sheriffbot_unittest.py (139591 => 139592)
--- trunk/Tools/Scripts/webkitpy/tool/commands/sheriffbot_unittest.py 2013-01-14 09:23:31 UTC (rev 139591)
+++ trunk/Tools/Scripts/webkitpy/tool/commands/sheriffbot_unittest.py 2013-01-14 09:30:03 UTC (rev 139592)
@@ -26,8 +26,30 @@
# (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
# OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
-from webkitpy.tool.commands.queuestest import QueuesTest
+from webkitpy.tool.commands.queuestest import QueuesTest, MockQueueEngine
+from webkitpy.tool.commands import SheriffBot
+from webkitpy.tool.mocktool import MockTool, MockOptions
+from webkitpy.tool.bot.irc_command import Rollout, Sheriffs
class SheriffBotTest(QueuesTest):
- pass # No unittests as the moment.
+ def test_command_aliases(self):
+ tool = MockTool()
+ options = MockOptions()
+ options.ensure_value("confirm", False)
+ sheriffbot = SheriffBot()
+ sheriffbot.execute(options, [], tool, MockQueueEngine)
+ sheriffbot.begin_work_queue()
+ irc_bot = sheriffbot._irc_bot
+ # Test Rollout command aliases
+ revert_command, args = irc_bot._parse_command_and_args("revert")
+ self.assertEqual(revert_command, Rollout)
+ # Test Sheriffs command aliases
+ gardeners_command, args = irc_bot._parse_command_and_args("gardeners")
+ self.assertEqual(gardeners_command, Sheriffs)
+ sherifs_command, args = irc_bot._parse_command_and_args("sherifs")
+ self.assertEqual(sherifs_command, Sheriffs)
+ sherrifs_command, args = irc_bot._parse_command_and_args("sherrifs")
+ self.assertEqual(sherrifs_command, Sheriffs)
+ sherriffs_command, args = irc_bot._parse_command_and_args("sherriffs")
+ self.assertEqual(sherriffs_command, Sheriffs)
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes
