[webkit-changes] [139593] trunk/Source/WebCore

Mon, 14 Jan 2013 01:42:40 -0800

Title: [139593] trunk/Source/WebCore
Revision
139593
Author
[email protected]
Date
2013-01-14 01:44:20 -0800 (Mon, 14 Jan 2013)

Log Message

Web Inspector: [Network] Add domain column
https://bugs.webkit.org/show_bug.cgi?id=106757

Patch by Eugene Klyuchnikov <[email protected]> on 2013-01-14
Reviewed by Pavel Feldman.

Adding new column will ease domain tracking / sorting.

* inspector/front-end/NetworkPanel.js: Added column.
* inspector/front-end/NetworkRequest.js:
(WebInspector.NetworkRequest.prototype.get domain): Added getter.

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (139592 => 139593)


--- trunk/Source/WebCore/ChangeLog	2013-01-14 09:30:03 UTC (rev 139592)
+++ trunk/Source/WebCore/ChangeLog	2013-01-14 09:44:20 UTC (rev 139593)
@@ -1,3 +1,16 @@
+2013-01-14  Eugene Klyuchnikov  <[email protected]>
+
+        Web Inspector: [Network] Add domain column
+        https://bugs.webkit.org/show_bug.cgi?id=106757
+
+        Reviewed by Pavel Feldman.
+
+        Adding new column will ease domain tracking / sorting.
+
+        * inspector/front-end/NetworkPanel.js: Added column.
+        * inspector/front-end/NetworkRequest.js:
+        (WebInspector.NetworkRequest.prototype.get domain): Added getter.
+
 2013-01-14  Qiankun Miao  <[email protected]>
 
         Fix a typo error in the comments in PlatformContextSkia.h

Modified: trunk/Source/WebCore/inspector/front-end/NetworkPanel.js (139592 => 139593)


--- trunk/Source/WebCore/inspector/front-end/NetworkPanel.js	2013-01-14 09:30:03 UTC (rev 139592)
+++ trunk/Source/WebCore/inspector/front-end/NetworkPanel.js	2013-01-14 09:44:20 UTC (rev 139593)
@@ -95,7 +95,7 @@
     WebInspector.networkLog.requests.forEach(this._appendRequest.bind(this));
 }
 
-WebInspector.NetworkLogView._defaultColumnsVisivility = {method: true, status: true, type: true, initiator: true, size: true, time: true};
+WebInspector.NetworkLogView._defaultColumnsVisivility = {method: true, status: true, domain: false, type: true, initiator: true, size: true, time: true};
 
 WebInspector.NetworkLogView.prototype = {
     _initializeView: function()
@@ -157,7 +157,7 @@
 
     _createTable: function()
     {
-        var columns = {name: {}, method: {}, status: {}, type: {}, initiator: {}, size: {}, time: {}, timeline: {}};
+        var columns = {name: {}, method: {}, status: {}, domain: {}, type: {}, initiator: {}, size: {}, time: {}, timeline: {}};
 
         columns.name.titleDOMFragment = this._makeHeaderFragment(WebInspector.UIString("Name"), WebInspector.UIString("Path"));
         columns.name.name = WebInspector.UIString("Name");
@@ -174,6 +174,10 @@
         columns.status.sortable = true;
         columns.status.weight = 6;
 
+        columns.domain.title = WebInspector.UIString("Domain");
+        columns.domain.sortable = true;
+        columns.domain.weight = 6;
+
         columns.type.title = WebInspector.UIString("Type");
         columns.type.sortable = true;
         columns.type.weight = 6;
@@ -273,6 +277,7 @@
         this._sortingFunctions.name = WebInspector.NetworkDataGridNode.NameComparator;
         this._sortingFunctions.method = WebInspector.NetworkDataGridNode.RequestPropertyComparator.bind(null, "method", false);
         this._sortingFunctions.status = WebInspector.NetworkDataGridNode.RequestPropertyComparator.bind(null, "statusCode", false);
+        this._sortingFunctions.domain = WebInspector.NetworkDataGridNode.RequestPropertyComparator.bind(null, "domain", false);
         this._sortingFunctions.type = WebInspector.NetworkDataGridNode.RequestPropertyComparator.bind(null, "mimeType", false);
         this._sortingFunctions.initiator = WebInspector.NetworkDataGridNode.InitiatorComparator;
         this._sortingFunctions.size = WebInspector.NetworkDataGridNode.SizeComparator;
@@ -1879,6 +1884,7 @@
         this._nameCell = this._createDivInTD("name");
         this._methodCell = this._createDivInTD("method");
         this._statusCell = this._createDivInTD("status");
+        this._domainCell = this._createDivInTD("domain");
         this._typeCell = this._createDivInTD("type");
         this._initiatorCell = this._createDivInTD("initiator");
         this._sizeCell = this._createDivInTD("size");
@@ -1986,6 +1992,7 @@
         this._methodCell.setTextAndTitle(this._request.requestMethod);
 
         this._refreshStatusCell();
+        this._refreshDomainCell();
         this._refreshTypeCell();
         this._refreshInitiatorCell();
         this._refreshSizeCell();
@@ -2063,6 +2070,13 @@
         }
     },
 
+    _refreshDomainCell: function()
+    {
+        this._domainCell.removeChildren();
+        this._domainCell.appendChild(document.createTextNode(this._request.domain));
+        this._domainCell.title = this._request.parsedURL.host;
+    },
+
     _refreshTypeCell: function()
     {
         if (this._request.mimeType) {

Modified: trunk/Source/WebCore/inspector/front-end/NetworkRequest.js (139592 => 139593)


--- trunk/Source/WebCore/inspector/front-end/NetworkRequest.js	2013-01-14 09:30:03 UTC (rev 139592)
+++ trunk/Source/WebCore/inspector/front-end/NetworkRequest.js	2013-01-14 09:44:20 UTC (rev 139593)
@@ -424,6 +424,14 @@
     },
 
     /**
+     * @return {string}
+     */
+    get domain()
+    {
+        return this._parsedURL.host;
+    },
+
+    /**
      * @return {WebInspector.Resource|undefined}
      */
     get redirectSource()

_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to