Title: [139934] trunk/Source/WebCore
Revision
139934
Author
[email protected]
Date
2013-01-16 16:37:39 -0800 (Wed, 16 Jan 2013)

Log Message

Explicitly set msvs_cygwin_shell to true for bison rule
https://bugs.webkit.org/show_bug.cgi?id=107058

Patch by Robert Iannucci <[email protected]> on 2013-01-16
Reviewed by Tony Chang.

Currently, msvs_cygwin_shell is set to 1 by default. This patch
explicitly sets it on the actions which will break if msvs_cygwin_shell
were set to 0. This is in preparation for changing the default value of
msvs_cygwin_shell, which in turn is in preparation of the removal of
cygwin as a buld-system requirement.

Since this change will have no semantic effect, no new tests are
required.

A previous instance of this bug is here:
https://bugs.webkit.org/show_bug.cgi?id=106706

* WebCore.gyp/WebCore.gyp:

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (139933 => 139934)


--- trunk/Source/WebCore/ChangeLog	2013-01-17 00:05:53 UTC (rev 139933)
+++ trunk/Source/WebCore/ChangeLog	2013-01-17 00:37:39 UTC (rev 139934)
@@ -1,3 +1,24 @@
+2013-01-16  Robert Iannucci  <[email protected]>
+
+        Explicitly set msvs_cygwin_shell to true for bison rule
+        https://bugs.webkit.org/show_bug.cgi?id=107058
+
+        Reviewed by Tony Chang.
+
+        Currently, msvs_cygwin_shell is set to 1 by default. This patch
+        explicitly sets it on the actions which will break if msvs_cygwin_shell
+        were set to 0. This is in preparation for changing the default value of
+        msvs_cygwin_shell, which in turn is in preparation of the removal of
+        cygwin as a buld-system requirement.
+
+        Since this change will have no semantic effect, no new tests are
+        required.
+
+        A previous instance of this bug is here:
+        https://bugs.webkit.org/show_bug.cgi?id=106706
+
+        * WebCore.gyp/WebCore.gyp:
+
 2013-01-16  Benjamin Poulain  <[email protected]>
 
         Fix the warning for the exported Objective-C binding of DOMCSSSupportsRule

Modified: trunk/Source/WebCore/WebCore.gyp/WebCore.gyp (139933 => 139934)


--- trunk/Source/WebCore/WebCore.gyp/WebCore.gyp	2013-01-17 00:05:53 UTC (rev 139933)
+++ trunk/Source/WebCore/WebCore.gyp/WebCore.gyp	2013-01-17 00:37:39 UTC (rev 139934)
@@ -1146,6 +1146,7 @@
             '<(SHARED_INTERMEDIATE_DIR)/webkit',
             '<(bison_exe)',
           ],
+          'msvs_cygwin_shell': 1,
         },
         {
           'rule_name': 'gperf',
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to