Title: [139936] trunk/Tools
- Revision
- 139936
- Author
- [email protected]
- Date
- 2013-01-16 16:48:14 -0800 (Wed, 16 Jan 2013)
Log Message
start-queue.sh does not pass remaining parameters correctly
https://bugs.webkit.org/show_bug.cgi?id=107054
Patch by Alan Cutter <[email protected]> on 2013-01-16
Reviewed by Adam Barth.
start-queue.sh now passes all remaining params to the webkit-patch command.
Previously only one additional queue parameter could be sent.
* EWSTools/start-queue.sh:
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (139935 => 139936)
--- trunk/Tools/ChangeLog 2013-01-17 00:45:30 UTC (rev 139935)
+++ trunk/Tools/ChangeLog 2013-01-17 00:48:14 UTC (rev 139936)
@@ -1,3 +1,15 @@
+2013-01-16 Alan Cutter <[email protected]>
+
+ start-queue.sh does not pass remaining parameters correctly
+ https://bugs.webkit.org/show_bug.cgi?id=107054
+
+ Reviewed by Adam Barth.
+
+ start-queue.sh now passes all remaining params to the webkit-patch command.
+ Previously only one additional queue parameter could be sent.
+
+ * EWSTools/start-queue.sh:
+
2013-01-16 Xueqing Huang <[email protected]>
check-webkit-style script cannot running in Chinese windows.
Modified: trunk/Tools/EWSTools/start-queue.sh (139935 => 139936)
--- trunk/Tools/EWSTools/start-queue.sh 2013-01-17 00:45:30 UTC (rev 139935)
+++ trunk/Tools/EWSTools/start-queue.sh 2013-01-17 00:48:14 UTC (rev 139936)
@@ -27,8 +27,7 @@
# (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
# OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
-# The GCE VM image we're using only has bash v4.1.5
-if test $# -lt 3 -o $# -gt 4; then
+if [[ $# -lt 3 ]]; then
echo "Usage: start-queue-loop.sh QUEUE_NAME BOT_ID RESET_AFTER_ITERATION [QUEUE_PARAMS]"
exit 1
fi
@@ -36,7 +35,8 @@
QUEUE_NAME=$1
BOT_ID=$2
RESET_AFTER_ITERATION=$3
-QUEUE_PARAMS=$4
+shift 3
+QUEUE_PARAMS="$@"
cd /mnt/git/webkit-$QUEUE_NAME
while :
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes
