Title: [142727] trunk/Source/WebCore
- Revision
- 142727
- Author
- hara...@chromium.org
- Date
- 2013-02-13 00:10:02 -0800 (Wed, 13 Feb 2013)
Log Message
[V8] There is no XXXConstructor that requires a custom getter
https://bugs.webkit.org/show_bug.cgi?id=109667
Reviewed by Adam Barth.
Currently '[Custom] attribute XXXConstructor xxx' generates
XXXAttrGetter(). However, there is no XXXConstructor with [Custom].
In addition, it does make no sense to generate XXXAttrGetter() for such cases.
We can remove the logic from CodeGeneratorV8.pm.
* bindings/scripts/CodeGeneratorV8.pm:
(GenerateSingleBatchedAttribute):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (142726 => 142727)
--- trunk/Source/WebCore/ChangeLog 2013-02-13 07:34:47 UTC (rev 142726)
+++ trunk/Source/WebCore/ChangeLog 2013-02-13 08:10:02 UTC (rev 142727)
@@ -1,3 +1,18 @@
+2013-02-13 Kentaro Hara <hara...@chromium.org>
+
+ [V8] There is no XXXConstructor that requires a custom getter
+ https://bugs.webkit.org/show_bug.cgi?id=109667
+
+ Reviewed by Adam Barth.
+
+ Currently '[Custom] attribute XXXConstructor xxx' generates
+ XXXAttrGetter(). However, there is no XXXConstructor with [Custom].
+ In addition, it does make no sense to generate XXXAttrGetter() for such cases.
+ We can remove the logic from CodeGeneratorV8.pm.
+
+ * bindings/scripts/CodeGeneratorV8.pm:
+ (GenerateSingleBatchedAttribute):
+
2013-02-12 Hajime Morrita <morr...@google.com>
[Internals] setShadowDOMEnabled() shouldn't be used except a few tests.
Modified: trunk/Source/WebCore/bindings/scripts/CodeGeneratorV8.pm (142726 => 142727)
--- trunk/Source/WebCore/bindings/scripts/CodeGeneratorV8.pm 2013-02-13 07:34:47 UTC (rev 142726)
+++ trunk/Source/WebCore/bindings/scripts/CodeGeneratorV8.pm 2013-02-13 08:10:02 UTC (rev 142727)
@@ -2296,12 +2296,8 @@
if ($constructorType !~ /Constructor$/ || $attribute->signature->extendedAttributes->{"V8CustomConstructor"} || $attribute->signature->extendedAttributes->{"CustomConstructor"}) {
AddToImplIncludes("V8${constructorType}.h", $attribute->signature->extendedAttributes->{"Conditional"});
}
- if ($customAccessor) {
- $getter = "V8${customAccessor}AccessorGetter";
- } else {
- $data = ""
- $getter = "${interfaceName}V8Internal::${interfaceName}ConstructorGetter";
- }
+ $data = ""
+ $getter = "${interfaceName}V8Internal::${interfaceName}ConstructorGetter";
$setter = "${interfaceName}V8Internal::${interfaceName}ReplaceableAttrSetter";
} else {
# Default Getter and Setter
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
