Title: [142728] trunk/Source/WebCore
Revision
142728
Author
[email protected]
Date
2013-02-13 00:24:56 -0800 (Wed, 13 Feb 2013)

Log Message

Unreviewed, rolling out r142611.
http://trac.webkit.org/changeset/142611
https://bugs.webkit.org/show_bug.cgi?id=109668

Suggest box is not shown anymore when user types "window." in
inspector console. (Requested by vsevik on #webkit).

Patch by Sheriff Bot <[email protected]> on 2013-02-13

* inspector/front-end/TextPrompt.js:
(WebInspector.TextPrompt.prototype.complete):

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (142727 => 142728)


--- trunk/Source/WebCore/ChangeLog	2013-02-13 08:10:02 UTC (rev 142727)
+++ trunk/Source/WebCore/ChangeLog	2013-02-13 08:24:56 UTC (rev 142728)
@@ -1,3 +1,15 @@
+2013-02-13  Sheriff Bot  <[email protected]>
+
+        Unreviewed, rolling out r142611.
+        http://trac.webkit.org/changeset/142611
+        https://bugs.webkit.org/show_bug.cgi?id=109668
+
+        Suggest box is not shown anymore when user types "window." in
+        inspector console. (Requested by vsevik on #webkit).
+
+        * inspector/front-end/TextPrompt.js:
+        (WebInspector.TextPrompt.prototype.complete):
+
 2013-02-13  Kentaro Hara  <[email protected]>
 
         [V8] There is no XXXConstructor that requires a custom getter

Modified: trunk/Source/WebCore/inspector/front-end/TextPrompt.js (142727 => 142728)


--- trunk/Source/WebCore/inspector/front-end/TextPrompt.js	2013-02-13 08:10:02 UTC (rev 142727)
+++ trunk/Source/WebCore/inspector/front-end/TextPrompt.js	2013-02-13 08:24:56 UTC (rev 142728)
@@ -371,8 +371,7 @@
             return;
 
         var selectionRange = selection.getRangeAt(0);
-        var wordPrefixRange = selectionRange.startContainer.rangeOfWord(selectionRange.startOffset, this._completionStopCharacters, this._element, "backward");
-        var isEmptyInput = wordPrefixRange.collapsed;
+        var isEmptyInput = selectionRange.commonAncestorContainer === this._element; // this._element has no child Text nodes.
 
         var shouldExit;
 
@@ -396,6 +395,7 @@
             return;
         }
 
+        var wordPrefixRange = selectionRange.startContainer.rangeOfWord(selectionRange.startOffset, this._completionStopCharacters, this._element, "backward");
         this._waitingForCompletions = true;
         this._loadCompletions(this.proxyElement, wordPrefixRange, force, this._completionsReady.bind(this, selection, auto, wordPrefixRange, !!reverse));
     },
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to