Title: [144140] trunk/Source/WebCore
- Revision
- 144140
- Author
- [email protected]
- Date
- 2013-02-26 20:34:27 -0800 (Tue, 26 Feb 2013)
Log Message
SelectorQuery should not ever use ResolvingStyle mode.
https://bugs.webkit.org/show_bug.cgi?id=110843
It looks like we accidentally used ResolvingStyle mode for webkitMatchesSelector, and I exacerbated the problem
in r143858 by switching all of SelectorQuery to use it. There aren't any visible effects, but the style bits
of elements are unnecessarily twiddled when if we do that. Let's not do it.
Reviewed by Eric Seidel.
No public-facing behavior change, covered by existing tests.
* dom/SelectorQuery.cpp:
(WebCore::SelectorDataList::selectorMatches): Switched to always use QueryingRules mode.
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (144139 => 144140)
--- trunk/Source/WebCore/ChangeLog 2013-02-27 04:32:49 UTC (rev 144139)
+++ trunk/Source/WebCore/ChangeLog 2013-02-27 04:34:27 UTC (rev 144140)
@@ -1,3 +1,19 @@
+2013-02-26 Dimitri Glazkov <[email protected]>
+
+ SelectorQuery should not ever use ResolvingStyle mode.
+ https://bugs.webkit.org/show_bug.cgi?id=110843
+
+ It looks like we accidentally used ResolvingStyle mode for webkitMatchesSelector, and I exacerbated the problem
+ in r143858 by switching all of SelectorQuery to use it. There aren't any visible effects, but the style bits
+ of elements are unnecessarily twiddled when if we do that. Let's not do it.
+
+ Reviewed by Eric Seidel.
+
+ No public-facing behavior change, covered by existing tests.
+
+ * dom/SelectorQuery.cpp:
+ (WebCore::SelectorDataList::selectorMatches): Switched to always use QueryingRules mode.
+
2013-02-26 Adam Barth <[email protected]>
Silence this ASSERT. It is triggered by the threaded HTML parser.
Modified: trunk/Source/WebCore/dom/SelectorQuery.cpp (144139 => 144140)
--- trunk/Source/WebCore/dom/SelectorQuery.cpp 2013-02-27 04:32:49 UTC (rev 144139)
+++ trunk/Source/WebCore/dom/SelectorQuery.cpp 2013-02-27 04:34:27 UTC (rev 144140)
@@ -59,7 +59,7 @@
return selectorCheckerFastPath.matches();
}
- SelectorChecker selectorChecker(element->document(), SelectorChecker::ResolvingStyle);
+ SelectorChecker selectorChecker(element->document(), SelectorChecker::QueryingRules);
SelectorChecker::SelectorCheckingContext selectorCheckingContext(selectorData.selector, element, SelectorChecker::VisitedMatchDisabled);
PseudoId ignoreDynamicPseudo = NOPSEUDO;
return selectorChecker.match(selectorCheckingContext, ignoreDynamicPseudo, DOMSiblingTraversalStrategy()) == SelectorChecker::SelectorMatches;
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
