Title: [144142] trunk/Source/WebCore
- Revision
- 144142
- Author
- [email protected]
- Date
- 2013-02-26 21:11:04 -0800 (Tue, 26 Feb 2013)
Log Message
[V8] Remove Event::dataTransferAttrGetterCustom() and Event::valueAttrSetterCustom()
https://bugs.webkit.org/show_bug.cgi?id=110666
Reviewed by Adam Barth.
Event::dataTransferAttrGetterCustom() is not used
(i.e. the custom method is not registered to V8).
Event::valueAttrSetterCustom() is declared but not
implemented. We can remove them.
No tests. No change in behavior.
* bindings/scripts/CodeGeneratorV8.pm:
(GenerateHeaderCustomCall):
* bindings/v8/custom/V8EventCustom.cpp:
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (144141 => 144142)
--- trunk/Source/WebCore/ChangeLog 2013-02-27 05:02:14 UTC (rev 144141)
+++ trunk/Source/WebCore/ChangeLog 2013-02-27 05:11:04 UTC (rev 144142)
@@ -1,3 +1,21 @@
+2013-02-26 Kentaro Hara <[email protected]>
+
+ [V8] Remove Event::dataTransferAttrGetterCustom() and Event::valueAttrSetterCustom()
+ https://bugs.webkit.org/show_bug.cgi?id=110666
+
+ Reviewed by Adam Barth.
+
+ Event::dataTransferAttrGetterCustom() is not used
+ (i.e. the custom method is not registered to V8).
+ Event::valueAttrSetterCustom() is declared but not
+ implemented. We can remove them.
+
+ No tests. No change in behavior.
+
+ * bindings/scripts/CodeGeneratorV8.pm:
+ (GenerateHeaderCustomCall):
+ * bindings/v8/custom/V8EventCustom.cpp:
+
2013-02-26 Dimitri Glazkov <[email protected]>
SelectorQuery should not ever use ResolvingStyle mode.
Modified: trunk/Source/WebCore/bindings/scripts/CodeGeneratorV8.pm (144141 => 144142)
--- trunk/Source/WebCore/bindings/scripts/CodeGeneratorV8.pm 2013-02-27 05:02:14 UTC (rev 144141)
+++ trunk/Source/WebCore/bindings/scripts/CodeGeneratorV8.pm 2013-02-27 05:11:04 UTC (rev 144142)
@@ -728,10 +728,6 @@
if ($interface->extendedAttributes->{"CustomCall"}) {
push(@headerContent, " static v8::Handle<v8::Value> callAsFunctionCallback(const v8::Arguments&);\n");
}
- if ($interface->name eq "Event") {
- push(@headerContent, " static v8::Handle<v8::Value> dataTransferAttrGetterCustom(v8::Local<v8::String> name, const v8::AccessorInfo&);\n");
- push(@headerContent, " static void valueAttrSetterCustom(v8::Local<v8::String> name, v8::Local<v8::Value>, const v8::AccessorInfo&);\n");
- }
if ($interface->name eq "Location") {
push(@headerContent, " static v8::Handle<v8::Value> assignAttrGetterCustom(v8::Local<v8::String> name, const v8::AccessorInfo&);\n");
push(@headerContent, " static v8::Handle<v8::Value> reloadAttrGetterCustom(v8::Local<v8::String> name, const v8::AccessorInfo&);\n");
Modified: trunk/Source/WebCore/bindings/v8/custom/V8EventCustom.cpp (144141 => 144142)
--- trunk/Source/WebCore/bindings/v8/custom/V8EventCustom.cpp 2013-02-27 05:02:14 UTC (rev 144141)
+++ trunk/Source/WebCore/bindings/v8/custom/V8EventCustom.cpp 2013-02-27 05:11:04 UTC (rev 144142)
@@ -42,16 +42,6 @@
namespace WebCore {
-v8::Handle<v8::Value> V8Event::dataTransferAttrGetterCustom(v8::Local<v8::String> name, const v8::AccessorInfo& info)
-{
- Event* event = V8Event::toNative(info.Holder());
-
- if (event->isDragEvent())
- return toV8Fast(static_cast<MouseEvent*>(event)->clipboard(), info, event);
-
- return v8::Undefined();
-}
-
v8::Handle<v8::Value> V8Event::clipboardDataAttrGetterCustom(v8::Local<v8::String> name, const v8::AccessorInfo& info)
{
Event* event = V8Event::toNative(info.Holder());
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
