Title: [144454] trunk/Source/WebKit/blackberry
- Revision
- 144454
- Author
- [email protected]
- Date
- 2013-03-01 07:25:40 -0800 (Fri, 01 Mar 2013)
Log Message
[BlackBerry] Reverse the base and extent of a selection when reversing its handles
https://bugs.webkit.org/show_bug.cgi?id=111098
Reviewed by Yong Li.
PR283969
Swap the base and extent if base does not come first, and set the new selection.
Internally reviewed by Mike Fenton
* WebKitSupport/SelectionHandler.cpp:
(BlackBerry::WebKit::SelectionHandler::setSelection):
Modified Paths
Diff
Modified: trunk/Source/WebKit/blackberry/ChangeLog (144453 => 144454)
--- trunk/Source/WebKit/blackberry/ChangeLog 2013-03-01 15:15:32 UTC (rev 144453)
+++ trunk/Source/WebKit/blackberry/ChangeLog 2013-03-01 15:25:40 UTC (rev 144454)
@@ -1,3 +1,18 @@
+2013-03-01 Nima Ghanavatian <[email protected]>
+
+ [BlackBerry] Reverse the base and extent of a selection when reversing its handles
+ https://bugs.webkit.org/show_bug.cgi?id=111098
+
+ Reviewed by Yong Li.
+
+ PR283969
+ Swap the base and extent if base does not come first, and set the new selection.
+
+ Internally reviewed by Mike Fenton
+
+ * WebKitSupport/SelectionHandler.cpp:
+ (BlackBerry::WebKit::SelectionHandler::setSelection):
+
2013-03-01 Alberto Garcia <[email protected]>
Fix definition of DatePickerClient::setValue()
Modified: trunk/Source/WebKit/blackberry/WebKitSupport/SelectionHandler.cpp (144453 => 144454)
--- trunk/Source/WebKit/blackberry/WebKitSupport/SelectionHandler.cpp 2013-03-01 15:15:32 UTC (rev 144453)
+++ trunk/Source/WebKit/blackberry/WebKitSupport/SelectionHandler.cpp 2013-03-01 15:25:40 UTC (rev 144454)
@@ -568,8 +568,10 @@
}
// Check if the handles reversed position.
- if (m_selectionActive && !newSelection.isBaseFirst())
+ if (m_selectionActive && !newSelection.isBaseFirst()) {
m_webPage->m_client->notifySelectionHandlesReversed();
+ newSelection = VisibleSelection(newSelection.extent(), newSelection.base());
+ }
controller->setSelection(newSelection);
SelectionLog(Platform::LogLevelInfo, "SelectionHandler::setSelection selection points valid, selection updated.");
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
