Title: [144456] trunk/Source/WebCore
- Revision
- 144456
- Author
- [email protected]
- Date
- 2013-03-01 07:47:26 -0800 (Fri, 01 Mar 2013)
Log Message
Add FeatureObserver for marquee and reflection
https://bugs.webkit.org/show_bug.cgi?id=111118
Reviewed by Simon Fraser.
Refactoring covered by existing tests.
* page/FeatureObserver.h:
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::styleChanged):
Added some instrumentation for reflection and marquee as they are both prefixed and this would help
to know their popularity on the web. Marquee was split between <marquee> (HTMLMarqueeElement) and
overflow: -webkit-marquee (CSSOverflowMarquee).
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (144455 => 144456)
--- trunk/Source/WebCore/ChangeLog 2013-03-01 15:37:12 UTC (rev 144455)
+++ trunk/Source/WebCore/ChangeLog 2013-03-01 15:47:26 UTC (rev 144456)
@@ -1,3 +1,19 @@
+2013-03-01 Julien Chaffraix <[email protected]>
+
+ Add FeatureObserver for marquee and reflection
+ https://bugs.webkit.org/show_bug.cgi?id=111118
+
+ Reviewed by Simon Fraser.
+
+ Refactoring covered by existing tests.
+
+ * page/FeatureObserver.h:
+ * rendering/RenderLayer.cpp:
+ (WebCore::RenderLayer::styleChanged):
+ Added some instrumentation for reflection and marquee as they are both prefixed and this would help
+ to know their popularity on the web. Marquee was split between <marquee> (HTMLMarqueeElement) and
+ overflow: -webkit-marquee (CSSOverflowMarquee).
+
2013-03-01 Alexander Pavlov <[email protected]>
Web Inspector: Introduce opaque SecurityOrigin string identifiers in the frontend
Modified: trunk/Source/WebCore/page/FeatureObserver.h (144455 => 144456)
--- trunk/Source/WebCore/page/FeatureObserver.h 2013-03-01 15:37:12 UTC (rev 144455)
+++ trunk/Source/WebCore/page/FeatureObserver.h 2013-03-01 15:47:26 UTC (rev 144456)
@@ -96,6 +96,9 @@
ResultsAttribute,
StepAttribute,
PageVisits,
+ HTMLMarqueeElement,
+ CSSOverflowMarquee,
+ Reflection,
// Add new features above this line. Don't change assigned numbers of each items.
NumberOfFeatures, // This enum value must be last.
};
Modified: trunk/Source/WebCore/rendering/RenderLayer.cpp (144455 => 144456)
--- trunk/Source/WebCore/rendering/RenderLayer.cpp 2013-03-01 15:37:12 UTC (rev 144455)
+++ trunk/Source/WebCore/rendering/RenderLayer.cpp 2013-03-01 15:47:26 UTC (rev 144456)
@@ -55,6 +55,7 @@
#include "FEMerge.h"
#include "FilterEffectRenderer.h"
#endif
+#include "FeatureObserver.h"
#include "FloatConversion.h"
#include "FloatPoint3D.h"
#include "FloatRect.h"
@@ -6013,6 +6014,7 @@
if (renderer()->style()->overflowX() == OMARQUEE && renderer()->style()->marqueeBehavior() != MNONE && renderer()->isBox()) {
if (!m_marquee)
m_marquee = adoptPtr(new RenderMarquee(this));
+ FeatureObserver::observe(renderer()->document(), renderer()->isHTMLMarquee() ? FeatureObserver::HTMLMarqueeElement : FeatureObserver::CSSOverflowMarquee);
m_marquee->updateMarqueeStyle();
}
else if (m_marquee) {
@@ -6031,6 +6033,7 @@
else if (hasReflection()) {
if (!m_reflection)
createReflection();
+ FeatureObserver::observe(renderer()->document(), FeatureObserver::Reflection);
updateReflectionStyle();
}
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
