Title: [144718] branches/chromium/1410/Source/WebCore
- Revision
- 144718
- Author
- [email protected]
- Date
- 2013-03-04 21:31:10 -0800 (Mon, 04 Mar 2013)
Log Message
Merge 144437
> Web Inspector: [DataGrid] Columns are misaligned after rows being refreshed.
> https://bugs.webkit.org/show_bug.cgi?id=111077
>
> Reviewed by Pavel Feldman.
>
> Analysis: DataGridNode.refresh removes all cells and then recreates them.
> The issue is that mandatory "corner" cell is not recreated.
>
> * inspector/front-end/DataGrid.js:
> (WebInspector.DataGridNode.prototype.refresh):
> Added "corner" cell restoration code.
>
[email protected]
Review URL: https://codereview.chromium.org/12414004
Modified Paths
Diff
Modified: branches/chromium/1410/Source/WebCore/ChangeLog (144717 => 144718)
--- branches/chromium/1410/Source/WebCore/ChangeLog 2013-03-05 05:27:04 UTC (rev 144717)
+++ branches/chromium/1410/Source/WebCore/ChangeLog 2013-03-05 05:31:10 UTC (rev 144718)
@@ -1,3 +1,17 @@
+2013-03-01 Eugene Klyuchnikov <[email protected]>
+
+ Web Inspector: [DataGrid] Columns are misaligned after rows being refreshed.
+ https://bugs.webkit.org/show_bug.cgi?id=111077
+
+ Reviewed by Pavel Feldman.
+
+ Analysis: DataGridNode.refresh removes all cells and then recreates them.
+ The issue is that mandatory "corner" cell is not recreated.
+
+ * inspector/front-end/DataGrid.js:
+ (WebInspector.DataGridNode.prototype.refresh):
+ Added "corner" cell restoration code.
+
2013-02-27 Eugene Klyuchnikov <[email protected]>
Web Inspector: timeline stops working on certain sites
Modified: branches/chromium/1410/Source/WebCore/inspector/front-end/DataGrid.js (144717 => 144718)
--- branches/chromium/1410/Source/WebCore/inspector/front-end/DataGrid.js 2013-03-05 05:27:04 UTC (rev 144717)
+++ branches/chromium/1410/Source/WebCore/inspector/front-end/DataGrid.js 2013-03-05 05:31:10 UTC (rev 144718)
@@ -1256,6 +1256,7 @@
this._element.removeChildren();
this.createCells();
+ this._element.createChild("td", "corner");
},
/**
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
