Title: [144719] trunk/Tools
Revision
144719
Author
[email protected]
Date
2013-03-04 21:55:06 -0800 (Mon, 04 Mar 2013)

Log Message

run-webkit-tests should support --profile and --profiler= just like run-perf-tests does
https://bugs.webkit.org/show_bug.cgi?id=111384

Reviewed by Ryosuke Niwa.

Sometimes I want to know why various LayoutTests are slow
without having to convert them into PerformanceTests in order
to use our fancy profiling.  The Driver already knows how to
do the right thing, we just need to expose the options to the user.

Handling of these options is already unittested in the perftests_unittest.

* Scripts/webkitpy/layout_tests/run_webkit_tests.py:
(parse_args):

Modified Paths

Diff

Modified: trunk/Tools/ChangeLog (144718 => 144719)


--- trunk/Tools/ChangeLog	2013-03-05 05:31:10 UTC (rev 144718)
+++ trunk/Tools/ChangeLog	2013-03-05 05:55:06 UTC (rev 144719)
@@ -1,3 +1,20 @@
+2013-03-04  Eric Seidel  <[email protected]>
+
+        run-webkit-tests should support --profile and --profiler= just like run-perf-tests does
+        https://bugs.webkit.org/show_bug.cgi?id=111384
+
+        Reviewed by Ryosuke Niwa.
+
+        Sometimes I want to know why various LayoutTests are slow
+        without having to convert them into PerformanceTests in order
+        to use our fancy profiling.  The Driver already knows how to
+        do the right thing, we just need to expose the options to the user.
+
+        Handling of these options is already unittested in the perftests_unittest.
+
+        * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
+        (parse_args):
+
 2013-03-04  Alan Cutter  <[email protected]>
 
         check-webkit-style says "Have to enable auto props in the subversion config file"

Modified: trunk/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py (144718 => 144719)


--- trunk/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py	2013-03-05 05:31:10 UTC (rev 144718)
+++ trunk/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py	2013-03-05 05:55:06 UTC (rev 144719)
@@ -272,6 +272,10 @@
             help="Set the maximum number of locked shards"),
         optparse.make_option("--additional-env-var", type="string", action="" default=[],
             help="Passes that environment variable to the tests (--additional-env-var=NAME=VALUE)"),
+        optparse.make_option("--profile", action=""
+            help="Output per-test profile information."),
+        optparse.make_option("--profiler", action=""
+            help="Output per-test profile information, using the specified profiler."),
     ]))
 
     option_group_definitions.append(("Miscellaneous Options", [
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to