Title: [144968] trunk/Tools
- Revision
- 144968
- Author
- [email protected]
- Date
- 2013-03-06 13:00:54 -0800 (Wed, 06 Mar 2013)
Log Message
Dashboard cleanup: remove dashboard time logging.
https://bugs.webkit.org/show_bug.cgi?id=111608
Reviewed by Dirk Pranke.
Remove logTime. It was never accurate, and the dev tools
have better ways to measure this if anyone cares to look
into dashboard perf.
* TestResultServer/static-dashboards/dashboard_base.js:
* TestResultServer/static-dashboards/flakiness_dashboard.js:
(processTestRunsForBuilder):
(appendHTML):
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (144967 => 144968)
--- trunk/Tools/ChangeLog 2013-03-06 20:58:37 UTC (rev 144967)
+++ trunk/Tools/ChangeLog 2013-03-06 21:00:54 UTC (rev 144968)
@@ -1,3 +1,19 @@
+2013-03-06 Julie Parent <[email protected]>
+
+ Dashboard cleanup: remove dashboard time logging.
+ https://bugs.webkit.org/show_bug.cgi?id=111608
+
+ Reviewed by Dirk Pranke.
+
+ Remove logTime. It was never accurate, and the dev tools
+ have better ways to measure this if anyone cares to look
+ into dashboard perf.
+
+ * TestResultServer/static-dashboards/dashboard_base.js:
+ * TestResultServer/static-dashboards/flakiness_dashboard.js:
+ (processTestRunsForBuilder):
+ (appendHTML):
+
2013-03-06 Tony Chang <[email protected]>
[chromium] making DumpRenderTree_resources a separate bundle breaks xcode
Modified: trunk/Tools/TestResultServer/static-dashboards/dashboard_base.js (144967 => 144968)
--- trunk/Tools/TestResultServer/static-dashboards/dashboard_base.js 2013-03-06 20:58:37 UTC (rev 144967)
+++ trunk/Tools/TestResultServer/static-dashboards/dashboard_base.js 2013-03-06 21:00:54 UTC (rev 144968)
@@ -32,7 +32,6 @@
//
// The calling page is expected to implement the following "abstract"
// functions/objects:
-var g_pageLoadStartTime = Date.now();
var g_resourceLoader;
// Generates the contents of the dashboard. The page should override this with
@@ -549,11 +548,6 @@
return state.join('&');
}
-function logTime(msg, startTime)
-{
- console.log(msg + ': ' + (Date.now() - startTime));
-}
-
function hidePopup()
{
var popup = $('popup');
@@ -845,9 +839,6 @@
}, false);
window.addEventListener('load', function() {
- // This doesn't seem totally accurate as there is a race between
- // onload firing and the last script tag being executed.
- logTime('Time to load JS', g_pageLoadStartTime);
g_resourceLoader = new loader.Loader();
g_resourceLoader.load();
}, false);
Modified: trunk/Tools/TestResultServer/static-dashboards/flakiness_dashboard.js (144967 => 144968)
--- trunk/Tools/TestResultServer/static-dashboards/flakiness_dashboard.js 2013-03-06 20:58:37 UTC (rev 144967)
+++ trunk/Tools/TestResultServer/static-dashboards/flakiness_dashboard.js 2013-03-06 21:00:54 UTC (rev 144968)
@@ -942,8 +942,7 @@
}
processExpectations();
- var start = Date.now();
-
+
var buildInfo = platformAndBuildType(builderName);
var platform = buildInfo.platform;
var buildType = buildInfo.buildType;
@@ -996,7 +995,6 @@
}
g_perBuilderFailures[builderName] = failures;
- logTime('processTestRunsForBuilder: ' + builderName, start);
}
function processMissingAndExtraExpectations(resultsForTest)
@@ -1469,13 +1467,11 @@
function appendHTML(html)
{
- var startTime = Date.now();
// InnerHTML to a div that's not in the document. This is
// ~300ms faster in Safari 4 and Chrome 4 on mac.
var div = document.createElement('div');
div.innerHTML = html;
document.body.appendChild(div);
- logTime('Time to innerHTML', startTime);
postHeightChangedMessage();
}
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
