[webkit-changes] [144969] trunk

Wed, 06 Mar 2013 13:07:35 -0800

Title: [144969] trunk
Revision
144969
Author
[email protected]
Date
2013-03-06 13:09:34 -0800 (Wed, 06 Mar 2013)

Log Message

[WK2][GTK] Fix unit test WebKit2APITests/WebKitWebView/mouse-target
https://bugs.webkit.org/show_bug.cgi?id=82866

Patch by Manuel Rego Casasnovas <[email protected]> on 2013-03-06
Reviewed by Martin Robinson.

Source/WebKit2:

Test was failing because of new media controls needs more space to be
painted than just 10x10 pixels. This is similar to r144070.

* UIProcess/API/gtk/tests/TestWebKitWebView.cpp:
(testWebViewMouseTarget): Modified HTML in order to give more space to the media controls.

Tools:

* Scripts/run-gtk-tests:
(TestRunner): Unflag WebKit2APITests/WebKitWebView/mouse-target test as
it is passing now.

Modified Paths

Diff

Modified: trunk/Source/WebKit2/ChangeLog (144968 => 144969)


--- trunk/Source/WebKit2/ChangeLog	2013-03-06 21:00:54 UTC (rev 144968)
+++ trunk/Source/WebKit2/ChangeLog	2013-03-06 21:09:34 UTC (rev 144969)
@@ -1,3 +1,16 @@
+2013-03-06  Manuel Rego Casasnovas  <[email protected]>
+
+        [WK2][GTK] Fix unit test WebKit2APITests/WebKitWebView/mouse-target
+        https://bugs.webkit.org/show_bug.cgi?id=82866
+
+        Reviewed by Martin Robinson.
+
+        Test was failing because of new media controls needs more space to be
+        painted than just 10x10 pixels. This is similar to r144070.
+
+        * UIProcess/API/gtk/tests/TestWebKitWebView.cpp:
+        (testWebViewMouseTarget): Modified HTML in order to give more space to the media controls.
+
 2013-03-06  Tim Horton  <[email protected]>
 
         [wk2] Page Overlays: Hook up the layer border/repaint counter setting to the overlay layer

Modified: trunk/Source/WebKit2/UIProcess/API/gtk/tests/TestWebKitWebView.cpp (144968 => 144969)


--- trunk/Source/WebKit2/UIProcess/API/gtk/tests/TestWebKitWebView.cpp	2013-03-06 21:00:54 UTC (rev 144968)
+++ trunk/Source/WebKit2/UIProcess/API/gtk/tests/TestWebKitWebView.cpp	2013-03-06 21:09:34 UTC (rev 144969)
@@ -479,9 +479,9 @@
         " <a style='position:absolute; left:1; top:1' href='' title='WebKitGTK+ Title'>WebKitGTK+ Website</a>"
         " <img style='position:absolute; left:1; top:10' src='' width=5 height=5></img>"
         " <a style='position:absolute; left:1; top:20' href='' title='WebKitGTK+ Logo'><img src='' width=5 height=5></img></a>"
-        " <video style='position:absolute; left:1; top:30' width=10 height=10 controls='controls'><source src='' type='video/ogg' /></video>"
-        " <input style='position:absolute; left:1; top:50' size='10'></input>"
-        " <div style='position:absolute; left:1; top:70; width:30; height:30; overflow:scroll'>&nbsp;</div>"
+        " <input style='position:absolute; left:1; top:30' size='10'></input>"
+        " <div style='position:absolute; left:1; top:50; width:30; height:30; overflow:scroll'>&nbsp;</div>"
+        " <video style='position:absolute; left:1; top:100' width='300' height='300' controls='controls'><source src='' type='video/ogg' /></video>"
         "</body></html>";
 
     test->loadHtml(linksHoveredHTML, "file:///");
@@ -530,7 +530,7 @@
     g_assert(!test->m_mouseTargetModifiers);
 
     // Move over media.
-    hitTestResult = test->moveMouseAndWaitUntilMouseTargetChanged(1, 30);
+    hitTestResult = test->moveMouseAndWaitUntilMouseTargetChanged(1, 100);
     g_assert(!webkit_hit_test_result_context_is_link(hitTestResult));
     g_assert(!webkit_hit_test_result_context_is_image(hitTestResult));
     g_assert(webkit_hit_test_result_context_is_media(hitTestResult));
@@ -540,7 +540,7 @@
     g_assert(!test->m_mouseTargetModifiers);
 
     // Mover over input.
-    hitTestResult = test->moveMouseAndWaitUntilMouseTargetChanged(5, 55);
+    hitTestResult = test->moveMouseAndWaitUntilMouseTargetChanged(5, 35);
     g_assert(!webkit_hit_test_result_context_is_link(hitTestResult));
     g_assert(!webkit_hit_test_result_context_is_image(hitTestResult));
     g_assert(!webkit_hit_test_result_context_is_media(hitTestResult));
@@ -549,7 +549,7 @@
     g_assert(!test->m_mouseTargetModifiers);
 
     // Move over scrollbar.
-    hitTestResult = test->moveMouseAndWaitUntilMouseTargetChanged(5, 95);
+    hitTestResult = test->moveMouseAndWaitUntilMouseTargetChanged(5, 75);
     g_assert(!webkit_hit_test_result_context_is_link(hitTestResult));
     g_assert(!webkit_hit_test_result_context_is_image(hitTestResult));
     g_assert(!webkit_hit_test_result_context_is_media(hitTestResult));

Modified: trunk/Tools/ChangeLog (144968 => 144969)


--- trunk/Tools/ChangeLog	2013-03-06 21:00:54 UTC (rev 144968)
+++ trunk/Tools/ChangeLog	2013-03-06 21:09:34 UTC (rev 144969)
@@ -1,3 +1,14 @@
+2013-03-06  Manuel Rego Casasnovas  <[email protected]>
+
+        [WK2][GTK] Fix unit test WebKit2APITests/WebKitWebView/mouse-target
+        https://bugs.webkit.org/show_bug.cgi?id=82866
+
+        Reviewed by Martin Robinson.
+
+        * Scripts/run-gtk-tests:
+        (TestRunner): Unflag WebKit2APITests/WebKitWebView/mouse-target test as
+        it is passing now.
+
 2013-03-06  Julie Parent  <[email protected]>
 
         Dashboard cleanup: remove dashboard time logging.

Modified: trunk/Tools/Scripts/run-gtk-tests (144968 => 144969)


--- trunk/Tools/Scripts/run-gtk-tests	2013-03-06 21:00:54 UTC (rev 144968)
+++ trunk/Tools/Scripts/run-gtk-tests	2013-03-06 21:09:34 UTC (rev 144969)
@@ -72,7 +72,6 @@
         SkippedTest("WebKit2APITests/TestWebKitAccessibility", "/webkit2/WebKitAccessibility/atspi-basic-hierarchy", "Test fails", 100408),
         SkippedTest("WebKit2APITests/TestWebKitFindController", "/webkit2/WebKitFindController/hide", "Test always fails in Xvfb", 89810),
         SkippedTest("WebKit2APITests/TestWebKitWebContext", "/webkit2/WebKitWebContext/uri-scheme", "Test fails", 104779),
-        SkippedTest("WebKit2APITests/TestWebKitWebView", "/webkit2/WebKitWebView/mouse-target", "Test is flaky in GTK Linux 32-bit Release bot", 82866),
         SkippedTest("TestWebKitAPI/TestWebKit2", "WebKit2.CanHandleRequest", "Test fails", 88453),
         SkippedTest("TestWebKitAPI/TestWebKit2", "WebKit2.MouseMoveAfterCrash", "Test is flaky", 85066),
         SkippedTest("TestWebKitAPI/TestWebKit2", "WebKit2.NewFirstVisuallyNonEmptyLayoutForImages", "Test is flaky", 85066),

_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to