Title: [145760] trunk/Source/WebCore
- Revision
- 145760
- Author
- [email protected]
- Date
- 2013-03-13 14:59:23 -0700 (Wed, 13 Mar 2013)
Log Message
IndexedDB: Record attemps to open a path with non-ascii characters
https://bugs.webkit.org/show_bug.cgi?id=112224
Reviewed by Tony Chang.
We want to see if that's correlated with errors on open.
No new tests, there's no way to test histogramming that I know of. I
ran chrome locally with a non ascii path though.
* Modules/indexeddb/IDBBackingStore.cpp:
(WebCore::IDBBackingStore::open):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (145759 => 145760)
--- trunk/Source/WebCore/ChangeLog 2013-03-13 21:51:07 UTC (rev 145759)
+++ trunk/Source/WebCore/ChangeLog 2013-03-13 21:59:23 UTC (rev 145760)
@@ -1,3 +1,18 @@
+2013-03-13 David Grogan <[email protected]>
+
+ IndexedDB: Record attemps to open a path with non-ascii characters
+ https://bugs.webkit.org/show_bug.cgi?id=112224
+
+ Reviewed by Tony Chang.
+
+ We want to see if that's correlated with errors on open.
+
+ No new tests, there's no way to test histogramming that I know of. I
+ ran chrome locally with a non ascii path though.
+
+ * Modules/indexeddb/IDBBackingStore.cpp:
+ (WebCore::IDBBackingStore::open):
+
2013-03-13 Julien Chaffraix <[email protected]>
[CSS Grid Layout] Handle min-width / max-width on the grid element
Modified: trunk/Source/WebCore/Modules/indexeddb/IDBBackingStore.cpp (145759 => 145760)
--- trunk/Source/WebCore/Modules/indexeddb/IDBBackingStore.cpp 2013-03-13 21:51:07 UTC (rev 145759)
+++ trunk/Source/WebCore/Modules/indexeddb/IDBBackingStore.cpp 2013-03-13 21:59:23 UTC (rev 145760)
@@ -365,6 +365,7 @@
IDBLevelDBBackingStoreOpenFailedIOErrCheckingSchema,
IDBLevelDBBackingStoreOpenFailedUnknownErr,
IDBLevelDBBackingStoreOpenMemoryFailed,
+ IDBLevelDBBackingStoreOpenAttemptNonASCII,
IDBLevelDBBackingStoreOpenMax,
};
@@ -391,6 +392,8 @@
}
HistogramSupport::histogramEnumeration("WebCore.IndexedDB.BackingStore.OpenStatus", IDBLevelDBBackingStoreOpenMemorySuccess, IDBLevelDBBackingStoreOpenMax);
} else {
+ if (!pathBase.containsOnlyASCII())
+ HistogramSupport::histogramEnumeration("WebCore.IndexedDB.BackingStore.OpenStatus", IDBLevelDBBackingStoreOpenAttemptNonASCII, IDBLevelDBBackingStoreOpenMax);
if (!makeAllDirectories(pathBase)) {
LOG_ERROR("Unable to create IndexedDB database path %s", pathBase.utf8().data());
HistogramSupport::histogramEnumeration("WebCore.IndexedDB.BackingStore.OpenStatus", IDBLevelDBBackingStoreOpenFailedDirectory, IDBLevelDBBackingStoreOpenMax);
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
