Title: [145761] trunk/Source/WebCore
- Revision
- 145761
- Author
- [email protected]
- Date
- 2013-03-13 15:24:08 -0700 (Wed, 13 Mar 2013)
Log Message
Also don't log error messages from the GraphicsContext3D if webGLErrorsToConsoleEnabled is false
https://bugs.webkit.org/show_bug.cgi?id=112284
Reviewed by Adam Barth.
When running layout tests in content_shell, we end up logging more information.
Since webGLErrorsToConsoleEnabled is false during layout tests, this change makes
sure we match the baselines.
* html/canvas/WebGLRenderingContext.cpp:
(WebCore):
(WebCore::WebGLRenderingContextErrorMessageCallback::onErrorMessage):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (145760 => 145761)
--- trunk/Source/WebCore/ChangeLog 2013-03-13 21:59:23 UTC (rev 145760)
+++ trunk/Source/WebCore/ChangeLog 2013-03-13 22:24:08 UTC (rev 145761)
@@ -1,3 +1,18 @@
+2013-03-13 Jochen Eisinger <[email protected]>
+
+ Also don't log error messages from the GraphicsContext3D if webGLErrorsToConsoleEnabled is false
+ https://bugs.webkit.org/show_bug.cgi?id=112284
+
+ Reviewed by Adam Barth.
+
+ When running layout tests in content_shell, we end up logging more information.
+ Since webGLErrorsToConsoleEnabled is false during layout tests, this change makes
+ sure we match the baselines.
+
+ * html/canvas/WebGLRenderingContext.cpp:
+ (WebCore):
+ (WebCore::WebGLRenderingContextErrorMessageCallback::onErrorMessage):
+
2013-03-13 David Grogan <[email protected]>
IndexedDB: Record attemps to open a path with non-ascii characters
Modified: trunk/Source/WebCore/html/canvas/WebGLRenderingContext.cpp (145760 => 145761)
--- trunk/Source/WebCore/html/canvas/WebGLRenderingContext.cpp 2013-03-13 21:59:23 UTC (rev 145760)
+++ trunk/Source/WebCore/html/canvas/WebGLRenderingContext.cpp 2013-03-13 22:24:08 UTC (rev 145761)
@@ -393,7 +393,11 @@
WTF_MAKE_FAST_ALLOCATED;
public:
explicit WebGLRenderingContextErrorMessageCallback(WebGLRenderingContext* cb) : m_context(cb) { }
- virtual void onErrorMessage(const String& message, GC3Dint) { m_context->printGLErrorToConsole(message); }
+ virtual void onErrorMessage(const String& message, GC3Dint)
+ {
+ if (m_context->m_synthesizedErrorsToConsole)
+ m_context->printGLErrorToConsole(message);
+ }
virtual ~WebGLRenderingContextErrorMessageCallback() { }
private:
WebGLRenderingContext* m_context;
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
