Title: [146406] trunk/LayoutTests
- Revision
- 146406
- Author
- [email protected]
- Date
- 2013-03-20 16:04:44 -0700 (Wed, 20 Mar 2013)
Log Message
dialog-enabled.html and dialog-disabled.html don't really test what they think they do
https://bugs.webkit.org/show_bug.cgi?id=112848
Reviewed by Adam Barth.
* fast/dom/HTMLDialogElement/dialog-disabled.html:
* fast/dom/HTMLDialogElement/dialog-enabled.html:
Set the dialog element enabled setting before parsing <dialog> element.
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (146405 => 146406)
--- trunk/LayoutTests/ChangeLog 2013-03-20 23:03:22 UTC (rev 146405)
+++ trunk/LayoutTests/ChangeLog 2013-03-20 23:04:44 UTC (rev 146406)
@@ -1,3 +1,14 @@
+2013-03-20 Tom Sepez <[email protected]>
+
+ dialog-enabled.html and dialog-disabled.html don't really test what they think they do
+ https://bugs.webkit.org/show_bug.cgi?id=112848
+
+ Reviewed by Adam Barth.
+
+ * fast/dom/HTMLDialogElement/dialog-disabled.html:
+ * fast/dom/HTMLDialogElement/dialog-enabled.html:
+ Set the dialog element enabled setting before parsing <dialog> element.
+
2013-03-20 Ryosuke Niwa <[email protected]>
Mac rebaseline after r142152.
Modified: trunk/LayoutTests/fast/dom/HTMLDialogElement/dialog-disabled.html (146405 => 146406)
--- trunk/LayoutTests/fast/dom/HTMLDialogElement/dialog-disabled.html 2013-03-20 23:03:22 UTC (rev 146405)
+++ trunk/LayoutTests/fast/dom/HTMLDialogElement/dialog-disabled.html 2013-03-20 23:04:44 UTC (rev 146406)
@@ -1,14 +1,16 @@
<!DOCTYPE html>
<html>
<head>
+<script>
+if (window.internals)
+ internals.settings.setDialogElementEnabled(false);
+</script>
<script src=""
</head>
<body>
<dialog id="mydialog"></dialog>
<script>
description("The DIALOG element should not be recognized if the dialog feature is off.");
-if (window.internals)
- internals.settings.setDialogElementEnabled(false);
dialog = document.getElementById('mydialog');
shouldBeTrue("typeof dialog.show == 'undefined'");
</script>
Modified: trunk/LayoutTests/fast/dom/HTMLDialogElement/dialog-enabled.html (146405 => 146406)
--- trunk/LayoutTests/fast/dom/HTMLDialogElement/dialog-enabled.html 2013-03-20 23:03:22 UTC (rev 146405)
+++ trunk/LayoutTests/fast/dom/HTMLDialogElement/dialog-enabled.html 2013-03-20 23:04:44 UTC (rev 146406)
@@ -1,14 +1,16 @@
<!DOCTYPE html>
<html>
<head>
+<script>
+if (window.internals)
+ internals.settings.setDialogElementEnabled(true);
+</script>
<script src=""
</head>
<body>
<dialog id="mydialog"></dialog>
<script>
description("The DIALOG element should be recognized if the dialog feature is on.");
-if (window.internals)
- internals.settings.setDialogElementEnabled(true);
dialog = document.getElementById('mydialog');
shouldBeTrue("typeof dialog.show == 'function'");
</script>
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
