Title: [146407] trunk/Source/_javascript_Core
Revision
146407
Author
[email protected]
Date
2013-03-20 16:16:01 -0700 (Wed, 20 Mar 2013)

Log Message

Fix indentation of JSString.h

Rubber stamped by Mark Hahnenberg.

* runtime/JSString.h:

Modified Paths

Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (146406 => 146407)


--- trunk/Source/_javascript_Core/ChangeLog	2013-03-20 23:04:44 UTC (rev 146406)
+++ trunk/Source/_javascript_Core/ChangeLog	2013-03-20 23:16:01 UTC (rev 146407)
@@ -1,5 +1,13 @@
 2013-03-20  Filip Pizlo  <[email protected]>
 
+        Fix indentation of JSString.h
+
+        Rubber stamped by Mark Hahnenberg.
+
+        * runtime/JSString.h:
+
+2013-03-20  Filip Pizlo  <[email protected]>
+
         "" + x where x is not a string should be optimized by the DFG to some manner of ToString conversion
         https://bugs.webkit.org/show_bug.cgi?id=112845
 

Modified: trunk/Source/_javascript_Core/runtime/JSString.h (146406 => 146407)


--- trunk/Source/_javascript_Core/runtime/JSString.h	2013-03-20 23:04:44 UTC (rev 146406)
+++ trunk/Source/_javascript_Core/runtime/JSString.h	2013-03-20 23:16:01 UTC (rev 146407)
@@ -31,523 +31,523 @@
 
 namespace JSC {
 
-    class JSString;
-    class JSRopeString;
-    class LLIntOffsetsExtractor;
+class JSString;
+class JSRopeString;
+class LLIntOffsetsExtractor;
 
-    JSString* jsEmptyString(JSGlobalData*);
-    JSString* jsEmptyString(ExecState*);
-    JSString* jsString(JSGlobalData*, const String&); // returns empty string if passed null string
-    JSString* jsString(ExecState*, const String&); // returns empty string if passed null string
+JSString* jsEmptyString(JSGlobalData*);
+JSString* jsEmptyString(ExecState*);
+JSString* jsString(JSGlobalData*, const String&); // returns empty string if passed null string
+JSString* jsString(ExecState*, const String&); // returns empty string if passed null string
 
-    JSString* jsSingleCharacterString(JSGlobalData*, UChar);
-    JSString* jsSingleCharacterString(ExecState*, UChar);
-    JSString* jsSingleCharacterSubstring(ExecState*, const String&, unsigned offset);
-    JSString* jsSubstring(JSGlobalData*, const String&, unsigned offset, unsigned length);
-    JSString* jsSubstring(ExecState*, const String&, unsigned offset, unsigned length);
+JSString* jsSingleCharacterString(JSGlobalData*, UChar);
+JSString* jsSingleCharacterString(ExecState*, UChar);
+JSString* jsSingleCharacterSubstring(ExecState*, const String&, unsigned offset);
+JSString* jsSubstring(JSGlobalData*, const String&, unsigned offset, unsigned length);
+JSString* jsSubstring(ExecState*, const String&, unsigned offset, unsigned length);
 
-    // Non-trivial strings are two or more characters long.
-    // These functions are faster than just calling jsString.
-    JSString* jsNontrivialString(JSGlobalData*, const String&);
-    JSString* jsNontrivialString(ExecState*, const String&);
+// Non-trivial strings are two or more characters long.
+// These functions are faster than just calling jsString.
+JSString* jsNontrivialString(JSGlobalData*, const String&);
+JSString* jsNontrivialString(ExecState*, const String&);
 
-    // Should be used for strings that are owned by an object that will
-    // likely outlive the JSValue this makes, such as the parse tree or a
-    // DOM object that contains a String
-    JSString* jsOwnedString(JSGlobalData*, const String&);
-    JSString* jsOwnedString(ExecState*, const String&);
+// Should be used for strings that are owned by an object that will
+// likely outlive the JSValue this makes, such as the parse tree or a
+// DOM object that contains a String
+JSString* jsOwnedString(JSGlobalData*, const String&);
+JSString* jsOwnedString(ExecState*, const String&);
 
-    JSRopeString* jsStringBuilder(JSGlobalData*);
+JSRopeString* jsStringBuilder(JSGlobalData*);
 
-    class JSString : public JSCell {
-    public:
-        friend class JIT;
-        friend class JSGlobalData;
-        friend class SpecializedThunkJIT;
-        friend class JSRopeString;
-        friend class MarkStack;
-        friend class SlotVisitor;
-        friend struct ThunkHelpers;
+class JSString : public JSCell {
+public:
+    friend class JIT;
+    friend class JSGlobalData;
+    friend class SpecializedThunkJIT;
+    friend class JSRopeString;
+    friend class MarkStack;
+    friend class SlotVisitor;
+    friend struct ThunkHelpers;
 
-        typedef JSCell Base;
+    typedef JSCell Base;
 
-        static const bool needsDestruction = true;
-        static const bool hasImmortalStructure = true;
-        static void destroy(JSCell*);
+    static const bool needsDestruction = true;
+    static const bool hasImmortalStructure = true;
+    static void destroy(JSCell*);
 
-    private:
-        JSString(JSGlobalData& globalData, PassRefPtr<StringImpl> value)
-            : JSCell(globalData, globalData.stringStructure.get())
-            , m_flags(0)
-            , m_value(value)
-        {
-        }
+private:
+    JSString(JSGlobalData& globalData, PassRefPtr<StringImpl> value)
+        : JSCell(globalData, globalData.stringStructure.get())
+        , m_flags(0)
+        , m_value(value)
+    {
+    }
 
-        JSString(JSGlobalData& globalData)
-            : JSCell(globalData, globalData.stringStructure.get())
-            , m_flags(0)
-        {
-        }
+    JSString(JSGlobalData& globalData)
+        : JSCell(globalData, globalData.stringStructure.get())
+        , m_flags(0)
+    {
+    }
 
-        void finishCreation(JSGlobalData& globalData, size_t length)
-        {
-            ASSERT(!m_value.isNull());
-            Base::finishCreation(globalData);
-            m_length = length;
-            setIs8Bit(m_value.impl()->is8Bit());
-            globalData.m_newStringsSinceLastHashCons++;
-        }
+    void finishCreation(JSGlobalData& globalData, size_t length)
+    {
+        ASSERT(!m_value.isNull());
+        Base::finishCreation(globalData);
+        m_length = length;
+        setIs8Bit(m_value.impl()->is8Bit());
+        globalData.m_newStringsSinceLastHashCons++;
+    }
 
-        void finishCreation(JSGlobalData& globalData, size_t length, size_t cost)
-        {
-            ASSERT(!m_value.isNull());
-            Base::finishCreation(globalData);
-            m_length = length;
-            setIs8Bit(m_value.impl()->is8Bit());
-            Heap::heap(this)->reportExtraMemoryCost(cost);
-            globalData.m_newStringsSinceLastHashCons++;
-        }
+    void finishCreation(JSGlobalData& globalData, size_t length, size_t cost)
+    {
+        ASSERT(!m_value.isNull());
+        Base::finishCreation(globalData);
+        m_length = length;
+        setIs8Bit(m_value.impl()->is8Bit());
+        Heap::heap(this)->reportExtraMemoryCost(cost);
+        globalData.m_newStringsSinceLastHashCons++;
+    }
 
-    protected:
-        void finishCreation(JSGlobalData& globalData)
-        {
-            Base::finishCreation(globalData);
-            m_length = 0;
-            setIs8Bit(true);
-            globalData.m_newStringsSinceLastHashCons++;
-        }
+protected:
+    void finishCreation(JSGlobalData& globalData)
+    {
+        Base::finishCreation(globalData);
+        m_length = 0;
+        setIs8Bit(true);
+        globalData.m_newStringsSinceLastHashCons++;
+    }
         
-    public:
-        static JSString* create(JSGlobalData& globalData, PassRefPtr<StringImpl> value)
-        {
-            ASSERT(value);
-            size_t length = value->length();
-            size_t cost = value->cost();
-            JSString* newString = new (NotNull, allocateCell<JSString>(globalData.heap)) JSString(globalData, value);
-            newString->finishCreation(globalData, length, cost);
-            return newString;
-        }
-        static JSString* createHasOtherOwner(JSGlobalData& globalData, PassRefPtr<StringImpl> value)
-        {
-            ASSERT(value);
-            size_t length = value->length();
-            JSString* newString = new (NotNull, allocateCell<JSString>(globalData.heap)) JSString(globalData, value);
-            newString->finishCreation(globalData, length);
-            return newString;
-        }
+public:
+    static JSString* create(JSGlobalData& globalData, PassRefPtr<StringImpl> value)
+    {
+        ASSERT(value);
+        size_t length = value->length();
+        size_t cost = value->cost();
+        JSString* newString = new (NotNull, allocateCell<JSString>(globalData.heap)) JSString(globalData, value);
+        newString->finishCreation(globalData, length, cost);
+        return newString;
+    }
+    static JSString* createHasOtherOwner(JSGlobalData& globalData, PassRefPtr<StringImpl> value)
+    {
+        ASSERT(value);
+        size_t length = value->length();
+        JSString* newString = new (NotNull, allocateCell<JSString>(globalData.heap)) JSString(globalData, value);
+        newString->finishCreation(globalData, length);
+        return newString;
+    }
 
-        const String& value(ExecState*) const;
-        const String& tryGetValue() const;
-        unsigned length() { return m_length; }
+    const String& value(ExecState*) const;
+    const String& tryGetValue() const;
+    unsigned length() { return m_length; }
 
-        JSValue toPrimitive(ExecState*, PreferredPrimitiveType) const;
-        JS_EXPORT_PRIVATE bool toBoolean() const;
-        bool getPrimitiveNumber(ExecState*, double& number, JSValue&) const;
-        JSObject* toObject(ExecState*, JSGlobalObject*) const;
-        double toNumber(ExecState*) const;
+    JSValue toPrimitive(ExecState*, PreferredPrimitiveType) const;
+    JS_EXPORT_PRIVATE bool toBoolean() const;
+    bool getPrimitiveNumber(ExecState*, double& number, JSValue&) const;
+    JSObject* toObject(ExecState*, JSGlobalObject*) const;
+    double toNumber(ExecState*) const;
         
-        bool getStringPropertySlot(ExecState*, PropertyName, PropertySlot&);
-        bool getStringPropertySlot(ExecState*, unsigned propertyName, PropertySlot&);
-        bool getStringPropertyDescriptor(ExecState*, PropertyName, PropertyDescriptor&);
+    bool getStringPropertySlot(ExecState*, PropertyName, PropertySlot&);
+    bool getStringPropertySlot(ExecState*, unsigned propertyName, PropertySlot&);
+    bool getStringPropertyDescriptor(ExecState*, PropertyName, PropertyDescriptor&);
 
-        bool canGetIndex(unsigned i) { return i < m_length; }
-        JSString* getIndex(ExecState*, unsigned);
+    bool canGetIndex(unsigned i) { return i < m_length; }
+    JSString* getIndex(ExecState*, unsigned);
 
-        static Structure* createStructure(JSGlobalData& globalData, JSGlobalObject* globalObject, JSValue proto)
-        {
-            return Structure::create(globalData, globalObject, proto, TypeInfo(StringType, OverridesGetOwnPropertySlot | InterceptsGetOwnPropertySlotByIndexEvenWhenLengthIsNotZero), &s_info);
-        }
+    static Structure* createStructure(JSGlobalData& globalData, JSGlobalObject* globalObject, JSValue proto)
+    {
+        return Structure::create(globalData, globalObject, proto, TypeInfo(StringType, OverridesGetOwnPropertySlot | InterceptsGetOwnPropertySlotByIndexEvenWhenLengthIsNotZero), &s_info);
+    }
 
-        static size_t offsetOfLength() { return OBJECT_OFFSETOF(JSString, m_length); }
-        static size_t offsetOfFlags() { return OBJECT_OFFSETOF(JSString, m_flags); }
-        static size_t offsetOfValue() { return OBJECT_OFFSETOF(JSString, m_value); }
+    static size_t offsetOfLength() { return OBJECT_OFFSETOF(JSString, m_length); }
+    static size_t offsetOfFlags() { return OBJECT_OFFSETOF(JSString, m_flags); }
+    static size_t offsetOfValue() { return OBJECT_OFFSETOF(JSString, m_value); }
 
-        static JS_EXPORTDATA const ClassInfo s_info;
+    static JS_EXPORTDATA const ClassInfo s_info;
 
-        static void visitChildren(JSCell*, SlotVisitor&);
+    static void visitChildren(JSCell*, SlotVisitor&);
 
-        enum {
-            HashConsLock = 1u << 2,
-            IsHashConsSingleton = 1u << 1,
-            Is8Bit = 1u
-        };
+    enum {
+        HashConsLock = 1u << 2,
+        IsHashConsSingleton = 1u << 1,
+        Is8Bit = 1u
+    };
 
-    protected:
-        friend class JSValue;
+protected:
+    friend class JSValue;
         
-        bool isRope() const { return m_value.isNull(); }
-        bool is8Bit() const { return m_flags & Is8Bit; }
-        void setIs8Bit(bool flag)
-        {
-            if (flag)
-                m_flags |= Is8Bit;
-            else
-                m_flags &= ~Is8Bit;
-        }
-        bool shouldTryHashCons();
-        bool isHashConsSingleton() const { return m_flags & IsHashConsSingleton; }
-        void clearHashConsSingleton() { m_flags &= ~IsHashConsSingleton; }
-        void setHashConsSingleton() { m_flags |= IsHashConsSingleton; }
-        bool tryHashConsLock();
-        void releaseHashConsLock();
+    bool isRope() const { return m_value.isNull(); }
+    bool is8Bit() const { return m_flags & Is8Bit; }
+    void setIs8Bit(bool flag)
+    {
+        if (flag)
+            m_flags |= Is8Bit;
+        else
+            m_flags &= ~Is8Bit;
+    }
+    bool shouldTryHashCons();
+    bool isHashConsSingleton() const { return m_flags & IsHashConsSingleton; }
+    void clearHashConsSingleton() { m_flags &= ~IsHashConsSingleton; }
+    void setHashConsSingleton() { m_flags |= IsHashConsSingleton; }
+    bool tryHashConsLock();
+    void releaseHashConsLock();
 
-        unsigned m_flags;
+    unsigned m_flags;
         
-        // A string is represented either by a String or a rope of fibers.
-        unsigned m_length;
-        mutable String m_value;
+    // A string is represented either by a String or a rope of fibers.
+    unsigned m_length;
+    mutable String m_value;
 
-    private:
-        friend class LLIntOffsetsExtractor;
+private:
+    friend class LLIntOffsetsExtractor;
         
-        static JSObject* toThisObject(JSCell*, ExecState*);
+    static JSObject* toThisObject(JSCell*, ExecState*);
 
-        // Actually getPropertySlot, not getOwnPropertySlot (see JSCell).
-        static bool getOwnPropertySlot(JSCell*, ExecState*, PropertyName, PropertySlot&);
-        static bool getOwnPropertySlotByIndex(JSCell*, ExecState*, unsigned propertyName, PropertySlot&);
+    // Actually getPropertySlot, not getOwnPropertySlot (see JSCell).
+    static bool getOwnPropertySlot(JSCell*, ExecState*, PropertyName, PropertySlot&);
+    static bool getOwnPropertySlotByIndex(JSCell*, ExecState*, unsigned propertyName, PropertySlot&);
 
-        String& string() { ASSERT(!isRope()); return m_value; }
+    String& string() { ASSERT(!isRope()); return m_value; }
 
-        friend JSValue jsString(ExecState*, JSString*, JSString*);
-        friend JSString* jsSubstring(ExecState*, JSString*, unsigned offset, unsigned length);
-    };
+    friend JSValue jsString(ExecState*, JSString*, JSString*);
+    friend JSString* jsSubstring(ExecState*, JSString*, unsigned offset, unsigned length);
+};
 
-    class JSRopeString : public JSString {
-        friend class JSString;
+class JSRopeString : public JSString {
+    friend class JSString;
 
-        friend JSRopeString* jsStringBuilder(JSGlobalData*);
+    friend JSRopeString* jsStringBuilder(JSGlobalData*);
 
-        class RopeBuilder {
-        public:
-            RopeBuilder(JSGlobalData& globalData)
+    class RopeBuilder {
+    public:
+        RopeBuilder(JSGlobalData& globalData)
             : m_globalData(globalData)
             , m_jsString(jsStringBuilder(&globalData))
             , m_index(0)
-            {
-            }
-
-            void append(JSString* jsString)
-            {
-                if (m_index == JSRopeString::s_maxInternalRopeLength)
-                    expand();
-                m_jsString->append(m_globalData, m_index++, jsString);
-            }
-
-            JSRopeString* release()
-            {
-                JSRopeString* tmp = m_jsString;
-                m_jsString = 0;
-                return tmp;
-            }
-
-            unsigned length() { return m_jsString->m_length; }
-
-        private:
-            void expand();
-            
-            JSGlobalData& m_globalData;
-            JSRopeString* m_jsString;
-            size_t m_index;
-        };
-        
-    private:
-        JSRopeString(JSGlobalData& globalData)
-            : JSString(globalData)
         {
         }
 
-        void finishCreation(JSGlobalData& globalData, JSString* s1, JSString* s2)
+        void append(JSString* jsString)
         {
-            Base::finishCreation(globalData);
-            m_length = s1->length() + s2->length();
-            setIs8Bit(s1->is8Bit() && s2->is8Bit());
-            m_fibers[0].set(globalData, this, s1);
-            m_fibers[1].set(globalData, this, s2);
+            if (m_index == JSRopeString::s_maxInternalRopeLength)
+                expand();
+            m_jsString->append(m_globalData, m_index++, jsString);
         }
-        
-        void finishCreation(JSGlobalData& globalData, JSString* s1, JSString* s2, JSString* s3)
-        {
-            Base::finishCreation(globalData);
-            m_length = s1->length() + s2->length() + s3->length();
-            setIs8Bit(s1->is8Bit() && s2->is8Bit() &&  s3->is8Bit());
-            m_fibers[0].set(globalData, this, s1);
-            m_fibers[1].set(globalData, this, s2);
-            m_fibers[2].set(globalData, this, s3);
-        }
 
-        void finishCreation(JSGlobalData& globalData)
+        JSRopeString* release()
         {
-            JSString::finishCreation(globalData);
+            JSRopeString* tmp = m_jsString;
+            m_jsString = 0;
+            return tmp;
         }
 
-        void append(JSGlobalData& globalData, size_t index, JSString* jsString)
-        {
-            m_fibers[index].set(globalData, this, jsString);
-            m_length += jsString->m_length;
-            setIs8Bit(is8Bit() && jsString->is8Bit());
-        }
+        unsigned length() { return m_jsString->m_length; }
 
-        static JSRopeString* createNull(JSGlobalData& globalData)
-        {
-            JSRopeString* newString = new (NotNull, allocateCell<JSRopeString>(globalData.heap)) JSRopeString(globalData);
-            newString->finishCreation(globalData);
-            return newString;
-        }
-
-    public:
-        static JSString* create(JSGlobalData& globalData, JSString* s1, JSString* s2)
-        {
-            JSRopeString* newString = new (NotNull, allocateCell<JSRopeString>(globalData.heap)) JSRopeString(globalData);
-            newString->finishCreation(globalData, s1, s2);
-            return newString;
-        }
-        static JSString* create(JSGlobalData& globalData, JSString* s1, JSString* s2, JSString* s3)
-        {
-            JSRopeString* newString = new (NotNull, allocateCell<JSRopeString>(globalData.heap)) JSRopeString(globalData);
-            newString->finishCreation(globalData, s1, s2, s3);
-            return newString;
-        }
-
-        void visitFibers(SlotVisitor&);
-        
-        static ptrdiff_t offsetOfFibers() { return OBJECT_OFFSETOF(JSRopeString, m_fibers); }
-
-        static const unsigned s_maxInternalRopeLength = 3;
-        
     private:
-        friend JSValue jsString(ExecState*, Register*, unsigned);
-        friend JSValue jsStringFromArguments(ExecState*, JSValue);
-
-        JS_EXPORT_PRIVATE void resolveRope(ExecState*) const;
-        void resolveRopeSlowCase8(LChar*) const;
-        void resolveRopeSlowCase(UChar*) const;
-        void outOfMemory(ExecState*) const;
+        void expand();
+            
+        JSGlobalData& m_globalData;
+        JSRopeString* m_jsString;
+        size_t m_index;
+    };
         
-        JSString* getIndexSlowCase(ExecState*, unsigned);
-
-        mutable FixedArray<WriteBarrier<JSString>, s_maxInternalRopeLength> m_fibers;
-    };
-
-    JSString* asString(JSValue);
-
-    inline JSString* asString(JSValue value)
+private:
+    JSRopeString(JSGlobalData& globalData)
+        : JSString(globalData)
     {
-        ASSERT(value.asCell()->isString());
-        return jsCast<JSString*>(value.asCell());
     }
 
-    inline JSString* jsEmptyString(JSGlobalData* globalData)
+    void finishCreation(JSGlobalData& globalData, JSString* s1, JSString* s2)
     {
-        return globalData->smallStrings.emptyString();
+        Base::finishCreation(globalData);
+        m_length = s1->length() + s2->length();
+        setIs8Bit(s1->is8Bit() && s2->is8Bit());
+        m_fibers[0].set(globalData, this, s1);
+        m_fibers[1].set(globalData, this, s2);
     }
-
-    ALWAYS_INLINE JSString* jsSingleCharacterString(JSGlobalData* globalData, UChar c)
+        
+    void finishCreation(JSGlobalData& globalData, JSString* s1, JSString* s2, JSString* s3)
     {
-        if (c <= maxSingleCharacterString)
-            return globalData->smallStrings.singleCharacterString(globalData, c);
-        return JSString::create(*globalData, String(&c, 1).impl());
+        Base::finishCreation(globalData);
+        m_length = s1->length() + s2->length() + s3->length();
+        setIs8Bit(s1->is8Bit() && s2->is8Bit() &&  s3->is8Bit());
+        m_fibers[0].set(globalData, this, s1);
+        m_fibers[1].set(globalData, this, s2);
+        m_fibers[2].set(globalData, this, s3);
     }
 
-    ALWAYS_INLINE JSString* jsSingleCharacterSubstring(ExecState* exec, const String& s, unsigned offset)
+    void finishCreation(JSGlobalData& globalData)
     {
-        JSGlobalData* globalData = &exec->globalData();
-        ASSERT(offset < static_cast<unsigned>(s.length()));
-        UChar c = s.characterAt(offset);
-        if (c <= maxSingleCharacterString)
-            return globalData->smallStrings.singleCharacterString(globalData, c);
-        return JSString::create(*globalData, StringImpl::create(s.impl(), offset, 1));
+        JSString::finishCreation(globalData);
     }
 
-    inline JSString* jsNontrivialString(JSGlobalData* globalData, const String& s)
+    void append(JSGlobalData& globalData, size_t index, JSString* jsString)
     {
-        ASSERT(s.length() > 1);
-        return JSString::create(*globalData, s.impl());
+        m_fibers[index].set(globalData, this, jsString);
+        m_length += jsString->m_length;
+        setIs8Bit(is8Bit() && jsString->is8Bit());
     }
 
-    inline const String& JSString::value(ExecState* exec) const
+    static JSRopeString* createNull(JSGlobalData& globalData)
     {
-        if (isRope())
-            static_cast<const JSRopeString*>(this)->resolveRope(exec);
-        return m_value;
+        JSRopeString* newString = new (NotNull, allocateCell<JSRopeString>(globalData.heap)) JSRopeString(globalData);
+        newString->finishCreation(globalData);
+        return newString;
     }
 
-    inline const String& JSString::tryGetValue() const
+public:
+    static JSString* create(JSGlobalData& globalData, JSString* s1, JSString* s2)
     {
-        if (isRope())
-            static_cast<const JSRopeString*>(this)->resolveRope(0);
-        return m_value;
+        JSRopeString* newString = new (NotNull, allocateCell<JSRopeString>(globalData.heap)) JSRopeString(globalData);
+        newString->finishCreation(globalData, s1, s2);
+        return newString;
     }
-
-    inline JSString* JSString::getIndex(ExecState* exec, unsigned i)
+    static JSString* create(JSGlobalData& globalData, JSString* s1, JSString* s2, JSString* s3)
     {
-        ASSERT(canGetIndex(i));
-        if (isRope())
-            return static_cast<JSRopeString*>(this)->getIndexSlowCase(exec, i);
-        ASSERT(i < m_value.length());
-        return jsSingleCharacterSubstring(exec, m_value, i);
+        JSRopeString* newString = new (NotNull, allocateCell<JSRopeString>(globalData.heap)) JSRopeString(globalData);
+        newString->finishCreation(globalData, s1, s2, s3);
+        return newString;
     }
 
-    inline JSString* jsString(JSGlobalData* globalData, const String& s)
-    {
-        int size = s.length();
-        if (!size)
-            return globalData->smallStrings.emptyString();
-        if (size == 1) {
-            UChar c = s.characterAt(0);
-            if (c <= maxSingleCharacterString)
-                return globalData->smallStrings.singleCharacterString(globalData, c);
-        }
-        return JSString::create(*globalData, s.impl());
-    }
+    void visitFibers(SlotVisitor&);
+        
+    static ptrdiff_t offsetOfFibers() { return OBJECT_OFFSETOF(JSRopeString, m_fibers); }
 
-    inline JSString* jsSubstring(ExecState* exec, JSString* s, unsigned offset, unsigned length)
-    {
-        ASSERT(offset <= static_cast<unsigned>(s->length()));
-        ASSERT(length <= static_cast<unsigned>(s->length()));
-        ASSERT(offset + length <= static_cast<unsigned>(s->length()));
-        JSGlobalData* globalData = &exec->globalData();
-        if (!length)
-            return globalData->smallStrings.emptyString();
-        return jsSubstring(globalData, s->value(exec), offset, length);
-    }
+    static const unsigned s_maxInternalRopeLength = 3;
+        
+private:
+    friend JSValue jsString(ExecState*, Register*, unsigned);
+    friend JSValue jsStringFromArguments(ExecState*, JSValue);
 
-    inline JSString* jsSubstring8(JSGlobalData* globalData, const String& s, unsigned offset, unsigned length)
-    {
-        ASSERT(offset <= static_cast<unsigned>(s.length()));
-        ASSERT(length <= static_cast<unsigned>(s.length()));
-        ASSERT(offset + length <= static_cast<unsigned>(s.length()));
-        if (!length)
-            return globalData->smallStrings.emptyString();
-        if (length == 1) {
-            UChar c = s.characterAt(offset);
-            if (c <= maxSingleCharacterString)
-                return globalData->smallStrings.singleCharacterString(globalData, c);
-        }
-        return JSString::createHasOtherOwner(*globalData, StringImpl::create8(s.impl(), offset, length));
+    JS_EXPORT_PRIVATE void resolveRope(ExecState*) const;
+    void resolveRopeSlowCase8(LChar*) const;
+    void resolveRopeSlowCase(UChar*) const;
+    void outOfMemory(ExecState*) const;
+        
+    JSString* getIndexSlowCase(ExecState*, unsigned);
+
+    mutable FixedArray<WriteBarrier<JSString>, s_maxInternalRopeLength> m_fibers;
+};
+
+JSString* asString(JSValue);
+
+inline JSString* asString(JSValue value)
+{
+    ASSERT(value.asCell()->isString());
+    return jsCast<JSString*>(value.asCell());
+}
+
+inline JSString* jsEmptyString(JSGlobalData* globalData)
+{
+    return globalData->smallStrings.emptyString();
+}
+
+ALWAYS_INLINE JSString* jsSingleCharacterString(JSGlobalData* globalData, UChar c)
+{
+    if (c <= maxSingleCharacterString)
+        return globalData->smallStrings.singleCharacterString(globalData, c);
+    return JSString::create(*globalData, String(&c, 1).impl());
+}
+
+ALWAYS_INLINE JSString* jsSingleCharacterSubstring(ExecState* exec, const String& s, unsigned offset)
+{
+    JSGlobalData* globalData = &exec->globalData();
+    ASSERT(offset < static_cast<unsigned>(s.length()));
+    UChar c = s.characterAt(offset);
+    if (c <= maxSingleCharacterString)
+        return globalData->smallStrings.singleCharacterString(globalData, c);
+    return JSString::create(*globalData, StringImpl::create(s.impl(), offset, 1));
+}
+
+inline JSString* jsNontrivialString(JSGlobalData* globalData, const String& s)
+{
+    ASSERT(s.length() > 1);
+    return JSString::create(*globalData, s.impl());
+}
+
+inline const String& JSString::value(ExecState* exec) const
+{
+    if (isRope())
+        static_cast<const JSRopeString*>(this)->resolveRope(exec);
+    return m_value;
+}
+
+inline const String& JSString::tryGetValue() const
+{
+    if (isRope())
+        static_cast<const JSRopeString*>(this)->resolveRope(0);
+    return m_value;
+}
+
+inline JSString* JSString::getIndex(ExecState* exec, unsigned i)
+{
+    ASSERT(canGetIndex(i));
+    if (isRope())
+        return static_cast<JSRopeString*>(this)->getIndexSlowCase(exec, i);
+    ASSERT(i < m_value.length());
+    return jsSingleCharacterSubstring(exec, m_value, i);
+}
+
+inline JSString* jsString(JSGlobalData* globalData, const String& s)
+{
+    int size = s.length();
+    if (!size)
+        return globalData->smallStrings.emptyString();
+    if (size == 1) {
+        UChar c = s.characterAt(0);
+        if (c <= maxSingleCharacterString)
+            return globalData->smallStrings.singleCharacterString(globalData, c);
     }
+    return JSString::create(*globalData, s.impl());
+}
 
-    inline JSString* jsSubstring(JSGlobalData* globalData, const String& s, unsigned offset, unsigned length)
-    {
-        ASSERT(offset <= static_cast<unsigned>(s.length()));
-        ASSERT(length <= static_cast<unsigned>(s.length()));
-        ASSERT(offset + length <= static_cast<unsigned>(s.length()));
-        if (!length)
-            return globalData->smallStrings.emptyString();
-        if (length == 1) {
-            UChar c = s.characterAt(offset);
-            if (c <= maxSingleCharacterString)
-                return globalData->smallStrings.singleCharacterString(globalData, c);
-        }
-        return JSString::createHasOtherOwner(*globalData, StringImpl::create(s.impl(), offset, length));
+inline JSString* jsSubstring(ExecState* exec, JSString* s, unsigned offset, unsigned length)
+{
+    ASSERT(offset <= static_cast<unsigned>(s->length()));
+    ASSERT(length <= static_cast<unsigned>(s->length()));
+    ASSERT(offset + length <= static_cast<unsigned>(s->length()));
+    JSGlobalData* globalData = &exec->globalData();
+    if (!length)
+        return globalData->smallStrings.emptyString();
+    return jsSubstring(globalData, s->value(exec), offset, length);
+}
+
+inline JSString* jsSubstring8(JSGlobalData* globalData, const String& s, unsigned offset, unsigned length)
+{
+    ASSERT(offset <= static_cast<unsigned>(s.length()));
+    ASSERT(length <= static_cast<unsigned>(s.length()));
+    ASSERT(offset + length <= static_cast<unsigned>(s.length()));
+    if (!length)
+        return globalData->smallStrings.emptyString();
+    if (length == 1) {
+        UChar c = s.characterAt(offset);
+        if (c <= maxSingleCharacterString)
+            return globalData->smallStrings.singleCharacterString(globalData, c);
     }
+    return JSString::createHasOtherOwner(*globalData, StringImpl::create8(s.impl(), offset, length));
+}
 
-    inline JSString* jsOwnedString(JSGlobalData* globalData, const String& s)
-    {
-        int size = s.length();
-        if (!size)
-            return globalData->smallStrings.emptyString();
-        if (size == 1) {
-            UChar c = s.characterAt(0);
-            if (c <= maxSingleCharacterString)
-                return globalData->smallStrings.singleCharacterString(globalData, c);
-        }
-        return JSString::createHasOtherOwner(*globalData, s.impl());
+inline JSString* jsSubstring(JSGlobalData* globalData, const String& s, unsigned offset, unsigned length)
+{
+    ASSERT(offset <= static_cast<unsigned>(s.length()));
+    ASSERT(length <= static_cast<unsigned>(s.length()));
+    ASSERT(offset + length <= static_cast<unsigned>(s.length()));
+    if (!length)
+        return globalData->smallStrings.emptyString();
+    if (length == 1) {
+        UChar c = s.characterAt(offset);
+        if (c <= maxSingleCharacterString)
+            return globalData->smallStrings.singleCharacterString(globalData, c);
     }
+    return JSString::createHasOtherOwner(*globalData, StringImpl::create(s.impl(), offset, length));
+}
 
-    inline JSRopeString* jsStringBuilder(JSGlobalData* globalData)
-    {
-        return JSRopeString::createNull(*globalData);
+inline JSString* jsOwnedString(JSGlobalData* globalData, const String& s)
+{
+    int size = s.length();
+    if (!size)
+        return globalData->smallStrings.emptyString();
+    if (size == 1) {
+        UChar c = s.characterAt(0);
+        if (c <= maxSingleCharacterString)
+            return globalData->smallStrings.singleCharacterString(globalData, c);
     }
+    return JSString::createHasOtherOwner(*globalData, s.impl());
+}
 
-    inline JSString* jsEmptyString(ExecState* exec) { return jsEmptyString(&exec->globalData()); }
-    inline JSString* jsString(ExecState* exec, const String& s) { return jsString(&exec->globalData(), s); }
-    inline JSString* jsSingleCharacterString(ExecState* exec, UChar c) { return jsSingleCharacterString(&exec->globalData(), c); }
-    inline JSString* jsSubstring8(ExecState* exec, const String& s, unsigned offset, unsigned length) { return jsSubstring8(&exec->globalData(), s, offset, length); }
-    inline JSString* jsSubstring(ExecState* exec, const String& s, unsigned offset, unsigned length) { return jsSubstring(&exec->globalData(), s, offset, length); }
-    inline JSString* jsNontrivialString(ExecState* exec, const String& s) { return jsNontrivialString(&exec->globalData(), s); }
-    inline JSString* jsOwnedString(ExecState* exec, const String& s) { return jsOwnedString(&exec->globalData(), s); }
+inline JSRopeString* jsStringBuilder(JSGlobalData* globalData)
+{
+    return JSRopeString::createNull(*globalData);
+}
 
-    ALWAYS_INLINE bool JSString::getStringPropertySlot(ExecState* exec, PropertyName propertyName, PropertySlot& slot)
-    {
-        if (propertyName == exec->propertyNames().length) {
-            slot.setValue(jsNumber(m_length));
-            return true;
-        }
+inline JSString* jsEmptyString(ExecState* exec) { return jsEmptyString(&exec->globalData()); }
+inline JSString* jsString(ExecState* exec, const String& s) { return jsString(&exec->globalData(), s); }
+inline JSString* jsSingleCharacterString(ExecState* exec, UChar c) { return jsSingleCharacterString(&exec->globalData(), c); }
+inline JSString* jsSubstring8(ExecState* exec, const String& s, unsigned offset, unsigned length) { return jsSubstring8(&exec->globalData(), s, offset, length); }
+inline JSString* jsSubstring(ExecState* exec, const String& s, unsigned offset, unsigned length) { return jsSubstring(&exec->globalData(), s, offset, length); }
+inline JSString* jsNontrivialString(ExecState* exec, const String& s) { return jsNontrivialString(&exec->globalData(), s); }
+inline JSString* jsOwnedString(ExecState* exec, const String& s) { return jsOwnedString(&exec->globalData(), s); }
 
-        unsigned i = propertyName.asIndex();
-        if (i < m_length) {
-            ASSERT(i != PropertyName::NotAnIndex); // No need for an explicit check, the above test would always fail!
-            slot.setValue(getIndex(exec, i));
-            return true;
-        }
+ALWAYS_INLINE bool JSString::getStringPropertySlot(ExecState* exec, PropertyName propertyName, PropertySlot& slot)
+{
+    if (propertyName == exec->propertyNames().length) {
+        slot.setValue(jsNumber(m_length));
+        return true;
+    }
 
-        return false;
+    unsigned i = propertyName.asIndex();
+    if (i < m_length) {
+        ASSERT(i != PropertyName::NotAnIndex); // No need for an explicit check, the above test would always fail!
+        slot.setValue(getIndex(exec, i));
+        return true;
     }
+
+    return false;
+}
         
-    ALWAYS_INLINE bool JSString::getStringPropertySlot(ExecState* exec, unsigned propertyName, PropertySlot& slot)
-    {
-        if (propertyName < m_length) {
-            slot.setValue(getIndex(exec, propertyName));
-            return true;
-        }
-
-        return false;
+ALWAYS_INLINE bool JSString::getStringPropertySlot(ExecState* exec, unsigned propertyName, PropertySlot& slot)
+{
+    if (propertyName < m_length) {
+        slot.setValue(getIndex(exec, propertyName));
+        return true;
     }
 
-    inline bool isJSString(JSValue v) { return v.isCell() && v.asCell()->classInfo() == &JSString::s_info; }
+    return false;
+}
 
-    // --- JSValue inlines ----------------------------
+inline bool isJSString(JSValue v) { return v.isCell() && v.asCell()->classInfo() == &JSString::s_info; }
+
+// --- JSValue inlines ----------------------------
     
-    inline bool JSValue::toBoolean(ExecState* exec) const
-    {
-        if (isInt32())
-            return asInt32();
-        if (isDouble())
-            return asDouble() > 0.0 || asDouble() < 0.0; // false for NaN
-        if (isCell())
-            return asCell()->toBoolean(exec);
-        return isTrue(); // false, null, and undefined all convert to false.
-    }
+inline bool JSValue::toBoolean(ExecState* exec) const
+{
+    if (isInt32())
+        return asInt32();
+    if (isDouble())
+        return asDouble() > 0.0 || asDouble() < 0.0; // false for NaN
+    if (isCell())
+        return asCell()->toBoolean(exec);
+    return isTrue(); // false, null, and undefined all convert to false.
+}
 
-    inline JSString* JSValue::toString(ExecState* exec) const
-    {
-        if (isString())
-            return jsCast<JSString*>(asCell());
-        return toStringSlowCase(exec);
-    }
+inline JSString* JSValue::toString(ExecState* exec) const
+{
+    if (isString())
+        return jsCast<JSString*>(asCell());
+    return toStringSlowCase(exec);
+}
 
-    inline String JSValue::toWTFString(ExecState* exec) const
-    {
-        if (isString())
-            return static_cast<JSString*>(asCell())->value(exec);
-        return toWTFStringSlowCase(exec);
-    }
+inline String JSValue::toWTFString(ExecState* exec) const
+{
+    if (isString())
+        return static_cast<JSString*>(asCell())->value(exec);
+    return toWTFStringSlowCase(exec);
+}
 
-    ALWAYS_INLINE String inlineJSValueNotStringtoString(const JSValue& value, ExecState* exec)
-    {
-        JSGlobalData& globalData = exec->globalData();
-        if (value.isInt32())
-            return globalData.numericStrings.add(value.asInt32());
-        if (value.isDouble())
-            return globalData.numericStrings.add(value.asDouble());
-        if (value.isTrue())
-            return globalData.propertyNames->trueKeyword.string();
-        if (value.isFalse())
-            return globalData.propertyNames->falseKeyword.string();
-        if (value.isNull())
-            return globalData.propertyNames->nullKeyword.string();
-        if (value.isUndefined())
-            return globalData.propertyNames->undefinedKeyword.string();
-        return value.toString(exec)->value(exec);
-    }
+ALWAYS_INLINE String inlineJSValueNotStringtoString(const JSValue& value, ExecState* exec)
+{
+    JSGlobalData& globalData = exec->globalData();
+    if (value.isInt32())
+        return globalData.numericStrings.add(value.asInt32());
+    if (value.isDouble())
+        return globalData.numericStrings.add(value.asDouble());
+    if (value.isTrue())
+        return globalData.propertyNames->trueKeyword.string();
+    if (value.isFalse())
+        return globalData.propertyNames->falseKeyword.string();
+    if (value.isNull())
+        return globalData.propertyNames->nullKeyword.string();
+    if (value.isUndefined())
+        return globalData.propertyNames->undefinedKeyword.string();
+    return value.toString(exec)->value(exec);
+}
 
-    ALWAYS_INLINE String JSValue::toWTFStringInline(ExecState* exec) const
-    {
-        if (isString())
-            return static_cast<JSString*>(asCell())->value(exec);
+ALWAYS_INLINE String JSValue::toWTFStringInline(ExecState* exec) const
+{
+    if (isString())
+        return static_cast<JSString*>(asCell())->value(exec);
 
-        return inlineJSValueNotStringtoString(*this, exec);
-    }
+    return inlineJSValueNotStringtoString(*this, exec);
+}
 
 } // namespace JSC
 
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to