Title: [147600] trunk/Source/WebCore
- Revision
- 147600
- Author
- [email protected]
- Date
- 2013-04-03 18:02:57 -0700 (Wed, 03 Apr 2013)
Log Message
Add comment to clarify isStackingContext() in RenderLayer.h
https://bugs.webkit.org/show_bug.cgi?id=113909
Reviewed by Simon Fraser.
It was not obvious how the implementation of isStackingContext()
was correct, a comment is appropriate here for anyone who reads
this code in the future.
Just a change in comment, no test needed.
* rendering/RenderLayer.h:
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (147599 => 147600)
--- trunk/Source/WebCore/ChangeLog 2013-04-04 00:58:14 UTC (rev 147599)
+++ trunk/Source/WebCore/ChangeLog 2013-04-04 01:02:57 UTC (rev 147600)
@@ -1,3 +1,18 @@
+2013-04-03 Shawn Singh <[email protected]>
+
+ Add comment to clarify isStackingContext() in RenderLayer.h
+ https://bugs.webkit.org/show_bug.cgi?id=113909
+
+ Reviewed by Simon Fraser.
+
+ It was not obvious how the implementation of isStackingContext()
+ was correct, a comment is appropriate here for anyone who reads
+ this code in the future.
+
+ Just a change in comment, no test needed.
+
+ * rendering/RenderLayer.h:
+
2013-04-03 Hans Muller <[email protected]>
[CSS Exclusions] Removed ExclusionShape dead code
Modified: trunk/Source/WebCore/rendering/RenderLayer.h (147599 => 147600)
--- trunk/Source/WebCore/rendering/RenderLayer.h 2013-04-04 00:58:14 UTC (rev 147599)
+++ trunk/Source/WebCore/rendering/RenderLayer.h 2013-04-04 01:02:57 UTC (rev 147600)
@@ -864,6 +864,8 @@
void updateNormalFlowList();
+ // Non-auto z-index always implies stacking context here, because StyleResolver::adjustRenderStyle already adjusts z-index
+ // based on positioning and other criteria.
bool isStackingContext(const RenderStyle* style) const { return !style->hasAutoZIndex() || isRootLayer(); }
bool isDirtyStackingContainer() const { return m_zOrderListsDirty && isStackingContainer(); }
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
