Title: [147602] trunk
- Revision
- 147602
- Author
- [email protected]
- Date
- 2013-04-03 18:16:55 -0700 (Wed, 03 Apr 2013)
Log Message
Input value/placeholder is not redrawn when the input height grows
https://bugs.webkit.org/show_bug.cgi?id=113845
Reviewed by Ojan Vafai.
Source/WebCore:
Test: fast/forms/text/text-height-grow.html
* rendering/RenderTextControlSingleLine.cpp:
(WebCore::RenderTextControlSingleLine::styleDidChange):
We need relayout of the inner text element.
LayoutTests:
* fast/forms/text/text-height-grow-expected.html: Added.
* fast/forms/text/text-height-grow.html: Added.
Modified Paths
Added Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (147601 => 147602)
--- trunk/LayoutTests/ChangeLog 2013-04-04 01:10:05 UTC (rev 147601)
+++ trunk/LayoutTests/ChangeLog 2013-04-04 01:16:55 UTC (rev 147602)
@@ -1,3 +1,13 @@
+2013-04-03 Kent Tamura <[email protected]>
+
+ Input value/placeholder is not redrawn when the input height grows
+ https://bugs.webkit.org/show_bug.cgi?id=113845
+
+ Reviewed by Ojan Vafai.
+
+ * fast/forms/text/text-height-grow-expected.html: Added.
+ * fast/forms/text/text-height-grow.html: Added.
+
2013-04-03 Glenn Adams <[email protected]>
[GTK] Unreviewed gardening. Rebaseline after r147588.
Added: trunk/LayoutTests/fast/forms/text/text-height-grow-expected.html (0 => 147602)
--- trunk/LayoutTests/fast/forms/text/text-height-grow-expected.html (rev 0)
+++ trunk/LayoutTests/fast/forms/text/text-height-grow-expected.html 2013-04-04 01:16:55 UTC (rev 147602)
@@ -0,0 +1,5 @@
+<!DOCTYPE html>
+<body>
+<input value=foo>
+<input placeholder=foo>
+</body>
Added: trunk/LayoutTests/fast/forms/text/text-height-grow.html (0 => 147602)
--- trunk/LayoutTests/fast/forms/text/text-height-grow.html (rev 0)
+++ trunk/LayoutTests/fast/forms/text/text-height-grow.html 2013-04-04 01:16:55 UTC (rev 147602)
@@ -0,0 +1,10 @@
+<!DOCTYPE html>
+<body>
+<input value=foo style="height:0.5em;">
+<input placeholder=foo style="height:0.5em;">
+<script>
+document.body.offsetHeight;
+document.getElementsByTagName('input')[0].style.height = 'initial';
+document.getElementsByTagName('input')[1].style.height = 'initial';
+</script>
+</body>
Modified: trunk/Source/WebCore/ChangeLog (147601 => 147602)
--- trunk/Source/WebCore/ChangeLog 2013-04-04 01:10:05 UTC (rev 147601)
+++ trunk/Source/WebCore/ChangeLog 2013-04-04 01:16:55 UTC (rev 147602)
@@ -1,3 +1,16 @@
+2013-04-03 Kent Tamura <[email protected]>
+
+ Input value/placeholder is not redrawn when the input height grows
+ https://bugs.webkit.org/show_bug.cgi?id=113845
+
+ Reviewed by Ojan Vafai.
+
+ Test: fast/forms/text/text-height-grow.html
+
+ * rendering/RenderTextControlSingleLine.cpp:
+ (WebCore::RenderTextControlSingleLine::styleDidChange):
+ We need relayout of the inner text element.
+
2013-04-03 Shawn Singh <[email protected]>
Add comment to clarify isStackingContext() in RenderLayer.h
Modified: trunk/Source/WebCore/rendering/RenderTextControlSingleLine.cpp (147601 => 147602)
--- trunk/Source/WebCore/rendering/RenderTextControlSingleLine.cpp 2013-04-04 01:10:05 UTC (rev 147601)
+++ trunk/Source/WebCore/rendering/RenderTextControlSingleLine.cpp 2013-04-04 01:16:55 UTC (rev 147602)
@@ -252,6 +252,9 @@
containerRenderer->style()->setHeight(Length());
containerRenderer->style()->setWidth(Length());
}
+ RenderObject* innerTextRenderer = innerTextElement()->renderer();
+ if (innerTextRenderer && diff == StyleDifferenceLayout)
+ innerTextRenderer->setNeedsLayout(true, MarkOnlyThis);
if (HTMLElement* placeholder = inputElement()->placeholderElement())
placeholder->setInlineStyleProperty(CSSPropertyTextOverflow, textShouldBeTruncated() ? CSSValueEllipsis : CSSValueClip);
setHasOverflowClip(false);
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
