Title: [148098] trunk/Source/WebCore
Revision
148098
Author
[email protected]
Date
2013-04-10 09:16:13 -0700 (Wed, 10 Apr 2013)

Log Message

Replace ENABLE_MICRODATA preprocessor statements in IDL files with Conditional attribute
https://bugs.webkit.org/show_bug.cgi?id=114349

Reviewed by Geoffrey Garen.

The Conditional attribute does not need a preprocessor, which is source of much pain on native windows.

* dom/Document.idl:
* html/HTMLElement.idl:

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (148097 => 148098)


--- trunk/Source/WebCore/ChangeLog	2013-04-10 16:13:35 UTC (rev 148097)
+++ trunk/Source/WebCore/ChangeLog	2013-04-10 16:16:13 UTC (rev 148098)
@@ -1,3 +1,15 @@
+2013-04-10  Patrick Gansterer  <[email protected]>
+
+        Replace ENABLE_MICRODATA preprocessor statements in IDL files with Conditional attribute
+        https://bugs.webkit.org/show_bug.cgi?id=114349
+
+        Reviewed by Geoffrey Garen.
+
+        The Conditional attribute does not need a preprocessor, which is source of much pain on native windows.
+
+        * dom/Document.idl:
+        * html/HTMLElement.idl:
+
 2013-04-10  Raphael Kubo da Costa  <[email protected]>
 
         REGRESSION(r148034): IconDatabase::updateIconRecord crashes with null iconData and iconBitmap.

Modified: trunk/Source/WebCore/dom/Document.idl (148097 => 148098)


--- trunk/Source/WebCore/dom/Document.idl	2013-04-10 16:13:35 UTC (rev 148097)
+++ trunk/Source/WebCore/dom/Document.idl	2013-04-10 16:16:13 UTC (rev 148098)
@@ -180,9 +180,7 @@
 
     NodeList getElementsByName(in [Optional=DefaultIsUndefined] DOMString elementName);
 
-#if defined(ENABLE_MICRODATA) && ENABLE_MICRODATA
-    NodeList getItems(in [TreatNullAs=NullString, TreatUndefinedAs=NullString, Optional=DefaultIsUndefined] DOMString typeNames);
-#endif
+    [Conditional=MICRODATA] NodeList getItems(in [TreatNullAs=NullString, TreatUndefinedAs=NullString, Optional=DefaultIsUndefined] DOMString typeNames);
 
 #if defined(LANGUAGE_JAVASCRIPT) && LANGUAGE_JAVASCRIPT
              [Custom] attribute Location location;

Modified: trunk/Source/WebCore/html/HTMLElement.idl (148097 => 148098)


--- trunk/Source/WebCore/html/HTMLElement.idl	2013-04-10 16:13:35 UTC (rev 148097)
+++ trunk/Source/WebCore/html/HTMLElement.idl	2013-04-10 16:16:13 UTC (rev 148098)
@@ -72,10 +72,8 @@
     [Conditional=MICRODATA] readonly attribute DOMSettableTokenList itemRef;
     [Conditional=MICRODATA] readonly attribute DOMSettableTokenList itemProp;
 
-#if defined(ENABLE_MICRODATA) && ENABLE_MICRODATA
     [Conditional=MICRODATA] readonly attribute HTMLPropertiesCollection properties;
 #endif
-#endif
 
 #if !defined(LANGUAGE_CPP) || !LANGUAGE_CPP
 #if !defined(LANGUAGE_OBJECTIVE_C) || !LANGUAGE_OBJECTIVE_C
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to