Title: [148100] trunk/Source/WebCore
Revision
148100
Author
[email protected]
Date
2013-04-10 09:27:10 -0700 (Wed, 10 Apr 2013)

Log Message

Replace ENABLE_CHANNEL_MESSAGING preprocessor statements in IDL files with Conditional attribute
https://bugs.webkit.org/show_bug.cgi?id=114346

Reviewed by Geoffrey Garen.

The Conditional attribute does not need a preprocessor, which is source of much pain on native windows.

* page/DOMWindow.idl:
* workers/WorkerContext.idl:

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (148099 => 148100)


--- trunk/Source/WebCore/ChangeLog	2013-04-10 16:25:14 UTC (rev 148099)
+++ trunk/Source/WebCore/ChangeLog	2013-04-10 16:27:10 UTC (rev 148100)
@@ -1,3 +1,15 @@
+2013-04-10  Patrick Gansterer  <[email protected]>
+
+        Replace ENABLE_CHANNEL_MESSAGING preprocessor statements in IDL files with Conditional attribute
+        https://bugs.webkit.org/show_bug.cgi?id=114346
+
+        Reviewed by Geoffrey Garen.
+
+        The Conditional attribute does not need a preprocessor, which is source of much pain on native windows.
+
+        * page/DOMWindow.idl:
+        * workers/WorkerContext.idl:
+
 2013-04-10  Eric Carlson  <[email protected]>
 
         Update all float attributes in HTMLMediaElement to double

Modified: trunk/Source/WebCore/page/DOMWindow.idl (148099 => 148100)


--- trunk/Source/WebCore/page/DOMWindow.idl	2013-04-10 16:25:14 UTC (rev 148099)
+++ trunk/Source/WebCore/page/DOMWindow.idl	2013-04-10 16:27:10 UTC (rev 148100)
@@ -604,10 +604,8 @@
     attribute XMLHttpRequestExceptionConstructor XMLHttpRequestException;
     [Conditional=XSLT] attribute XSLTProcessorConstructor XSLTProcessor; // Usable with the new operator
 
-#if defined(ENABLE_CHANNEL_MESSAGING) && ENABLE_CHANNEL_MESSAGING
-    attribute MessagePortConstructor MessagePort;
-    attribute MessageChannelConstructor MessageChannel; // Usable with the new operator
-#endif
+    [Conditional=CHANNEL_MESSAGING] attribute MessagePortConstructor MessagePort;
+    [Conditional=CHANNEL_MESSAGING] attribute MessageChannelConstructor MessageChannel; // Usable with the new operator
 
     attribute DOMPluginConstructor Plugin;
     attribute DOMPluginArrayConstructor PluginArray;

Modified: trunk/Source/WebCore/workers/WorkerContext.idl (148099 => 148100)


--- trunk/Source/WebCore/workers/WorkerContext.idl	2013-04-10 16:25:14 UTC (rev 148099)
+++ trunk/Source/WebCore/workers/WorkerContext.idl	2013-04-10 16:27:10 UTC (rev 148100)
@@ -72,9 +72,7 @@
     attribute MessageEventConstructor MessageEvent;
     attribute WorkerLocationConstructor WorkerLocation;
 
-#if defined(ENABLE_CHANNEL_MESSAGING) && ENABLE_CHANNEL_MESSAGING
-    [JSCustomGetter] attribute MessageChannelConstructor MessageChannel;
-#endif
+    [Conditional=CHANNEL_MESSAGING, JSCustomGetter] attribute MessageChannelConstructor MessageChannel;
     [JSCustomGetter] attribute EventSourceConstructor EventSource;
     [JSCustomGetter] attribute XMLHttpRequestConstructor XMLHttpRequest;
 #endif
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to