Title: [148724] trunk/Tools
- Revision
- 148724
- Author
- [email protected]
- Date
- 2013-04-19 01:25:44 -0700 (Fri, 19 Apr 2013)
Log Message
[Dashboard] Remove Chromium-specific cases from the construction of the chart HTML for aggregate results
https://bugs.webkit.org/show_bug.cgi?id=114759
Reviewed by Benjamin Poulain.
Aggregate results are not viewable for Chromium builders anymore, meaning the WebKit revisions are shown by default.
This means the code in the chartHTML method can be simplified, defaulting the revision key to WEBKIT_REVISIONS_KEY
and the revision label to 'WebKit Revision'.
* TestResultServer/static-dashboards/aggregate_results.js:
(chartHTML):
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (148723 => 148724)
--- trunk/Tools/ChangeLog 2013-04-19 05:59:02 UTC (rev 148723)
+++ trunk/Tools/ChangeLog 2013-04-19 08:25:44 UTC (rev 148724)
@@ -1,3 +1,17 @@
+2013-04-19 Zan Dobersek <[email protected]>
+
+ [Dashboard] Remove Chromium-specific cases from the construction of the chart HTML for aggregate results
+ https://bugs.webkit.org/show_bug.cgi?id=114759
+
+ Reviewed by Benjamin Poulain.
+
+ Aggregate results are not viewable for Chromium builders anymore, meaning the WebKit revisions are shown by default.
+ This means the code in the chartHTML method can be simplified, defaulting the revision key to WEBKIT_REVISIONS_KEY
+ and the revision label to 'WebKit Revision'.
+
+ * TestResultServer/static-dashboards/aggregate_results.js:
+ (chartHTML):
+
2013-04-18 Xuefei Ren <[email protected]>
remove build warning(unused parameter)
Modified: trunk/Tools/TestResultServer/static-dashboards/aggregate_results.js (148723 => 148724)
--- trunk/Tools/TestResultServer/static-dashboards/aggregate_results.js 2013-04-19 05:59:02 UTC (rev 148723)
+++ trunk/Tools/TestResultServer/static-dashboards/aggregate_results.js 2013-04-19 08:25:44 UTC (rev 148724)
@@ -104,11 +104,10 @@
function chartHTML(results, numColumns)
{
- var shouldShowWebKitRevisions = isTipOfTreeWebKitBuilder();
- var revisionKey = shouldShowWebKitRevisions ? WEBKIT_REVISIONS_KEY : CHROME_REVISIONS_KEY;
+ var revisionKey = WEBKIT_REVISIONS_KEY;
+ var revisionLabel = "WebKit Revision";
var startRevision = results[revisionKey][numColumns - 1];
var endRevision = results[revisionKey][0];
- var revisionLabel = shouldShowWebKitRevisions ? "WebKit Revision" : "Chromium Revision";
var fixable = results[FIXABLE_COUNT_KEY].slice(0, numColumns);
var html = chart("Total failing", {"": fixable}, revisionLabel, startRevision, endRevision);
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
