Modified: trunk/Tools/ChangeLog (148724 => 148725)
--- trunk/Tools/ChangeLog 2013-04-19 08:25:44 UTC (rev 148724)
+++ trunk/Tools/ChangeLog 2013-04-19 08:28:10 UTC (rev 148725)
@@ -1,5 +1,21 @@
2013-04-19 Zan Dobersek <[email protected]>
+ [Dashboard] The revision rows for aggregate results should no longer include Chromium revisions
+ https://bugs.webkit.org/show_bug.cgi?id=114760
+
+ Reviewed by Benjamin Poulain.
+
+ With the Chromium builders no longer present there's no need to display the Chromium revision range under the
+ aggregate results. Only the first half of the htmlForRevisionRows method (the one returning the table row listing the
+ WebKit revisions) is now relevant - the method is therefor removed and its callsites updated to directly call the
+ htmlForTableRow method that returns the table row containing all the relevant WebKit revisions.
+
+ * TestResultServer/static-dashboards/aggregate_results.js:
+ (htmlForSummaryTable):
+ (htmlForTestType):
+
+2013-04-19 Zan Dobersek <[email protected]>
+
[Dashboard] Remove Chromium-specific cases from the construction of the chart HTML for aggregate results
https://bugs.webkit.org/show_bug.cgi?id=114759
Modified: trunk/Tools/TestResultServer/static-dashboards/aggregate_results.js (148724 => 148725)
--- trunk/Tools/TestResultServer/static-dashboards/aggregate_results.js 2013-04-19 08:25:44 UTC (rev 148724)
+++ trunk/Tools/TestResultServer/static-dashboards/aggregate_results.js 2013-04-19 08:28:10 UTC (rev 148725)
@@ -184,12 +184,6 @@
return '<img src="" + url + '">';
}
-function htmlForRevisionRows(results, numColumns)
-{
- return htmlForTableRow('WebKit Revision', results[WEBKIT_REVISIONS_KEY].slice(0, numColumns)) +
- htmlForTableRow('Chrome Revision', results[CHROME_REVISIONS_KEY].slice(0, numColumns));
-}
-
function wrapHTMLInTable(description, html)
{
return '<h3>' + description + '</h3><table><tbody>' + html + '</tbody></table>';
@@ -205,7 +199,7 @@
// Round to the nearest tenth of a percent.
percent.push(Math.round(percentage * 10) / 10 + '%');
}
- var html = htmlForRevisionRows(results, numColumns) +
+ var html = htmlForTableRow('WebKit Revision', results[WEBKIT_REVISIONS_KEY].slice(0, numColumns)) +
htmlForTableRow('Percent passed', percent) +
htmlForTableRow('Failures (deduped)', fixable) +
htmlForTableRow('Fixable Tests', allFixable);
@@ -231,7 +225,7 @@
function htmlForTestType(results, key, description, numColumns)
{
var counts = results[key];
- var html = htmlForRevisionRows(results, numColumns);
+ var html = htmlForTableRow('WebKit Revision', results[WEBKIT_REVISIONS_KEY].slice(0, numColumns));
var values = valuesPerExpectation(counts, numColumns);
for (var expectation in values)
html += htmlForTableRow(expectationsMap()[expectation], values[expectation]);
