Log Message
[Dashboard] Remove Chromium-specific helper functions that were used in the builder-loading code https://bugs.webkit.org/show_bug.cgi?id=114803
Reviewed by Benjamin Poulain. Remove three Chromium-specific helper functions that were used to determine Chromium DEPS, Content Shell and WebKit ToT test runners. These are not required anymore and thus removed along with a couple of unit tests that were testing these methods' correct behavior. * TestResultServer/static-dashboards/builders.js: * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (148732 => 148733)
--- trunk/Tools/ChangeLog 2013-04-19 08:41:17 UTC (rev 148732)
+++ trunk/Tools/ChangeLog 2013-04-19 08:42:25 UTC (rev 148733)
@@ -1,5 +1,19 @@
2013-04-19 Zan Dobersek <[email protected]>
+ [Dashboard] Remove Chromium-specific helper functions that were used in the builder-loading code
+ https://bugs.webkit.org/show_bug.cgi?id=114803
+
+ Reviewed by Benjamin Poulain.
+
+ Remove three Chromium-specific helper functions that were used to determine Chromium DEPS, Content Shell and WebKit ToT
+ test runners. These are not required anymore and thus removed along with a couple of unit tests that were testing these
+ methods' correct behavior.
+
+ * TestResultServer/static-dashboards/builders.js:
+ * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
+
+2013-04-19 Zan Dobersek <[email protected]>
+
[Dashboard] Remove the Chromium-specific builder masters
https://bugs.webkit.org/show_bug.cgi?id=114802
Modified: trunk/Tools/TestResultServer/static-dashboards/builders.js (148732 => 148733)
--- trunk/Tools/TestResultServer/static-dashboards/builders.js 2013-04-19 08:41:17 UTC (rev 148732)
+++ trunk/Tools/TestResultServer/static-dashboards/builders.js 2013-04-19 08:42:25 UTC (rev 148733)
@@ -140,22 +140,6 @@
builderGroups[groupName].append(builderList);
}
-function isChromiumContentShellTestRunner(builder)
-{
- return builder.indexOf('(Content Shell)') != -1;
-}
-
-function isChromiumWebkitTipOfTreeTestRunner(builder)
-{
- // FIXME: Remove the Android check once the android tests bot is actually uploading results.
- return builder.indexOf('ASAN') == -1 && !isChromiumContentShellTestRunner(builder) && builder.indexOf('Android') == -1 && !isChromiumWebkitDepsTestRunner(builder);
-}
-
-function isChromiumWebkitDepsTestRunner(builder)
-{
- return builder.indexOf('(deps)') != -1;
-}
-
// FIXME: Look into whether we can move the grouping logic into builders.jsonp and get rid of this code.
function loadBuildersList(groupName, testType) {
switch (testType) {
Modified: trunk/Tools/TestResultServer/static-dashboards/flakiness_dashboard_unittests.js (148732 => 148733)
--- trunk/Tools/TestResultServer/static-dashboards/flakiness_dashboard_unittests.js 2013-04-19 08:41:17 UTC (rev 148732)
+++ trunk/Tools/TestResultServer/static-dashboards/flakiness_dashboard_unittests.js 2013-04-19 08:42:25 UTC (rev 148733)
@@ -501,24 +501,6 @@
// FIXME: Create builders_tests.js and move this there.
-test('isChromiumWebkitTipOfTreeTestRunner', 1, function() {
- var builderList = ["WebKit Linux", "WebKit Linux (dbg)", "WebKit Linux 32", "WebKit Mac10.6", "WebKit Mac10.6 (dbg)",
- "WebKit Mac10.6 (deps)", "WebKit Mac10.7", "WebKit Win", "WebKit Win (dbg)(1)", "WebKit Win (dbg)(2)", "WebKit Win (deps)",
- "WebKit Win7", "Linux (Content Shell)"];
- var expectedBuilders = ["WebKit Linux", "WebKit Linux (dbg)", "WebKit Linux 32", "WebKit Mac10.6",
- "WebKit Mac10.6 (dbg)", "WebKit Mac10.7", "WebKit Win", "WebKit Win (dbg)(1)", "WebKit Win (dbg)(2)", "WebKit Win7"];
- deepEqual(builderList.filter(isChromiumWebkitTipOfTreeTestRunner), expectedBuilders);
-});
-
-test('isChromiumWebkitDepsTestRunner', 1, function() {
- var builderList = ["Chrome Frame Tests", "GPU Linux (NVIDIA)", "GPU Linux (dbg) (NVIDIA)", "GPU Mac", "GPU Mac (dbg)", "GPU Win7 (NVIDIA)", "GPU Win7 (dbg) (NVIDIA)", "Linux Perf", "Linux Tests",
- "Linux Valgrind", "Mac Builder (dbg)", "Mac10.6 Perf", "Mac10.6 Tests", "Vista Perf", "Vista Tests", "WebKit Linux", "WebKit Linux ASAN", "WebKit Linux (dbg)", "WebKit Linux (deps)", "WebKit Linux 32",
- "WebKit Mac10.6", "WebKit Mac10.6 (dbg)", "WebKit Mac10.6 (deps)", "WebKit Mac10.7", "WebKit Win", "WebKit Win (dbg)(1)", "WebKit Win (dbg)(2)", "WebKit Win (deps)",
- "WebKit Win7", "Win (dbg)", "Win Builder"];
- var expectedBuilders = ["WebKit Linux (deps)", "WebKit Mac10.6 (deps)", "WebKit Win (deps)"];
- deepEqual(builderList.filter(isChromiumWebkitDepsTestRunner), expectedBuilders);
-});
-
test('requestBuilderListAddsBuilderGroupEntry', 1, function() {
var testBuilderGroups = { '@ToT - dummy.org': null };
var builderGroup = new BuilderGroup(BuilderGroup.TOT_WEBKIT);
_______________________________________________ webkit-changes mailing list [email protected] https://lists.webkit.org/mailman/listinfo/webkit-changes
