Title: [148734] trunk/Tools
- Revision
- 148734
- Author
- [email protected]
- Date
- 2013-04-19 01:43:53 -0700 (Fri, 19 Apr 2013)
Log Message
[Dashboard] htmlForIndividualTests unit test should include its dummy builder under the webkit.org builder master
https://bugs.webkit.org/show_bug.cgi?id=114804
Reviewed by Benjamin Poulain.
The htmlForIndividualTests unit test should include its dummy builder under the sole supported webkit.org builder master
just so the unit tests properly functions.
* TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (148733 => 148734)
--- trunk/Tools/ChangeLog 2013-04-19 08:42:25 UTC (rev 148733)
+++ trunk/Tools/ChangeLog 2013-04-19 08:43:53 UTC (rev 148734)
@@ -1,5 +1,17 @@
2013-04-19 Zan Dobersek <[email protected]>
+ [Dashboard] htmlForIndividualTests unit test should include its dummy builder under the webkit.org builder master
+ https://bugs.webkit.org/show_bug.cgi?id=114804
+
+ Reviewed by Benjamin Poulain.
+
+ The htmlForIndividualTests unit test should include its dummy builder under the sole supported webkit.org builder master
+ just so the unit tests properly functions.
+
+ * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
+
+2013-04-19 Zan Dobersek <[email protected]>
+
[Dashboard] Remove Chromium-specific helper functions that were used in the builder-loading code
https://bugs.webkit.org/show_bug.cgi?id=114803
Modified: trunk/Tools/TestResultServer/static-dashboards/flakiness_dashboard_unittests.js (148733 => 148734)
--- trunk/Tools/TestResultServer/static-dashboards/flakiness_dashboard_unittests.js 2013-04-19 08:42:25 UTC (rev 148733)
+++ trunk/Tools/TestResultServer/static-dashboards/flakiness_dashboard_unittests.js 2013-04-19 08:43:53 UTC (rev 148734)
@@ -472,7 +472,7 @@
test('htmlForSingleTestRow', 1, function() {
var historyInstance = resetGlobals();
var builder = 'dummyBuilder';
- BUILDER_TO_MASTER[builder] = CHROMIUM_WEBKIT_BUILDER_MASTER;
+ BUILDER_TO_MASTER[builder] = WEBKIT_BUILDER_MASTER;
var test = createResultsObjectForTest('foo/exists.html', builder);
historyInstance.dashboardSpecificState.showCorrectExpectations = true;
g_resultsByBuilder[builder] = {buildNumbers: [2, 1], webkitRevision: [1234, 1233]};
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
