Title: [148735] trunk/Tools
- Revision
- 148735
- Author
- [email protected]
- Date
- 2013-04-19 01:47:51 -0700 (Fri, 19 Apr 2013)
Log Message
[Dashboard] Remove the isToTWebKit member variable from the BuilderGroup interface
https://bugs.webkit.org/show_bug.cgi?id=114805
Reviewed by Benjamin Poulain.
Remove the isToTWebKit member variable from the BuilderGroup and all its usages as it now defaults to true for every
builder group. The isTipOfTreeWebKitBuilder method now returns true by default but should be removed in a follow-up patch.
The BuilderGroup constructor does not accept the isToTWebKit parameter anymore so all the callsites are adjusted accordingly.
* TestResultServer/static-dashboards/builders.js:
(BuilderGroup):
(loadBuildersList):
* TestResultServer/static-dashboards/dashboard_base.js:
(isTipOfTreeWebKitBuilder):
(expectationsMap):
* TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
(test):
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (148734 => 148735)
--- trunk/Tools/ChangeLog 2013-04-19 08:43:53 UTC (rev 148734)
+++ trunk/Tools/ChangeLog 2013-04-19 08:47:51 UTC (rev 148735)
@@ -1,5 +1,25 @@
2013-04-19 Zan Dobersek <[email protected]>
+ [Dashboard] Remove the isToTWebKit member variable from the BuilderGroup interface
+ https://bugs.webkit.org/show_bug.cgi?id=114805
+
+ Reviewed by Benjamin Poulain.
+
+ Remove the isToTWebKit member variable from the BuilderGroup and all its usages as it now defaults to true for every
+ builder group. The isTipOfTreeWebKitBuilder method now returns true by default but should be removed in a follow-up patch.
+ The BuilderGroup constructor does not accept the isToTWebKit parameter anymore so all the callsites are adjusted accordingly.
+
+ * TestResultServer/static-dashboards/builders.js:
+ (BuilderGroup):
+ (loadBuildersList):
+ * TestResultServer/static-dashboards/dashboard_base.js:
+ (isTipOfTreeWebKitBuilder):
+ (expectationsMap):
+ * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
+ (test):
+
+2013-04-19 Zan Dobersek <[email protected]>
+
[Dashboard] htmlForIndividualTests unit test should include its dummy builder under the webkit.org builder master
https://bugs.webkit.org/show_bug.cgi?id=114804
Modified: trunk/Tools/TestResultServer/static-dashboards/builders.js (148734 => 148735)
--- trunk/Tools/TestResultServer/static-dashboards/builders.js 2013-04-19 08:43:53 UTC (rev 148734)
+++ trunk/Tools/TestResultServer/static-dashboards/builders.js 2013-04-19 08:47:51 UTC (rev 148735)
@@ -90,9 +90,8 @@
'webkit.org': '@ToT - webkit.org'
};
-function BuilderGroup(isToTWebKit)
+function BuilderGroup()
{
- this.isToTWebKit = isToTWebKit;
// Map of builderName (the name shown in the waterfall) to builderPath (the
// path used in the builder's URL)
this.builders = {};
@@ -116,9 +115,6 @@
return builderMaster(this.defaultBuilder());
}
-BuilderGroup.TOT_WEBKIT = true;
-BuilderGroup.DEPS_WEBKIT = false;
-
var BUILDER_TO_MASTER = {};
function builderMaster(builderName)
@@ -146,7 +142,7 @@
case 'layout-tests':
switch(groupName) {
case '@ToT - webkit.org':
- var builderGroup = new BuilderGroup(BuilderGroup.TOT_WEBKIT);
+ var builderGroup = new BuilderGroup();
requestBuilderList(LAYOUT_TESTS_BUILDER_GROUPS, WEBKIT_BUILDER_MASTER, groupName, builderGroup, testType);
break;
default:
Modified: trunk/Tools/TestResultServer/static-dashboards/dashboard_base.js (148734 => 148735)
--- trunk/Tools/TestResultServer/static-dashboards/dashboard_base.js 2013-04-19 08:43:53 UTC (rev 148734)
+++ trunk/Tools/TestResultServer/static-dashboards/dashboard_base.js 2013-04-19 08:47:51 UTC (rev 148735)
@@ -120,7 +120,7 @@
function isTipOfTreeWebKitBuilder()
{
- return currentBuilderGroup().isToTWebKit;
+ return true;
}
var g_resultsByBuilder = {};
Modified: trunk/Tools/TestResultServer/static-dashboards/flakiness_dashboard_unittests.js (148734 => 148735)
--- trunk/Tools/TestResultServer/static-dashboards/flakiness_dashboard_unittests.js 2013-04-19 08:43:53 UTC (rev 148734)
+++ trunk/Tools/TestResultServer/static-dashboards/flakiness_dashboard_unittests.js 2013-04-19 08:47:51 UTC (rev 148735)
@@ -503,7 +503,7 @@
test('requestBuilderListAddsBuilderGroupEntry', 1, function() {
var testBuilderGroups = { '@ToT - dummy.org': null };
- var builderGroup = new BuilderGroup(BuilderGroup.TOT_WEBKIT);
+ var builderGroup = new BuilderGroup();
var groupName = '@ToT - dummy.org';
requestBuilderList(testBuilderGroups, 'webkit.org', groupName, builderGroup, 'layout-tests');
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
