Title: [149570] trunk/Source/WebCore
Revision
149570
Author
[email protected]
Date
2013-05-04 18:34:59 -0700 (Sat, 04 May 2013)

Log Message

Get rid of AddIncludesForSVGAnimatedType in bindings generator
https://bugs.webkit.org/show_bug.cgi?id=115603

Reviewed by Benjamin Poulain.

Remove AddIncludesForSVGAnimatedType subroutine from the bindings generator
as it is a special case which is no longer needed.

No new tests, no behavior change.

* bindings/scripts/CodeGeneratorJS.pm:
(GenerateImplementation):

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (149569 => 149570)


--- trunk/Source/WebCore/ChangeLog	2013-05-04 21:44:41 UTC (rev 149569)
+++ trunk/Source/WebCore/ChangeLog	2013-05-05 01:34:59 UTC (rev 149570)
@@ -1,3 +1,18 @@
+2013-05-04  Christophe Dumez  <[email protected]>
+
+        Get rid of AddIncludesForSVGAnimatedType in bindings generator
+        https://bugs.webkit.org/show_bug.cgi?id=115603
+
+        Reviewed by Benjamin Poulain.
+
+        Remove AddIncludesForSVGAnimatedType subroutine from the bindings generator
+        as it is a special case which is no longer needed.
+
+        No new tests, no behavior change.
+
+        * bindings/scripts/CodeGeneratorJS.pm:
+        (GenerateImplementation):
+
 2013-05-04  Antoine Quint  <[email protected]>
 
         Update code generators to handle a new _javascript_ file for snapshotted plug-ins

Modified: trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm (149569 => 149570)


--- trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm	2013-05-04 21:44:41 UTC (rev 149569)
+++ trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm	2013-05-05 01:34:59 UTC (rev 149570)
@@ -252,19 +252,6 @@
     }
 }
 
-# FIXME: This method will go away once all SVG animated properties are converted to the new scheme.
-sub AddIncludesForSVGAnimatedType
-{
-    my $type = shift;
-    $type =~ s/SVGAnimated//;
-
-    if ($type eq "Point" or $type eq "Rect") {
-        $implIncludes{"Float$type.h"} = 1;
-    } elsif ($type eq "String") {
-        $implIncludes{"<wtf/text/WTFString.h>"} = 1;
-    }
-}
-
 sub AddToImplIncludes
 {
     my $header = shift;
@@ -1556,8 +1543,6 @@
     # - Add default header template
     push(@implContentHeader, GenerateImplementationContentHeader($interface));
 
-    AddIncludesForSVGAnimatedType($interfaceName) if $className =~ /^JSSVGAnimated/;
-
     $implIncludes{"<wtf/GetPtr.h>"} = 1;
     $implIncludes{"<runtime/PropertyNameArray.h>"} = 1 if $interface->extendedAttributes->{"IndexedGetter"} || $interface->extendedAttributes->{"NumericIndexedGetter"};
 
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to