Title: [149571] trunk/Source/WebKit/blackberry
- Revision
- 149571
- Author
- [email protected]
- Date
- 2013-05-04 18:47:47 -0700 (Sat, 04 May 2013)
Log Message
[BlackBerry] Clean up unused spellcheck code
https://bugs.webkit.org/show_bug.cgi?id=115560
Patch by Nima Ghanavatian <[email protected]> on 2013-05-04
Reviewed by Benjamin Poulain.
Internally reviewed by Mike Lattanzio
* Api/WebPage.cpp:
(BlackBerry::WebKit::WebPage::setExtraPluginDirectory):
* Api/WebPage.h:
* WebKitSupport/InputHandler.cpp:
* WebKitSupport/InputHandler.h:
(InputHandler):
Modified Paths
Diff
Modified: trunk/Source/WebKit/blackberry/Api/WebPage.cpp (149570 => 149571)
--- trunk/Source/WebKit/blackberry/Api/WebPage.cpp 2013-05-05 01:34:59 UTC (rev 149570)
+++ trunk/Source/WebKit/blackberry/Api/WebPage.cpp 2013-05-05 01:47:47 UTC (rev 149571)
@@ -4281,11 +4281,6 @@
d->m_inputHandler->stopPendingSpellCheckRequests();
}
-void WebPage::spellCheckingRequestCancelled(int32_t transactionId)
-{
- d->m_inputHandler->spellCheckingRequestCancelled(transactionId);
-}
-
void WebPage::spellCheckingRequestProcessed(int32_t transactionId, spannable_string_t* spannableString)
{
d->m_inputHandler->spellCheckingRequestProcessed(transactionId, spannableString);
Modified: trunk/Source/WebKit/blackberry/Api/WebPage.h (149570 => 149571)
--- trunk/Source/WebKit/blackberry/Api/WebPage.h 2013-05-05 01:34:59 UTC (rev 149570)
+++ trunk/Source/WebKit/blackberry/Api/WebPage.h 2013-05-05 01:47:47 UTC (rev 149571)
@@ -255,7 +255,6 @@
void setSpellCheckingEnabled(bool);
void spellCheckingRequestProcessed(int32_t transactionId, spannable_string_t*);
- void spellCheckingRequestCancelled(int32_t transactionId);
bool isInputMode() const;
void setDocumentSelection(const Platform::IntPoint& documentStartPoint, const Platform::IntPoint& documentEndPoint);
Modified: trunk/Source/WebKit/blackberry/ChangeLog (149570 => 149571)
--- trunk/Source/WebKit/blackberry/ChangeLog 2013-05-05 01:34:59 UTC (rev 149570)
+++ trunk/Source/WebKit/blackberry/ChangeLog 2013-05-05 01:47:47 UTC (rev 149571)
@@ -1,3 +1,18 @@
+2013-05-04 Nima Ghanavatian <[email protected]>
+
+ [BlackBerry] Clean up unused spellcheck code
+ https://bugs.webkit.org/show_bug.cgi?id=115560
+
+ Reviewed by Benjamin Poulain.
+ Internally reviewed by Mike Lattanzio
+
+ * Api/WebPage.cpp:
+ (BlackBerry::WebKit::WebPage::setExtraPluginDirectory):
+ * Api/WebPage.h:
+ * WebKitSupport/InputHandler.cpp:
+ * WebKitSupport/InputHandler.h:
+ (InputHandler):
+
2013-05-03 Jacky Jiang <[email protected]>
[BlackBerry] Page rendering scale is changed after go back and forward
Modified: trunk/Source/WebKit/blackberry/WebKitSupport/InputHandler.cpp (149570 => 149571)
--- trunk/Source/WebKit/blackberry/WebKitSupport/InputHandler.cpp 2013-05-05 01:34:59 UTC (rev 149570)
+++ trunk/Source/WebKit/blackberry/WebKitSupport/InputHandler.cpp 2013-05-05 01:47:47 UTC (rev 149571)
@@ -672,21 +672,6 @@
m_request = spellCheckRequest;
}
-void InputHandler::spellCheckingRequestCancelled(int32_t)
-{
- SpellingLog(Platform::LogLevelWarn,
- "InputHandler::spellCheckingRequestCancelled Expected transaction id %d, received %d. %s",
- transactionId,
- m_processingTransactionId,
- transactionId == m_processingTransactionId ? "" : "We are out of sync with input service.");
-
- if (m_request) {
- m_request->didCancel();
- m_request = 0;
- }
- m_processingTransactionId = -1;
-}
-
void InputHandler::spellCheckingRequestProcessed(int32_t, spannable_string_t* spannableString)
{
SpellingLog(Platform::LogLevelWarn,
Modified: trunk/Source/WebKit/blackberry/WebKitSupport/InputHandler.h (149570 => 149571)
--- trunk/Source/WebKit/blackberry/WebKitSupport/InputHandler.h 2013-05-05 01:34:59 UTC (rev 149570)
+++ trunk/Source/WebKit/blackberry/WebKitSupport/InputHandler.h 2013-05-05 01:47:47 UTC (rev 149571)
@@ -148,7 +148,6 @@
void requestCheckingOfString(PassRefPtr<WebCore::SpellCheckRequest>);
void spellCheckingRequestProcessed(int32_t transactionId, spannable_string_t*);
- void spellCheckingRequestCancelled(int32_t transactionId);
void stopPendingSpellCheckRequests();
void spellCheckTextBlock(WebCore::Element* = 0);
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
