Title: [149633] trunk/Source/_javascript_Core
- Revision
- 149633
- Author
- [email protected]
- Date
- 2013-05-06 13:17:43 -0700 (Mon, 06 May 2013)
Log Message
Stop using WTF::deleteAllValues in _javascript_Core
https://bugs.webkit.org/show_bug.cgi?id=115670
Reviewed by Oliver Hunt.
Change the Vectors used to Vectors of OwnPtrs instead.
* heap/DFGCodeBlocks.cpp:
(JSC::DFGCodeBlocks::~DFGCodeBlocks):
(JSC::DFGCodeBlocks::deleteUnmarkedJettisonedCodeBlocks):
Modified Paths
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (149632 => 149633)
--- trunk/Source/_javascript_Core/ChangeLog 2013-05-06 20:15:19 UTC (rev 149632)
+++ trunk/Source/_javascript_Core/ChangeLog 2013-05-06 20:17:43 UTC (rev 149633)
@@ -1,3 +1,16 @@
+2013-05-06 Anders Carlsson <[email protected]>
+
+ Stop using WTF::deleteAllValues in _javascript_Core
+ https://bugs.webkit.org/show_bug.cgi?id=115670
+
+ Reviewed by Oliver Hunt.
+
+ Change the Vectors used to Vectors of OwnPtrs instead.
+
+ * heap/DFGCodeBlocks.cpp:
+ (JSC::DFGCodeBlocks::~DFGCodeBlocks):
+ (JSC::DFGCodeBlocks::deleteUnmarkedJettisonedCodeBlocks):
+
2013-05-06 Andras Becsi <[email protected]>
Build with GCC 4.8 fails because of -Wmaybe-uninitialized
Modified: trunk/Source/_javascript_Core/heap/DFGCodeBlocks.cpp (149632 => 149633)
--- trunk/Source/_javascript_Core/heap/DFGCodeBlocks.cpp 2013-05-06 20:15:19 UTC (rev 149632)
+++ trunk/Source/_javascript_Core/heap/DFGCodeBlocks.cpp 2013-05-06 20:17:43 UTC (rev 149633)
@@ -38,14 +38,12 @@
DFGCodeBlocks::~DFGCodeBlocks()
{
- Vector<CodeBlock*, 16> toRemove;
+ Vector<OwnPtr<CodeBlock>, 16> toRemove;
for (HashSet<CodeBlock*>::iterator iter = m_set.begin(); iter != m_set.end(); ++iter) {
if ((*iter)->m_dfgData->isJettisoned)
- toRemove.append(*iter);
+ toRemove.append(adoptPtr(*iter));
}
-
- WTF::deleteAllValues(toRemove);
}
void DFGCodeBlocks::jettison(PassOwnPtr<CodeBlock> codeBlockPtr)
@@ -75,14 +73,12 @@
void DFGCodeBlocks::deleteUnmarkedJettisonedCodeBlocks()
{
- Vector<CodeBlock*, 16> toRemove;
+ Vector<OwnPtr<CodeBlock>, 16> toRemove;
for (HashSet<CodeBlock*>::iterator iter = m_set.begin(); iter != m_set.end(); ++iter) {
if ((*iter)->m_dfgData->isJettisoned && !(*iter)->m_dfgData->mayBeExecuting)
- toRemove.append(*iter);
+ toRemove.append(adoptPtr(*iter));
}
-
- WTF::deleteAllValues(toRemove);
}
void DFGCodeBlocks::traceMarkedCodeBlocks(SlotVisitor& visitor)
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
