Title: [150585] trunk/Source/WebKit/blackberry
- Revision
- 150585
- Author
- [email protected]
- Date
- 2013-05-23 07:14:52 -0700 (Thu, 23 May 2013)
Log Message
[BlackBerry] Properly fill the ResourceError in FrameLoaderClientBlackBerry::cannotShowURLError
https://bugs.webkit.org/show_bug.cgi?id=116603
Patch by Rob Buis <[email protected]> on 2013-05-23
Reviewed by Xan Lopez.
PR 119789
Internally reviewed by Yong Li.
Provide a domain value for this ResourceError instance. Note that
this does not change behavior.
* WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
(WebCore::FrameLoaderClientBlackBerry::didRestoreFromPageCache):
Modified Paths
Diff
Modified: trunk/Source/WebKit/blackberry/ChangeLog (150584 => 150585)
--- trunk/Source/WebKit/blackberry/ChangeLog 2013-05-23 14:00:49 UTC (rev 150584)
+++ trunk/Source/WebKit/blackberry/ChangeLog 2013-05-23 14:14:52 UTC (rev 150585)
@@ -1,3 +1,19 @@
+2013-05-23 Rob Buis <[email protected]>
+
+ [BlackBerry] Properly fill the ResourceError in FrameLoaderClientBlackBerry::cannotShowURLError
+ https://bugs.webkit.org/show_bug.cgi?id=116603
+
+ Reviewed by Xan Lopez.
+
+ PR 119789
+ Internally reviewed by Yong Li.
+
+ Provide a domain value for this ResourceError instance. Note that
+ this does not change behavior.
+
+ * WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
+ (WebCore::FrameLoaderClientBlackBerry::didRestoreFromPageCache):
+
2013-05-21 Carlos Garcia Campos <[email protected]>
[BlackBerry] Make PagePopup implementation independent from WebCore
Modified: trunk/Source/WebKit/blackberry/WebCoreSupport/FrameLoaderClientBlackBerry.cpp (150584 => 150585)
--- trunk/Source/WebKit/blackberry/WebCoreSupport/FrameLoaderClientBlackBerry.cpp 2013-05-23 14:00:49 UTC (rev 150584)
+++ trunk/Source/WebKit/blackberry/WebCoreSupport/FrameLoaderClientBlackBerry.cpp 2013-05-23 14:14:52 UTC (rev 150585)
@@ -1307,8 +1307,7 @@
// We don't need to provide the error message string, that will be handled in BrowserErrorPage according to the error code.
ResourceError FrameLoaderClientBlackBerry::cannotShowURLError(const ResourceRequest& request)
{
- // FIXME: Why are we not passing the domain to the ResourceError? See PR #119789.
- return ResourceError(String(), WebKitErrorCannotShowURL, request.url().string(), String());
+ return ResourceError("WebKitErrorDomain", WebKitErrorCannotShowURL, request.url().string(), String());
}
void FrameLoaderClientBlackBerry::didRestoreFromPageCache()
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
