[webkit-changes] [150586] trunk

Thu, 23 May 2013 08:18:34 -0700

Title: [150586] trunk
Revision
150586
Author
[email protected]
Date
2013-05-23 08:20:13 -0700 (Thu, 23 May 2013)

Log Message

Remove [NoInterfaceObject] from FileReaderSync and WorkerLocation
https://bugs.webkit.org/show_bug.cgi?id=116660

Reviewed by Kentaro Hara.

Source/WebCore:

Remove [NoInterfaceObject] from FileReaderSync and WorkerLocation to match their
respective specifications:
- http://dev.w3.org/2006/webapi/FileAPI/#FileReaderSync
- http://dev.w3.org/html5/workers/#workerlocation

No new tests, covered by existing tests.

* fileapi/FileReaderSync.idl:
* workers/WorkerLocation.idl:

LayoutTests:

Rebaseline a couple of test cases now that FileReaderSync and WorkerLocation
attributes are exposed on the global Window object.

* fast/js/global-constructors-attributes-expected.txt:
* platform/efl/fast/js/constructor-length-expected.txt:
* platform/efl/fast/js/global-constructors-attributes-expected.txt:
* platform/gtk/fast/js/constructor-length-expected.txt:
* platform/gtk/fast/js/global-constructors-attributes-expected.txt:
* platform/mac-lion/fast/js/global-constructors-attributes-expected.txt:
* platform/mac/fast/js/constructor-length-expected.txt:
* platform/qt/fast/js/constructor-length-expected.txt:
* platform/qt/fast/js/global-constructors-attributes-expected.txt:

Modified Paths

Diff

Modified: trunk/LayoutTests/ChangeLog (150585 => 150586)


--- trunk/LayoutTests/ChangeLog	2013-05-23 14:14:52 UTC (rev 150585)
+++ trunk/LayoutTests/ChangeLog	2013-05-23 15:20:13 UTC (rev 150586)
@@ -1,3 +1,23 @@
+2013-05-23  Christophe Dumez  <[email protected]>
+
+        Remove [NoInterfaceObject] from FileReaderSync and WorkerLocation
+        https://bugs.webkit.org/show_bug.cgi?id=116660
+
+        Reviewed by Kentaro Hara.
+
+        Rebaseline a couple of test cases now that FileReaderSync and WorkerLocation
+        attributes are exposed on the global Window object.
+
+        * fast/js/global-constructors-attributes-expected.txt:
+        * platform/efl/fast/js/constructor-length-expected.txt:
+        * platform/efl/fast/js/global-constructors-attributes-expected.txt:
+        * platform/gtk/fast/js/constructor-length-expected.txt:
+        * platform/gtk/fast/js/global-constructors-attributes-expected.txt:
+        * platform/mac-lion/fast/js/global-constructors-attributes-expected.txt:
+        * platform/mac/fast/js/constructor-length-expected.txt:
+        * platform/qt/fast/js/constructor-length-expected.txt:
+        * platform/qt/fast/js/global-constructors-attributes-expected.txt:
+
 2013-05-23  Zoltan Arvai  <[email protected]>
 
         [Qt] Unreviewed gardening.

Modified: trunk/LayoutTests/fast/js/global-constructors-attributes-expected.txt (150585 => 150586)


--- trunk/LayoutTests/fast/js/global-constructors-attributes-expected.txt	2013-05-23 14:14:52 UTC (rev 150585)
+++ trunk/LayoutTests/fast/js/global-constructors-attributes-expected.txt	2013-05-23 15:20:13 UTC (rev 150586)
@@ -348,6 +348,11 @@
 PASS Object.getOwnPropertyDescriptor(global, 'FileReader').hasOwnProperty('set') is false
 PASS Object.getOwnPropertyDescriptor(global, 'FileReader').enumerable is false
 PASS Object.getOwnPropertyDescriptor(global, 'FileReader').configurable is true
+PASS Object.getOwnPropertyDescriptor(global, 'FileReaderSync').value is FileReaderSync
+PASS Object.getOwnPropertyDescriptor(global, 'FileReaderSync').hasOwnProperty('get') is false
+PASS Object.getOwnPropertyDescriptor(global, 'FileReaderSync').hasOwnProperty('set') is false
+PASS Object.getOwnPropertyDescriptor(global, 'FileReaderSync').enumerable is false
+PASS Object.getOwnPropertyDescriptor(global, 'FileReaderSync').configurable is true
 PASS Object.getOwnPropertyDescriptor(global, 'Float32Array').value is Float32Array
 PASS Object.getOwnPropertyDescriptor(global, 'Float32Array').hasOwnProperty('get') is false
 PASS Object.getOwnPropertyDescriptor(global, 'Float32Array').hasOwnProperty('set') is false
@@ -1938,6 +1943,11 @@
 PASS Object.getOwnPropertyDescriptor(global, 'Worker').hasOwnProperty('set') is false
 PASS Object.getOwnPropertyDescriptor(global, 'Worker').enumerable is false
 PASS Object.getOwnPropertyDescriptor(global, 'Worker').configurable is true
+PASS Object.getOwnPropertyDescriptor(global, 'WorkerLocation').value is WorkerLocation
+PASS Object.getOwnPropertyDescriptor(global, 'WorkerLocation').hasOwnProperty('get') is false
+PASS Object.getOwnPropertyDescriptor(global, 'WorkerLocation').hasOwnProperty('set') is false
+PASS Object.getOwnPropertyDescriptor(global, 'WorkerLocation').enumerable is false
+PASS Object.getOwnPropertyDescriptor(global, 'WorkerLocation').configurable is true
 PASS Object.getOwnPropertyDescriptor(global, 'XMLDocument').value is XMLDocument
 PASS Object.getOwnPropertyDescriptor(global, 'XMLDocument').hasOwnProperty('get') is false
 PASS Object.getOwnPropertyDescriptor(global, 'XMLDocument').hasOwnProperty('set') is false

Modified: trunk/LayoutTests/platform/efl/fast/js/constructor-length-expected.txt (150585 => 150586)


--- trunk/LayoutTests/platform/efl/fast/js/constructor-length-expected.txt	2013-05-23 14:14:52 UTC (rev 150585)
+++ trunk/LayoutTests/platform/efl/fast/js/constructor-length-expected.txt	2013-05-23 15:20:13 UTC (rev 150586)
@@ -18,7 +18,7 @@
 PASS Float32Array.length is 1
 PASS Float64Array.length is 1
 PASS FileReader.length is 0
-FAIL FileReaderSync.length should be 0. Threw exception ReferenceError: Can't find variable: FileReaderSync
+PASS FileReaderSync.length is 0
 PASS HashChangeEvent.length is 1
 PASS Int16Array.length is 1
 PASS Int32Array.length is 1

Modified: trunk/LayoutTests/platform/efl/fast/js/global-constructors-attributes-expected.txt (150585 => 150586)


--- trunk/LayoutTests/platform/efl/fast/js/global-constructors-attributes-expected.txt	2013-05-23 14:14:52 UTC (rev 150585)
+++ trunk/LayoutTests/platform/efl/fast/js/global-constructors-attributes-expected.txt	2013-05-23 15:20:13 UTC (rev 150586)
@@ -348,6 +348,11 @@
 PASS Object.getOwnPropertyDescriptor(global, 'FileReader').hasOwnProperty('set') is false
 PASS Object.getOwnPropertyDescriptor(global, 'FileReader').enumerable is false
 PASS Object.getOwnPropertyDescriptor(global, 'FileReader').configurable is true
+PASS Object.getOwnPropertyDescriptor(global, 'FileReaderSync').value is FileReaderSync
+PASS Object.getOwnPropertyDescriptor(global, 'FileReaderSync').hasOwnProperty('get') is false
+PASS Object.getOwnPropertyDescriptor(global, 'FileReaderSync').hasOwnProperty('set') is false
+PASS Object.getOwnPropertyDescriptor(global, 'FileReaderSync').enumerable is false
+PASS Object.getOwnPropertyDescriptor(global, 'FileReaderSync').configurable is true
 PASS Object.getOwnPropertyDescriptor(global, 'Float32Array').value is Float32Array
 PASS Object.getOwnPropertyDescriptor(global, 'Float32Array').hasOwnProperty('get') is false
 PASS Object.getOwnPropertyDescriptor(global, 'Float32Array').hasOwnProperty('set') is false
@@ -2018,6 +2023,11 @@
 PASS Object.getOwnPropertyDescriptor(global, 'Worker').hasOwnProperty('set') is false
 PASS Object.getOwnPropertyDescriptor(global, 'Worker').enumerable is false
 PASS Object.getOwnPropertyDescriptor(global, 'Worker').configurable is true
+PASS Object.getOwnPropertyDescriptor(global, 'WorkerLocation').value is WorkerLocation
+PASS Object.getOwnPropertyDescriptor(global, 'WorkerLocation').hasOwnProperty('get') is false
+PASS Object.getOwnPropertyDescriptor(global, 'WorkerLocation').hasOwnProperty('set') is false
+PASS Object.getOwnPropertyDescriptor(global, 'WorkerLocation').enumerable is false
+PASS Object.getOwnPropertyDescriptor(global, 'WorkerLocation').configurable is true
 PASS Object.getOwnPropertyDescriptor(global, 'XMLDocument').value is XMLDocument
 PASS Object.getOwnPropertyDescriptor(global, 'XMLDocument').hasOwnProperty('get') is false
 PASS Object.getOwnPropertyDescriptor(global, 'XMLDocument').hasOwnProperty('set') is false

Modified: trunk/LayoutTests/platform/gtk/fast/js/constructor-length-expected.txt (150585 => 150586)


--- trunk/LayoutTests/platform/gtk/fast/js/constructor-length-expected.txt	2013-05-23 14:14:52 UTC (rev 150585)
+++ trunk/LayoutTests/platform/gtk/fast/js/constructor-length-expected.txt	2013-05-23 15:20:13 UTC (rev 150586)
@@ -18,7 +18,7 @@
 PASS Float32Array.length is 1
 PASS Float64Array.length is 1
 PASS FileReader.length is 0
-FAIL FileReaderSync.length should be 0. Threw exception ReferenceError: Can't find variable: FileReaderSync
+PASS FileReaderSync.length is 0
 PASS HashChangeEvent.length is 1
 PASS Int16Array.length is 1
 PASS Int32Array.length is 1

Modified: trunk/LayoutTests/platform/gtk/fast/js/global-constructors-attributes-expected.txt (150585 => 150586)


--- trunk/LayoutTests/platform/gtk/fast/js/global-constructors-attributes-expected.txt	2013-05-23 14:14:52 UTC (rev 150585)
+++ trunk/LayoutTests/platform/gtk/fast/js/global-constructors-attributes-expected.txt	2013-05-23 15:20:13 UTC (rev 150586)
@@ -348,6 +348,11 @@
 PASS Object.getOwnPropertyDescriptor(global, 'FileReader').hasOwnProperty('set') is false
 PASS Object.getOwnPropertyDescriptor(global, 'FileReader').enumerable is false
 PASS Object.getOwnPropertyDescriptor(global, 'FileReader').configurable is true
+PASS Object.getOwnPropertyDescriptor(global, 'FileReaderSync').value is FileReaderSync
+PASS Object.getOwnPropertyDescriptor(global, 'FileReaderSync').hasOwnProperty('get') is false
+PASS Object.getOwnPropertyDescriptor(global, 'FileReaderSync').hasOwnProperty('set') is false
+PASS Object.getOwnPropertyDescriptor(global, 'FileReaderSync').enumerable is false
+PASS Object.getOwnPropertyDescriptor(global, 'FileReaderSync').configurable is true
 PASS Object.getOwnPropertyDescriptor(global, 'Float32Array').value is Float32Array
 PASS Object.getOwnPropertyDescriptor(global, 'Float32Array').hasOwnProperty('get') is false
 PASS Object.getOwnPropertyDescriptor(global, 'Float32Array').hasOwnProperty('set') is false
@@ -2023,6 +2028,11 @@
 PASS Object.getOwnPropertyDescriptor(global, 'Worker').hasOwnProperty('set') is false
 PASS Object.getOwnPropertyDescriptor(global, 'Worker').enumerable is false
 PASS Object.getOwnPropertyDescriptor(global, 'Worker').configurable is true
+PASS Object.getOwnPropertyDescriptor(global, 'WorkerLocation').value is WorkerLocation
+PASS Object.getOwnPropertyDescriptor(global, 'WorkerLocation').hasOwnProperty('get') is false
+PASS Object.getOwnPropertyDescriptor(global, 'WorkerLocation').hasOwnProperty('set') is false
+PASS Object.getOwnPropertyDescriptor(global, 'WorkerLocation').enumerable is false
+PASS Object.getOwnPropertyDescriptor(global, 'WorkerLocation').configurable is true
 PASS Object.getOwnPropertyDescriptor(global, 'XMLDocument').value is XMLDocument
 PASS Object.getOwnPropertyDescriptor(global, 'XMLDocument').hasOwnProperty('get') is false
 PASS Object.getOwnPropertyDescriptor(global, 'XMLDocument').hasOwnProperty('set') is false

Modified: trunk/LayoutTests/platform/mac/fast/js/constructor-length-expected.txt (150585 => 150586)


--- trunk/LayoutTests/platform/mac/fast/js/constructor-length-expected.txt	2013-05-23 14:14:52 UTC (rev 150585)
+++ trunk/LayoutTests/platform/mac/fast/js/constructor-length-expected.txt	2013-05-23 15:20:13 UTC (rev 150586)
@@ -18,7 +18,7 @@
 PASS Float32Array.length is 1
 PASS Float64Array.length is 1
 PASS FileReader.length is 0
-FAIL FileReaderSync.length should be 0. Threw exception ReferenceError: Can't find variable: FileReaderSync
+PASS FileReaderSync.length is 0
 PASS HashChangeEvent.length is 1
 PASS Int16Array.length is 1
 PASS Int32Array.length is 1

Modified: trunk/LayoutTests/platform/mac-lion/fast/js/global-constructors-attributes-expected.txt (150585 => 150586)


--- trunk/LayoutTests/platform/mac-lion/fast/js/global-constructors-attributes-expected.txt	2013-05-23 14:14:52 UTC (rev 150585)
+++ trunk/LayoutTests/platform/mac-lion/fast/js/global-constructors-attributes-expected.txt	2013-05-23 15:20:13 UTC (rev 150586)
@@ -348,6 +348,11 @@
 PASS Object.getOwnPropertyDescriptor(global, 'FileReader').hasOwnProperty('set') is false
 PASS Object.getOwnPropertyDescriptor(global, 'FileReader').enumerable is false
 PASS Object.getOwnPropertyDescriptor(global, 'FileReader').configurable is true
+PASS Object.getOwnPropertyDescriptor(global, 'FileReaderSync').value is FileReaderSync
+PASS Object.getOwnPropertyDescriptor(global, 'FileReaderSync').hasOwnProperty('get') is false
+PASS Object.getOwnPropertyDescriptor(global, 'FileReaderSync').hasOwnProperty('set') is false
+PASS Object.getOwnPropertyDescriptor(global, 'FileReaderSync').enumerable is false
+PASS Object.getOwnPropertyDescriptor(global, 'FileReaderSync').configurable is true
 PASS Object.getOwnPropertyDescriptor(global, 'Float32Array').value is Float32Array
 PASS Object.getOwnPropertyDescriptor(global, 'Float32Array').hasOwnProperty('get') is false
 PASS Object.getOwnPropertyDescriptor(global, 'Float32Array').hasOwnProperty('set') is false
@@ -1933,6 +1938,11 @@
 PASS Object.getOwnPropertyDescriptor(global, 'Worker').hasOwnProperty('set') is false
 PASS Object.getOwnPropertyDescriptor(global, 'Worker').enumerable is false
 PASS Object.getOwnPropertyDescriptor(global, 'Worker').configurable is true
+PASS Object.getOwnPropertyDescriptor(global, 'WorkerLocation').value is WorkerLocation
+PASS Object.getOwnPropertyDescriptor(global, 'WorkerLocation').hasOwnProperty('get') is false
+PASS Object.getOwnPropertyDescriptor(global, 'WorkerLocation').hasOwnProperty('set') is false
+PASS Object.getOwnPropertyDescriptor(global, 'WorkerLocation').enumerable is false
+PASS Object.getOwnPropertyDescriptor(global, 'WorkerLocation').configurable is true
 PASS Object.getOwnPropertyDescriptor(global, 'XMLDocument').value is XMLDocument
 PASS Object.getOwnPropertyDescriptor(global, 'XMLDocument').hasOwnProperty('get') is false
 PASS Object.getOwnPropertyDescriptor(global, 'XMLDocument').hasOwnProperty('set') is false

Modified: trunk/LayoutTests/platform/qt/fast/js/constructor-length-expected.txt (150585 => 150586)


--- trunk/LayoutTests/platform/qt/fast/js/constructor-length-expected.txt	2013-05-23 14:14:52 UTC (rev 150585)
+++ trunk/LayoutTests/platform/qt/fast/js/constructor-length-expected.txt	2013-05-23 15:20:13 UTC (rev 150586)
@@ -18,7 +18,7 @@
 PASS Float32Array.length is 1
 PASS Float64Array.length is 1
 PASS FileReader.length is 0
-FAIL FileReaderSync.length should be 0. Threw exception ReferenceError: Can't find variable: FileReaderSync
+PASS FileReaderSync.length is 0
 PASS HashChangeEvent.length is 1
 PASS Int16Array.length is 1
 PASS Int32Array.length is 1

Modified: trunk/LayoutTests/platform/qt/fast/js/global-constructors-attributes-expected.txt (150585 => 150586)


--- trunk/LayoutTests/platform/qt/fast/js/global-constructors-attributes-expected.txt	2013-05-23 14:14:52 UTC (rev 150585)
+++ trunk/LayoutTests/platform/qt/fast/js/global-constructors-attributes-expected.txt	2013-05-23 15:20:13 UTC (rev 150586)
@@ -288,6 +288,11 @@
 PASS Object.getOwnPropertyDescriptor(global, 'FileReader').hasOwnProperty('set') is false
 PASS Object.getOwnPropertyDescriptor(global, 'FileReader').enumerable is false
 PASS Object.getOwnPropertyDescriptor(global, 'FileReader').configurable is true
+PASS Object.getOwnPropertyDescriptor(global, 'FileReaderSync').value is FileReaderSync
+PASS Object.getOwnPropertyDescriptor(global, 'FileReaderSync').hasOwnProperty('get') is false
+PASS Object.getOwnPropertyDescriptor(global, 'FileReaderSync').hasOwnProperty('set') is false
+PASS Object.getOwnPropertyDescriptor(global, 'FileReaderSync').enumerable is false
+PASS Object.getOwnPropertyDescriptor(global, 'FileReaderSync').configurable is true
 PASS Object.getOwnPropertyDescriptor(global, 'Float32Array').value is Float32Array
 PASS Object.getOwnPropertyDescriptor(global, 'Float32Array').hasOwnProperty('get') is false
 PASS Object.getOwnPropertyDescriptor(global, 'Float32Array').hasOwnProperty('set') is false
@@ -1838,6 +1843,11 @@
 PASS Object.getOwnPropertyDescriptor(global, 'Worker').hasOwnProperty('set') is false
 PASS Object.getOwnPropertyDescriptor(global, 'Worker').enumerable is false
 PASS Object.getOwnPropertyDescriptor(global, 'Worker').configurable is true
+PASS Object.getOwnPropertyDescriptor(global, 'WorkerLocation').value is WorkerLocation
+PASS Object.getOwnPropertyDescriptor(global, 'WorkerLocation').hasOwnProperty('get') is false
+PASS Object.getOwnPropertyDescriptor(global, 'WorkerLocation').hasOwnProperty('set') is false
+PASS Object.getOwnPropertyDescriptor(global, 'WorkerLocation').enumerable is false
+PASS Object.getOwnPropertyDescriptor(global, 'WorkerLocation').configurable is true
 PASS Object.getOwnPropertyDescriptor(global, 'XMLDocument').value is XMLDocument
 PASS Object.getOwnPropertyDescriptor(global, 'XMLDocument').hasOwnProperty('get') is false
 PASS Object.getOwnPropertyDescriptor(global, 'XMLDocument').hasOwnProperty('set') is false

Modified: trunk/Source/WebCore/ChangeLog (150585 => 150586)


--- trunk/Source/WebCore/ChangeLog	2013-05-23 14:14:52 UTC (rev 150585)
+++ trunk/Source/WebCore/ChangeLog	2013-05-23 15:20:13 UTC (rev 150586)
@@ -1,5 +1,22 @@
 2013-05-23  Christophe Dumez  <[email protected]>
 
+        Remove [NoInterfaceObject] from FileReaderSync and WorkerLocation
+        https://bugs.webkit.org/show_bug.cgi?id=116660
+
+        Reviewed by Kentaro Hara.
+
+        Remove [NoInterfaceObject] from FileReaderSync and WorkerLocation to match their
+        respective specifications:
+        - http://dev.w3.org/2006/webapi/FileAPI/#FileReaderSync
+        - http://dev.w3.org/html5/workers/#workerlocation
+
+        No new tests, covered by existing tests.
+
+        * fileapi/FileReaderSync.idl:
+        * workers/WorkerLocation.idl:
+
+2013-05-23  Christophe Dumez  <[email protected]>
+
         Remove special case for MessagePortArray from bindings generator
         https://bugs.webkit.org/show_bug.cgi?id=116653

Modified: trunk/Source/WebCore/fileapi/FileReaderSync.idl (150585 => 150586)


--- trunk/Source/WebCore/fileapi/FileReaderSync.idl	2013-05-23 14:14:52 UTC (rev 150585)
+++ trunk/Source/WebCore/fileapi/FileReaderSync.idl	2013-05-23 15:20:13 UTC (rev 150586)
@@ -29,7 +29,6 @@
  */
 
 [
-    NoInterfaceObject,
     Conditional=BLOB,
     Constructor,
     JSNoStaticTables

Modified: trunk/Source/WebCore/workers/WorkerLocation.idl (150585 => 150586)


--- trunk/Source/WebCore/workers/WorkerLocation.idl	2013-05-23 14:14:52 UTC (rev 150585)
+++ trunk/Source/WebCore/workers/WorkerLocation.idl	2013-05-23 15:20:13 UTC (rev 150586)
@@ -27,7 +27,6 @@
  */
 
 [
-    NoInterfaceObject,
     Conditional=WORKERS,
     GenerateIsReachable=Impl,
     JSNoStaticTables,

_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to