Title: [151578] trunk/Source
- Revision
- 151578
- Author
- [email protected]
- Date
- 2013-06-13 20:43:03 -0700 (Thu, 13 Jun 2013)
Log Message
Remove LiteralIdentifierTable
https://bugs.webkit.org/show_bug.cgi?id=117613
Reviewed by Geoffrey Garen.
Removed LiteralIdentifierTable since it doesn't seem to have any perf. impact now.
Source/_javascript_Core:
* runtime/Identifier.cpp:
(JSC::Identifier::add):
Source/WTF:
* wtf/WTFThreadData.h:
Modified Paths
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (151577 => 151578)
--- trunk/Source/_javascript_Core/ChangeLog 2013-06-14 02:55:24 UTC (rev 151577)
+++ trunk/Source/_javascript_Core/ChangeLog 2013-06-14 03:43:03 UTC (rev 151578)
@@ -1,3 +1,15 @@
+2013-06-13 Ryosuke Niwa <[email protected]>
+
+ Remove LiteralIdentifierTable
+ https://bugs.webkit.org/show_bug.cgi?id=117613
+
+ Reviewed by Geoffrey Garen.
+
+ Removed LiteralIdentifierTable since it doesn't seem to have any perf. impact now.
+
+ * runtime/Identifier.cpp:
+ (JSC::Identifier::add):
+
2013-06-12 Conrad Shultz <[email protected]>
JSExport header documentation substitutes "semicolon" for "colon"
Modified: trunk/Source/_javascript_Core/runtime/Identifier.cpp (151577 => 151578)
--- trunk/Source/_javascript_Core/runtime/Identifier.cpp 2013-06-14 02:55:24 UTC (rev 151577)
+++ trunk/Source/_javascript_Core/runtime/Identifier.cpp 2013-06-14 03:43:03 UTC (rev 151578)
@@ -96,20 +96,13 @@
return add(vm, vm->smallStrings.singleCharacterStringRep(c[0]));
IdentifierTable& identifierTable = *vm->identifierTable;
- LiteralIdentifierTable& literalIdentifierTable = identifierTable.literalTable();
- const LiteralIdentifierTable::iterator& iter = literalIdentifierTable.find(c);
- if (iter != literalIdentifierTable.end())
- return iter->value;
-
HashSet<StringImpl*>::AddResult addResult = identifierTable.add<const LChar*, IdentifierASCIIStringTranslator>(reinterpret_cast<const LChar*>(c));
// If the string is newly-translated, then we need to adopt it.
// The boolean in the pair tells us if that is so.
RefPtr<StringImpl> addedString = addResult.isNewEntry ? adoptRef(*addResult.iterator) : *addResult.iterator;
- literalIdentifierTable.add(c, addedString.get());
-
return addedString.release();
}
Modified: trunk/Source/WTF/ChangeLog (151577 => 151578)
--- trunk/Source/WTF/ChangeLog 2013-06-14 02:55:24 UTC (rev 151577)
+++ trunk/Source/WTF/ChangeLog 2013-06-14 03:43:03 UTC (rev 151578)
@@ -1,3 +1,14 @@
+2013-06-13 Ryosuke Niwa <[email protected]>
+
+ Remove LiteralIdentifierTable
+ https://bugs.webkit.org/show_bug.cgi?id=117613
+
+ Reviewed by Geoffrey Garen.
+
+ Removed LiteralIdentifierTable since it doesn't seem to have any perf. impact now.
+
+ * wtf/WTFThreadData.h:
+
2013-06-13 Brent Fulgham <[email protected]>
[WinCairo] Correct FeatureDefines.h Default for ENABLE_VIEW_MODE_CSS_MEDIA
Modified: trunk/Source/WTF/wtf/WTFThreadData.h (151577 => 151578)
--- trunk/Source/WTF/wtf/WTFThreadData.h 2013-06-14 02:55:24 UTC (rev 151577)
+++ trunk/Source/WTF/wtf/WTFThreadData.h 2013-06-14 03:43:03 UTC (rev 151578)
@@ -39,8 +39,6 @@
// FIXME: This is a temporary layering violation while we move more string code to WTF.
namespace JSC {
-typedef HashMap<const char*, RefPtr<StringImpl>, PtrHash<const char*> > LiteralIdentifierTable;
-
class IdentifierTable {
WTF_MAKE_FAST_ALLOCATED;
public:
@@ -59,11 +57,8 @@
return true;
}
- LiteralIdentifierTable& literalTable() { return m_literalTable; }
-
private:
HashSet<StringImpl*> m_table;
- LiteralIdentifierTable m_literalTable;
};
}
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
