Title: [151579] trunk/Source/WebCore
- Revision
- 151579
- Author
- [email protected]
- Date
- 2013-06-13 21:32:35 -0700 (Thu, 13 Jun 2013)
Log Message
Should not call firePaintRelatedMilestones() for "update control tints" paint pass
https://bugs.webkit.org/show_bug.cgi?id=117624
Reviewed by Sam Weinig.
When window activation changes, we do a fake paint pass that is just used to
invalidate controls that change their appearance in background windows. This fake
paint should not be recorded in the inspector, and it should not cause paint-related
milestones to fire.
* page/FrameView.cpp:
(WebCore::FrameView::paintContents):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (151578 => 151579)
--- trunk/Source/WebCore/ChangeLog 2013-06-14 03:43:03 UTC (rev 151578)
+++ trunk/Source/WebCore/ChangeLog 2013-06-14 04:32:35 UTC (rev 151579)
@@ -1,3 +1,18 @@
+2013-06-13 Simon Fraser <[email protected]>
+
+ Should not call firePaintRelatedMilestones() for "update control tints" paint pass
+ https://bugs.webkit.org/show_bug.cgi?id=117624
+
+ Reviewed by Sam Weinig.
+
+ When window activation changes, we do a fake paint pass that is just used to
+ invalidate controls that change their appearance in background windows. This fake
+ paint should not be recorded in the inspector, and it should not cause paint-related
+ milestones to fire.
+
+ * page/FrameView.cpp:
+ (WebCore::FrameView::paintContents):
+
2013-06-13 Dean Jackson <[email protected]>
Clicking on snapshotting plug-ins does not restart them
Modified: trunk/Source/WebCore/page/FrameView.cpp (151578 => 151579)
--- trunk/Source/WebCore/page/FrameView.cpp 2013-06-14 03:43:03 UTC (rev 151578)
+++ trunk/Source/WebCore/page/FrameView.cpp 2013-06-14 04:32:35 UTC (rev 151579)
@@ -3504,7 +3504,8 @@
if (needsLayout())
return;
- InspectorInstrumentation::willPaint(renderView);
+ if (!p->paintingDisabled())
+ InspectorInstrumentation::willPaint(renderView);
bool isTopLevelPainter = !sCurrentPaintTimeStamp;
if (isTopLevelPainter)
@@ -3568,8 +3569,11 @@
if (isTopLevelPainter)
sCurrentPaintTimeStamp = 0;
- InspectorInstrumentation::didPaint(renderView, p, rect);
- firePaintRelatedMilestones();
+ if (!p->paintingDisabled()) {
+ InspectorInstrumentation::didPaint(renderView, p, rect);
+ // FIXME: should probably not fire milestones for snapshot painting. https://bugs.webkit.org/show_bug.cgi?id=117623
+ firePaintRelatedMilestones();
+ }
}
void FrameView::setPaintBehavior(PaintBehavior behavior)
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
