Title: [151778] trunk/Source/WebCore
Revision
151778
Author
[email protected]
Date
2013-06-20 09:16:02 -0700 (Thu, 20 Jun 2013)

Log Message

AX: List Items should support a default action
https://bugs.webkit.org/show_bug.cgi?id=117812

Reviewed by Chris Fleizach.

* accessibility/AccessibilityObject.cpp:
(WebCore::AccessibilityObject::actionVerb): Provide a "select" verb
for use in ListItemRole objects.
* platform/LocalizedStrings.cpp:
(WebCore::AXListItemActionVerb): Added.
* platform/LocalizedStrings.h:
* platform/blackberry/LocalizedStringsBlackBerry.cpp:
(WebCore::AXListItemActionVerb):
* platform/efl/LocalizedStringsEfl.cpp:
(WebCore::AXListItemActionVerb):
* platform/gtk/LocalizedStringsGtk.cpp:
(WebCore::AXListItemActionVerb):

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (151777 => 151778)


--- trunk/Source/WebCore/ChangeLog	2013-06-20 16:13:11 UTC (rev 151777)
+++ trunk/Source/WebCore/ChangeLog	2013-06-20 16:16:02 UTC (rev 151778)
@@ -1,3 +1,23 @@
+2013-06-19  Brent Fulgham  <[email protected]>
+
+        AX: List Items should support a default action
+        https://bugs.webkit.org/show_bug.cgi?id=117812
+
+        Reviewed by Chris Fleizach.
+
+        * accessibility/AccessibilityObject.cpp:
+        (WebCore::AccessibilityObject::actionVerb): Provide a "select" verb
+        for use in ListItemRole objects.
+        * platform/LocalizedStrings.cpp:
+        (WebCore::AXListItemActionVerb): Added.
+        * platform/LocalizedStrings.h:
+        * platform/blackberry/LocalizedStringsBlackBerry.cpp:
+        (WebCore::AXListItemActionVerb):
+        * platform/efl/LocalizedStringsEfl.cpp:
+        (WebCore::AXListItemActionVerb):
+        * platform/gtk/LocalizedStringsGtk.cpp:
+        (WebCore::AXListItemActionVerb):
+
 2013-06-20  Radu Stavila  <[email protected]>
 
         [CSS Regions] Add new regionOversetChange event

Modified: trunk/Source/WebCore/accessibility/AccessibilityObject.cpp (151777 => 151778)


--- trunk/Source/WebCore/accessibility/AccessibilityObject.cpp	2013-06-20 16:13:11 UTC (rev 151777)
+++ trunk/Source/WebCore/accessibility/AccessibilityObject.cpp	2013-06-20 16:16:02 UTC (rev 151778)
@@ -1285,6 +1285,7 @@
     DEFINE_STATIC_LOCAL(const String, linkAction, (AXLinkActionVerb()));
     DEFINE_STATIC_LOCAL(const String, menuListAction, (AXMenuListActionVerb()));
     DEFINE_STATIC_LOCAL(const String, menuListPopupAction, (AXMenuListPopupActionVerb()));
+    DEFINE_STATIC_LOCAL(const String, listItemAction, (AXListItemActionVerb()));
     DEFINE_STATIC_LOCAL(const String, noAction, ());
 
     switch (roleValue()) {
@@ -1305,6 +1306,8 @@
         return menuListAction;
     case MenuListPopupRole:
         return menuListPopupAction;
+    case ListItemRole:
+        return listItemAction;
     default:
         return noAction;
     }

Modified: trunk/Source/WebCore/platform/LocalizedStrings.cpp (151777 => 151778)


--- trunk/Source/WebCore/platform/LocalizedStrings.cpp	2013-06-20 16:13:11 UTC (rev 151777)
+++ trunk/Source/WebCore/platform/LocalizedStrings.cpp	2013-06-20 16:16:02 UTC (rev 151778)
@@ -643,6 +643,12 @@
     notImplemented();
     return "select";
 }
+
+String AXListItemActionVerb()
+{
+    notImplemented();
+    return "select";
+}
 #endif // !PLATFORM(IOS)
 
 #if PLATFORM(MAC) || PLATFORM(IOS)

Modified: trunk/Source/WebCore/platform/LocalizedStrings.h (151777 => 151778)


--- trunk/Source/WebCore/platform/LocalizedStrings.h	2013-06-20 16:13:11 UTC (rev 151777)
+++ trunk/Source/WebCore/platform/LocalizedStrings.h	2013-06-20 16:16:02 UTC (rev 151778)
@@ -170,6 +170,7 @@
     String AXMenuListActionVerb();
     String AXMenuListPopupActionVerb();
     String AXLinkActionVerb();
+    String AXListItemActionVerb();
 
 #if ENABLE(INPUT_TYPE_WEEK)
     // weekFormatInLDML() returns week and year format in LDML, Unicode

Modified: trunk/Source/WebCore/platform/blackberry/LocalizedStringsBlackBerry.cpp (151777 => 151778)


--- trunk/Source/WebCore/platform/blackberry/LocalizedStringsBlackBerry.cpp	2013-06-20 16:13:11 UTC (rev 151777)
+++ trunk/Source/WebCore/platform/blackberry/LocalizedStringsBlackBerry.cpp	2013-06-20 16:16:02 UTC (rev 151778)
@@ -187,6 +187,12 @@
     return String();
 }
 
+String AXListItemActionVerb()
+{
+    notImplemented();
+    return String();
+}
+
 String unknownFileSizeText()
 {
     notImplemented();

Modified: trunk/Source/WebCore/platform/efl/LocalizedStringsEfl.cpp (151777 => 151778)


--- trunk/Source/WebCore/platform/efl/LocalizedStringsEfl.cpp	2013-06-20 16:13:11 UTC (rev 151777)
+++ trunk/Source/WebCore/platform/efl/LocalizedStringsEfl.cpp	2013-06-20 16:16:02 UTC (rev 151778)
@@ -434,6 +434,12 @@
     return String();
 }
 
+String AXListItemActionVerb()
+{
+    notImplemented();
+    return String();
+}
+
 #if ENABLE(VIDEO)
 String localizedMediaControlElementString(const String&)
 {

Modified: trunk/Source/WebCore/platform/gtk/LocalizedStringsGtk.cpp (151777 => 151778)


--- trunk/Source/WebCore/platform/gtk/LocalizedStringsGtk.cpp	2013-06-20 16:13:11 UTC (rev 151777)
+++ trunk/Source/WebCore/platform/gtk/LocalizedStringsGtk.cpp	2013-06-20 16:16:02 UTC (rev 151778)
@@ -481,6 +481,11 @@
 {
     return String();
 }
+
+String AXListItemActionVerb()
+{
+    return String();
+}
     
 String missingPluginText()
 {
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to