Title: [151779] trunk/Tools
- Revision
- 151779
- Author
- [email protected]
- Date
- 2013-06-20 09:59:54 -0700 (Thu, 20 Jun 2013)
Log Message
Commit queue shouldn't reopen unrelated bugs because of flakiness
https://bugs.webkit.org/show_bug.cgi?id=117503
Reviewed by Ryosuke Niwa.
* Scripts/webkitpy/tool/bot/flakytestreporter.py:
(_follow_duplicate_chain):
(_update_bug_for_flaky_test):
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (151778 => 151779)
--- trunk/Tools/ChangeLog 2013-06-20 16:16:02 UTC (rev 151778)
+++ trunk/Tools/ChangeLog 2013-06-20 16:59:54 UTC (rev 151779)
@@ -1,3 +1,14 @@
+2013-06-20 Csaba Osztrogonác <[email protected]>
+
+ Commit queue shouldn't reopen unrelated bugs because of flakiness
+ https://bugs.webkit.org/show_bug.cgi?id=117503
+
+ Reviewed by Ryosuke Niwa.
+
+ * Scripts/webkitpy/tool/bot/flakytestreporter.py:
+ (_follow_duplicate_chain):
+ (_update_bug_for_flaky_test):
+
2013-06-19 Brent Fulgham <[email protected]>
[Windows] AX: Expand notification support.
Modified: trunk/Tools/Scripts/webkitpy/tool/bot/flakytestreporter.py (151778 => 151779)
--- trunk/Tools/Scripts/webkitpy/tool/bot/flakytestreporter.py 2013-06-20 16:16:02 UTC (rev 151778)
+++ trunk/Tools/Scripts/webkitpy/tool/bot/flakytestreporter.py 2013-06-20 16:59:54 UTC (rev 151779)
@@ -140,12 +140,8 @@
bug = self._tool.bugs.fetch_bug(bug.duplicate_of())
return bug
- # Maybe this logic should move into Bugzilla? a reopen=True arg to post_comment?
def _update_bug_for_flaky_test(self, bug, latest_flake_message):
- if bug.is_closed():
- self._tool.bugs.reopen_bug(bug.id(), latest_flake_message)
- else:
- self._tool.bugs.post_comment_to_bug(bug.id(), latest_flake_message)
+ self._tool.bugs.post_comment_to_bug(bug.id(), latest_flake_message)
# This method is needed because our archive paths include a leading tmp/layout-test-results
def _find_in_archive(self, path, archive):
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
