Title: [152718] trunk
- Revision
- 152718
- Author
- [email protected]
- Date
- 2013-07-16 06:03:38 -0700 (Tue, 16 Jul 2013)
Log Message
[GTK] fast/events/platform-wheelevent-with-delta-zero-crash.html is crashing
https://bugs.webkit.org/show_bug.cgi?id=110222
Patch by Anton Obzhirov <[email protected]> on 2013-07-16
Reviewed by Gustavo Noronha Silva.
Tools:
Added handling of zero mouse scroll deltas in EventSender.
* DumpRenderTree/gtk/EventSender.cpp:
(mouseScrollByCallback):
LayoutTests:
* platform/gtk/TestExpectations:
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (152717 => 152718)
--- trunk/LayoutTests/ChangeLog 2013-07-16 12:58:57 UTC (rev 152717)
+++ trunk/LayoutTests/ChangeLog 2013-07-16 13:03:38 UTC (rev 152718)
@@ -1,3 +1,12 @@
+2013-07-16 Anton Obzhirov <[email protected]>
+
+ [GTK] fast/events/platform-wheelevent-with-delta-zero-crash.html is crashing
+ https://bugs.webkit.org/show_bug.cgi?id=110222
+
+ Reviewed by Gustavo Noronha Silva.
+
+ * platform/gtk/TestExpectations:
+
2013-07-16 Krzysztof Czech <[email protected]>
[ATK] Adds support for aria-haspopup property.
Modified: trunk/LayoutTests/platform/gtk/TestExpectations (152717 => 152718)
--- trunk/LayoutTests/platform/gtk/TestExpectations 2013-07-16 12:58:57 UTC (rev 152717)
+++ trunk/LayoutTests/platform/gtk/TestExpectations 2013-07-16 13:03:38 UTC (rev 152718)
@@ -473,8 +473,6 @@
webkit.org/b/108927 http/tests/xmlhttprequest/workers/xmlhttprequest-file-not-found.html [ Crash Pass ]
-webkit.org/b/110222 fast/events/platform-wheelevent-with-delta-zero-crash.html [ Crash ]
-
webkit.org/b/110695 http/tests/security/cross-origin-local-storage-allowed.html [ Crash Pass ]
webkit.org/b/110695 http/tests/security/cross-origin-local-storage.html [ Crash Pass ]
webkit.org/b/110695 http/tests/security/cross-origin-plugin-allowed.html [ Crash Pass ]
Modified: trunk/Tools/ChangeLog (152717 => 152718)
--- trunk/Tools/ChangeLog 2013-07-16 12:58:57 UTC (rev 152717)
+++ trunk/Tools/ChangeLog 2013-07-16 13:03:38 UTC (rev 152718)
@@ -1,3 +1,15 @@
+2013-07-16 Anton Obzhirov <[email protected]>
+
+ [GTK] fast/events/platform-wheelevent-with-delta-zero-crash.html is crashing
+ https://bugs.webkit.org/show_bug.cgi?id=110222
+
+ Reviewed by Gustavo Noronha Silva.
+
+ Added handling of zero mouse scroll deltas in EventSender.
+
+ * DumpRenderTree/gtk/EventSender.cpp:
+ (mouseScrollByCallback):
+
2013-07-16 Brian Holt <[email protected]>
webkitpy: replace urllib with urllib2 for downloading additional modules
Modified: trunk/Tools/DumpRenderTree/gtk/EventSender.cpp (152717 => 152718)
--- trunk/Tools/DumpRenderTree/gtk/EventSender.cpp 2013-07-16 12:58:57 UTC (rev 152717)
+++ trunk/Tools/DumpRenderTree/gtk/EventSender.cpp 2013-07-16 13:03:38 UTC (rev 152718)
@@ -437,6 +437,10 @@
int vertical = (int)JSValueToNumber(context, arguments[1], exception);
g_return_val_if_fail((!exception || !*exception), JSValueMakeUndefined(context));
+ // Copy behaviour of Qt and EFL - just return in case of (0,0) mouse scroll
+ if (!horizontal && !vertical)
+ return JSValueMakeUndefined(context);
+
GdkEvent* event = gdk_event_new(GDK_SCROLL);
event->scroll.x = lastMousePositionX;
event->scroll.y = lastMousePositionY;
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes