Title: [152719] trunk/Tools
Revision
152719
Author
[email protected]
Date
2013-07-16 06:05:24 -0700 (Tue, 16 Jul 2013)

Log Message

check-webkit-style: "using namespace foo;" should be flagged as an error in headers
https://bugs.webkit.org/show_bug.cgi?id=57241

Patch by Brian Holt <[email protected]> on 2013-07-16
Reviewed by Ryosuke Niwa.

Added check for "using namespace foo" and unit test.

* Scripts/webkitpy/style/checkers/cpp.py:
(check_using_namespace):
(check_style):
(CppChecker):
* Scripts/webkitpy/style/checkers/cpp_unittest.py:
(WebKitStyleTest.test_using_namespace):

Modified Paths

Diff

Modified: trunk/Tools/ChangeLog (152718 => 152719)


--- trunk/Tools/ChangeLog	2013-07-16 13:03:38 UTC (rev 152718)
+++ trunk/Tools/ChangeLog	2013-07-16 13:05:24 UTC (rev 152719)
@@ -1,3 +1,19 @@
+2013-07-16  Brian Holt  <[email protected]>
+
+        check-webkit-style: "using namespace foo;" should be flagged as an error in headers
+        https://bugs.webkit.org/show_bug.cgi?id=57241
+
+        Reviewed by Ryosuke Niwa.
+
+        Added check for "using namespace foo" and unit test.
+
+        * Scripts/webkitpy/style/checkers/cpp.py:
+        (check_using_namespace):
+        (check_style):
+        (CppChecker):
+        * Scripts/webkitpy/style/checkers/cpp_unittest.py:
+        (WebKitStyleTest.test_using_namespace):
+
 2013-07-16  Anton Obzhirov  <[email protected]>
 
         [GTK] fast/events/platform-wheelevent-with-delta-zero-crash.html is crashing

Modified: trunk/Tools/Scripts/webkitpy/style/checkers/cpp.py (152718 => 152719)


--- trunk/Tools/Scripts/webkitpy/style/checkers/cpp.py	2013-07-16 13:03:38 UTC (rev 152718)
+++ trunk/Tools/Scripts/webkitpy/style/checkers/cpp.py	2013-07-16 13:05:24 UTC (rev 152719)
@@ -2161,6 +2161,31 @@
           "Use 'using namespace std;' instead of 'using std::%s;'." % method_name)
 
 
+def check_using_namespace(clean_lines, line_number, file_state, error):
+    """Looks for 'using namespace foo;' which should be removed.
+
+    Args:
+      clean_lines: A CleansedLines instance containing the file.
+      line_number: The number of the line to check.
+      file_state: A _FileState instance which maintains information about
+                  the state of things in the file.
+      error: The function to call with any errors found.
+    """
+
+    # This check doesn't apply to C or Objective-C implementation files.
+    if file_state.is_c_or_objective_c():
+        return
+
+    line = clean_lines.elided[line_number]  # Get rid of comments and strings.
+
+    using_namespace_match = match(r'\s*using\s+namespace\s+(?P<method_name>\S+)\s*;\s*$', line)
+    if not using_namespace_match:
+        return
+
+    method_name = using_namespace_match.group('method_name')
+    error(line_number, 'build/using_namespace', 4,
+          "Do not use 'using namespace %s;'." % method_name)
+
 def check_max_min_macros(clean_lines, line_number, file_state, error):
     """Looks use of MAX() and MIN() macros that should be replaced with std::max() and std::min().
 
@@ -2645,6 +2670,7 @@
     check_namespace_indentation(clean_lines, line_number, file_extension, file_state, error)
     check_directive_indentation(clean_lines, line_number, file_state, error)
     check_using_std(clean_lines, line_number, file_state, error)
+    check_using_namespace(clean_lines, line_number, file_state, error)
     check_max_min_macros(clean_lines, line_number, file_state, error)
     check_ctype_functions(clean_lines, line_number, file_state, error)
     check_switch_indentation(clean_lines, line_number, error)
@@ -3630,6 +3656,7 @@
         'build/printf_format',
         'build/storage_class',
         'build/using_std',
+        'build/using_namespace',
         'legal/copyright',
         'readability/braces',
         'readability/casting',

Modified: trunk/Tools/Scripts/webkitpy/style/checkers/cpp_unittest.py (152718 => 152719)


--- trunk/Tools/Scripts/webkitpy/style/checkers/cpp_unittest.py	2013-07-16 13:03:38 UTC (rev 152718)
+++ trunk/Tools/Scripts/webkitpy/style/checkers/cpp_unittest.py	2013-07-16 13:05:24 UTC (rev 152719)
@@ -4490,6 +4490,13 @@
             "  [build/using_std] [4]",
             'foo.cpp')
 
+    def test_using_namespace(self):
+        self.assert_lint(
+            'using namespace foo;',
+            "Do not use 'using namespace foo;'."
+            "  [build/using_namespace] [4]",
+            'foo.cpp')
+
     def test_max_macro(self):
         self.assert_lint(
             'int i = MAX(0, 1);',
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to