Title: [153804] trunk/Tools
- Revision
- 153804
- Author
- [email protected]
- Date
- 2013-08-07 15:00:42 -0700 (Wed, 07 Aug 2013)
Log Message
Clean up: Simplifying the printing of the command line arguments passed to jsDriver.pl
<https://bugs.webkit.org/show_bug.cgi?id=119558>
Reviewed by Martin Robinson.
Currently we build the command line to execute jsDriver.pl twice so as to both
print it to standard output and actually execute it. We should only build up
this command line once. Moreover, we should print to standard output the actual
command line that we are going to use including the GTK- and EFL-specific call
to /Tools/jhbuild/jhbuild-wrapper.
* Scripts/run-_javascript_core-tests:
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (153803 => 153804)
--- trunk/Tools/ChangeLog 2013-08-07 21:49:04 UTC (rev 153803)
+++ trunk/Tools/ChangeLog 2013-08-07 22:00:42 UTC (rev 153804)
@@ -1,3 +1,18 @@
+2013-08-07 Daniel Bates <[email protected]>
+
+ Clean up: Simplifying the printing of the command line arguments passed to jsDriver.pl
+ <https://bugs.webkit.org/show_bug.cgi?id=119558>
+
+ Reviewed by Martin Robinson.
+
+ Currently we build the command line to execute jsDriver.pl twice so as to both
+ print it to standard output and actually execute it. We should only build up
+ this command line once. Moreover, we should print to standard output the actual
+ command line that we are going to use including the GTK- and EFL-specific call
+ to /Tools/jhbuild/jhbuild-wrapper.
+
+ * Scripts/run-_javascript_core-tests:
+
2013-08-07 Mario Sanchez Prada <[email protected]>
[EFL] REGRESSION after r153432: some accessibility tests crash.
Modified: trunk/Tools/Scripts/run-_javascript_core-tests (153803 => 153804)
--- trunk/Tools/Scripts/run-_javascript_core-tests 2013-08-07 21:49:04 UTC (rev 153803)
+++ trunk/Tools/Scripts/run-_javascript_core-tests 2013-08-07 22:00:42 UTC (rev 153804)
@@ -137,7 +137,6 @@
chdirWebKit();
chdir("Source/_javascript_Core");
chdir "tests/mozilla" or die "Failed to switch directory to 'tests/mozilla'\n";
-printf "Running: jsDriver.pl -e squirrelfish -s %s -f actual.html %s\n", jscPath($productDir), join(" ", @jsArgs);
my @jsDriverCmd = ("perl", "jsDriver.pl", "-e", "squirrelfish", "-s", jscPath($productDir), "-f", "actual.html", @jsArgs);
if (isGtk() || isEfl()) {
my @jhbuildPrefix = sourceDir() . "/Tools/jhbuild/jhbuild-wrapper";
@@ -151,6 +150,7 @@
unshift(@jsDriverCmd, @jhbuildPrefix);
}
+print "Running: " . join(" ", @jsDriverCmd) . "\n";
my $result = system(@jsDriverCmd);
exit exitStatus($result) if $result;
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
