Title: [153805] trunk/Source/WebCore
- Revision
- 153805
- Author
- [email protected]
- Date
- 2013-08-07 15:16:09 -0700 (Wed, 07 Aug 2013)
Log Message
Don't remove contents layer from its parent unless necessary
https://bugs.webkit.org/show_bug.cgi?id=119560
Reviewed by Simon Fraser.
RenderLayerBacking::updateInternalHierarchy() is called in some
instances where there doesn't need to be a complete reparenting of the
the m_graphicsLayer. For example, on OS X when the user changes the
scrollbar styles to/from always visible. We don't need to always
remove the graphics layer from its parent - any reparenting does that
automatically.
Unfortunately we can't trigger this situation in an automated test.
* rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::updateInternalHierarchy): Don't call removeFromParent().
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (153804 => 153805)
--- trunk/Source/WebCore/ChangeLog 2013-08-07 22:00:42 UTC (rev 153804)
+++ trunk/Source/WebCore/ChangeLog 2013-08-07 22:16:09 UTC (rev 153805)
@@ -1,3 +1,22 @@
+2013-08-07 Dean Jackson <[email protected]>
+
+ Don't remove contents layer from its parent unless necessary
+ https://bugs.webkit.org/show_bug.cgi?id=119560
+
+ Reviewed by Simon Fraser.
+
+ RenderLayerBacking::updateInternalHierarchy() is called in some
+ instances where there doesn't need to be a complete reparenting of the
+ the m_graphicsLayer. For example, on OS X when the user changes the
+ scrollbar styles to/from always visible. We don't need to always
+ remove the graphics layer from its parent - any reparenting does that
+ automatically.
+
+ Unfortunately we can't trigger this situation in an automated test.
+
+ * rendering/RenderLayerBacking.cpp:
+ (WebCore::RenderLayerBacking::updateInternalHierarchy): Don't call removeFromParent().
+
2013-08-07 Tim Horton <[email protected]>
Fall out of simple image layer optimization if the image has EXIF rotation
Modified: trunk/Source/WebCore/rendering/RenderLayerBacking.cpp (153804 => 153805)
--- trunk/Source/WebCore/rendering/RenderLayerBacking.cpp 2013-08-07 22:00:42 UTC (rev 153804)
+++ trunk/Source/WebCore/rendering/RenderLayerBacking.cpp 2013-08-07 22:16:09 UTC (rev 153805)
@@ -918,7 +918,6 @@
if (m_backgroundLayer)
m_contentsContainmentLayer->addChild(m_backgroundLayer.get());
- m_graphicsLayer->removeFromParent();
if (m_contentsContainmentLayer)
m_contentsContainmentLayer->addChild(m_graphicsLayer.get());
else if (m_ancestorClippingLayer)
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
