Title: [153808] trunk/Source/WebKit/blackberry
- Revision
- 153808
- Author
- [email protected]
- Date
- 2013-08-07 17:51:36 -0700 (Wed, 07 Aug 2013)
Log Message
[BlackBerry] Remove pointless const in InputHandler
https://bugs.webkit.org/show_bug.cgi?id=119550
Patch by Jacky Jiang <[email protected]> on 2013-08-07
Reviewed by Rob Buis.
Internally reviewed by Leo Yang and Mike Fenton.
* Api/WebPageClient.h:
* WebKitSupport/InputHandler.cpp:
(BlackBerry::WebKit::InputHandler::requestSpellingCheckingOptions):
(BlackBerry::WebKit::InputHandler::redrawSpellCheckDialogIfRequired):
* WebKitSupport/InputHandler.h:
Modified Paths
Diff
Modified: trunk/Source/WebKit/blackberry/Api/WebPageClient.h (153807 => 153808)
--- trunk/Source/WebKit/blackberry/Api/WebPageClient.h 2013-08-07 23:05:31 UTC (rev 153807)
+++ trunk/Source/WebKit/blackberry/Api/WebPageClient.h 2013-08-08 00:51:36 UTC (rev 153808)
@@ -146,7 +146,7 @@
virtual void showFormControls(bool visible, bool previousActive = false, bool nextActive = false) = 0;
virtual void showVirtualKeyboard(bool) = 0;
- virtual void requestSpellingCheckingOptions(imf_sp_text_t&, const BlackBerry::Platform::IntRect& documentCaretRect, const BlackBerry::Platform::IntSize& screenOffset, const bool shouldMoveDialog) = 0;
+ virtual void requestSpellingCheckingOptions(imf_sp_text_t&, const BlackBerry::Platform::IntRect& documentCaretRect, const BlackBerry::Platform::IntSize& screenOffset, bool shouldMoveDialog) = 0;
virtual int32_t checkSpellingOfStringAsync(wchar_t* text, const unsigned length) = 0;
virtual void notifySelectionDetailsChanged(const BlackBerry::Platform::SelectionDetails&) = 0;
Modified: trunk/Source/WebKit/blackberry/ChangeLog (153807 => 153808)
--- trunk/Source/WebKit/blackberry/ChangeLog 2013-08-07 23:05:31 UTC (rev 153807)
+++ trunk/Source/WebKit/blackberry/ChangeLog 2013-08-08 00:51:36 UTC (rev 153808)
@@ -1,3 +1,17 @@
+2013-08-07 Jacky Jiang <[email protected]>
+
+ [BlackBerry] Remove pointless const in InputHandler
+ https://bugs.webkit.org/show_bug.cgi?id=119550
+
+ Reviewed by Rob Buis.
+ Internally reviewed by Leo Yang and Mike Fenton.
+
+ * Api/WebPageClient.h:
+ * WebKitSupport/InputHandler.cpp:
+ (BlackBerry::WebKit::InputHandler::requestSpellingCheckingOptions):
+ (BlackBerry::WebKit::InputHandler::redrawSpellCheckDialogIfRequired):
+ * WebKitSupport/InputHandler.h:
+
2013-08-04 Sam Weinig <[email protected]>
Remove support for HTML5 MicroData
Modified: trunk/Source/WebKit/blackberry/WebKitSupport/InputHandler.cpp (153807 => 153808)
--- trunk/Source/WebKit/blackberry/WebKitSupport/InputHandler.cpp 2013-08-07 23:05:31 UTC (rev 153807)
+++ trunk/Source/WebKit/blackberry/WebKitSupport/InputHandler.cpp 2013-08-08 00:51:36 UTC (rev 153808)
@@ -788,7 +788,7 @@
return true;
}
-void InputHandler::requestSpellingCheckingOptions(imf_sp_text_t& spellCheckingOptionRequest, WebCore::IntSize& screenOffset, const bool shouldMoveDialog)
+void InputHandler::requestSpellingCheckingOptions(imf_sp_text_t& spellCheckingOptionRequest, WebCore::IntSize& screenOffset, bool shouldMoveDialog)
{
// If the caret is no longer active, no message should be sent.
if (m_webPage->focusedOrMainFrame()->selection()->selectionType() != VisibleSelection::CaretSelection)
@@ -1256,7 +1256,7 @@
}
}
-void InputHandler::redrawSpellCheckDialogIfRequired(const bool shouldMoveDialog)
+void InputHandler::redrawSpellCheckDialogIfRequired(bool shouldMoveDialog)
{
if (didSpellCheckWord()) {
imf_sp_text_t spellCheckingOptionRequest;
Modified: trunk/Source/WebKit/blackberry/WebKitSupport/InputHandler.h (153807 => 153808)
--- trunk/Source/WebKit/blackberry/WebKitSupport/InputHandler.h 2013-08-07 23:05:31 UTC (rev 153807)
+++ trunk/Source/WebKit/blackberry/WebKitSupport/InputHandler.h 2013-08-08 00:51:36 UTC (rev 153808)
@@ -154,9 +154,9 @@
void spellCheckTextBlock(WebCore::Element* = 0);
bool shouldRequestSpellCheckingOptionsForPoint(const Platform::IntPoint& documentContentPosition, const WebCore::Element*, imf_sp_text_t&);
- void requestSpellingCheckingOptions(imf_sp_text_t&, WebCore::IntSize& screenOffset, const bool shouldMoveDialog = false);
+ void requestSpellingCheckingOptions(imf_sp_text_t&, WebCore::IntSize& screenOffset, bool shouldMoveDialog = false);
void clearDidSpellCheckState() { m_didSpellCheckWord = false; }
- void redrawSpellCheckDialogIfRequired(const bool shouldMoveDialog = true);
+ void redrawSpellCheckDialogIfRequired(bool shouldMoveDialog = true);
void callRequestCheckingFor(PassRefPtr<WebCore::SpellCheckRequest>);
void setSystemSpellCheckStatus(bool enabled) { m_spellCheckStatusConfirmed = true; m_globalSpellCheckStatus = enabled; }
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
