Title: [156168] trunk
- Revision
- 156168
- Author
- [email protected]
- Date
- 2013-09-20 09:18:10 -0700 (Fri, 20 Sep 2013)
Log Message
AX: WebArea claims to have a subrole, but always returns nil.
https://bugs.webkit.org/show_bug.cgi?id=121658
Patch by Sam White <[email protected]> on 2013-09-20
Reviewed by Chris Fleizach.
Source/WebCore:
No new tests, updated existing AXWebArea related test to reflect unused attribute removal.
* accessibility/mac/WebAccessibilityObjectWrapperMac.mm:
(-[WebAccessibilityObjectWrapper accessibilityAttributeNames]):
LayoutTests:
Updated test output to reflect removal of unused NSAccessibilitySubroleAttribute in AXWebArea.
* platform/mac/accessibility/document-attributes-expected.txt:
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (156167 => 156168)
--- trunk/LayoutTests/ChangeLog 2013-09-20 15:47:24 UTC (rev 156167)
+++ trunk/LayoutTests/ChangeLog 2013-09-20 16:18:10 UTC (rev 156168)
@@ -1,3 +1,14 @@
+2013-09-20 Sam White <[email protected]>
+
+ AX: WebArea claims to have a subrole, but always returns nil.
+ https://bugs.webkit.org/show_bug.cgi?id=121658
+
+ Reviewed by Chris Fleizach.
+
+ Updated test output to reflect removal of unused NSAccessibilitySubroleAttribute in AXWebArea.
+
+ * platform/mac/accessibility/document-attributes-expected.txt:
+
2013-09-20 Denis Nomiyama <[email protected]>
[ATK][WTR] accessibility/aria-invalid.html times out
Modified: trunk/LayoutTests/platform/mac/accessibility/document-attributes-expected.txt (156167 => 156168)
--- trunk/LayoutTests/platform/mac/accessibility/document-attributes-expected.txt 2013-09-20 15:47:24 UTC (rev 156167)
+++ trunk/LayoutTests/platform/mac/accessibility/document-attributes-expected.txt 2013-09-20 16:18:10 UTC (rev 156168)
@@ -1,5 +1,4 @@
AXRole: AXWebArea
-AXSubrole: (null)
AXRoleDescription: HTML content
AXChildren: <array of size 0>
AXHelp:
Modified: trunk/Source/WebCore/ChangeLog (156167 => 156168)
--- trunk/Source/WebCore/ChangeLog 2013-09-20 15:47:24 UTC (rev 156167)
+++ trunk/Source/WebCore/ChangeLog 2013-09-20 16:18:10 UTC (rev 156168)
@@ -1,3 +1,15 @@
+2013-09-20 Sam White <[email protected]>
+
+ AX: WebArea claims to have a subrole, but always returns nil.
+ https://bugs.webkit.org/show_bug.cgi?id=121658
+
+ Reviewed by Chris Fleizach.
+
+ No new tests, updated existing AXWebArea related test to reflect unused attribute removal.
+
+ * accessibility/mac/WebAccessibilityObjectWrapperMac.mm:
+ (-[WebAccessibilityObjectWrapper accessibilityAttributeNames]):
+
2013-09-20 Andreas Kling <[email protected]>
Add valueForLength/minimumValueForLength wrappers to RenderElement.
Modified: trunk/Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm (156167 => 156168)
--- trunk/Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm 2013-09-20 15:47:24 UTC (rev 156167)
+++ trunk/Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm 2013-09-20 16:18:10 UTC (rev 156168)
@@ -1143,6 +1143,8 @@
}
if (webAreaAttrs == nil) {
tempArray = [[NSMutableArray alloc] initWithArray:attributes];
+ // WebAreas should not expose AXSubrole.
+ [tempArray removeObject:NSAccessibilitySubroleAttribute];
[tempArray addObject:@"AXLinkUIElements"];
[tempArray addObject:@"AXLoaded"];
[tempArray addObject:@"AXLayoutCount"];
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
