Title: [156165] trunk
- Revision
- 156165
- Author
- [email protected]
- Date
- 2013-09-20 08:20:32 -0700 (Fri, 20 Sep 2013)
Log Message
[ATK][WTR] accessibility/aria-invalid.html times out
https://bugs.webkit.org/show_bug.cgi?id=121668
Patch by Denis Nomiyama <[email protected]> on 2013-09-20
Reviewed by Mario Sanchez Prada.
Tools:
Fixed WTR::AccessibilityUIElement::stringAttributeValue() to return
false in case of aria-invalid event with empty value.
* WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
(WTR::AccessibilityUIElement::stringAttributeValue): Returns false in
case of aria-invalid event with empty value.
LayoutTests:
Updated the expectation of aria-invalid.html test, which was timing out
before bug 120421 and this fix.
* platform/gtk-wk2/TestExpectations: Removed aria-invalid.html because
it now passes with this fix and the patch from bug 120421.
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (156164 => 156165)
--- trunk/LayoutTests/ChangeLog 2013-09-20 15:15:22 UTC (rev 156164)
+++ trunk/LayoutTests/ChangeLog 2013-09-20 15:20:32 UTC (rev 156165)
@@ -1,3 +1,16 @@
+2013-09-20 Denis Nomiyama <[email protected]>
+
+ [ATK][WTR] accessibility/aria-invalid.html times out
+ https://bugs.webkit.org/show_bug.cgi?id=121668
+
+ Reviewed by Mario Sanchez Prada.
+
+ Updated the expectation of aria-invalid.html test, which was timing out
+ before bug 120421 and this fix.
+
+ * platform/gtk-wk2/TestExpectations: Removed aria-invalid.html because
+ it now passes with this fix and the patch from bug 120421.
+
2013-09-20 Gabor Abraham <[email protected]>
[Qt] Unreviewed gardening. Rebase after Qt 5.1.1 and skip failing tests.
Modified: trunk/LayoutTests/platform/gtk-wk2/TestExpectations (156164 => 156165)
--- trunk/LayoutTests/platform/gtk-wk2/TestExpectations 2013-09-20 15:15:22 UTC (rev 156164)
+++ trunk/LayoutTests/platform/gtk-wk2/TestExpectations 2013-09-20 15:20:32 UTC (rev 156165)
@@ -495,9 +495,6 @@
Bug(GTK) animations/play-state-suspend.html [ Failure ]
Bug(GTK) animations/suspend-resume-animation.html [ Failure ]
-# [GTK] Missing WTR AccessibilityUIElement::addNotificationListener implementation
-webkit.org/b/120421 accessibility/aria-invalid.html [ Timeout ]
-
#////////////////////////////////////////////////////////////////////////////////////////
# End of Tests failing
#////////////////////////////////////////////////////////////////////////////////////////
Modified: trunk/Tools/ChangeLog (156164 => 156165)
--- trunk/Tools/ChangeLog 2013-09-20 15:15:22 UTC (rev 156164)
+++ trunk/Tools/ChangeLog 2013-09-20 15:20:32 UTC (rev 156165)
@@ -1,5 +1,19 @@
2013-09-20 Denis Nomiyama <[email protected]>
+ [ATK][WTR] accessibility/aria-invalid.html times out
+ https://bugs.webkit.org/show_bug.cgi?id=121668
+
+ Reviewed by Mario Sanchez Prada.
+
+ Fixed WTR::AccessibilityUIElement::stringAttributeValue() to return
+ false in case of aria-invalid event with empty value.
+
+ * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
+ (WTR::AccessibilityUIElement::stringAttributeValue): Returns false in
+ case of aria-invalid event with empty value.
+
+2013-09-20 Denis Nomiyama <[email protected]>
+
[ATK] Missing WTR AccessibilityUIElement::addNotificationListener implementation
https://bugs.webkit.org/show_bug.cgi?id=120421
Modified: trunk/Tools/WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp (156164 => 156165)
--- trunk/Tools/WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp 2013-09-20 15:15:22 UTC (rev 156164)
+++ trunk/Tools/WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp 2013-09-20 15:20:32 UTC (rev 156165)
@@ -569,6 +569,12 @@
String attributeValue = getAttributeSetValueForId(ATK_OBJECT(m_element.get()), atkAttributeName.utf8().data());
+ // In case of 'aria-invalid' when the attribute empty or has "false" for ATK
+ // according to http://www.w3.org/WAI/PF/aria-implementation/#mapping attribute
+ // is not mapped but layout tests will expect 'false'.
+ if (attributeValue.isEmpty() && atkAttributeName == "aria-invalid")
+ return JSStringCreateWithUTF8CString("false");
+
// We need to translate ATK values exposed for 'aria-sort' (e.g. 'ascending')
// into those expected by the layout tests (e.g. 'AXAscendingSortDirection').
if (atkAttributeName == "sort") {
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
