Title: [156287] trunk/Source/WebKit2
- Revision
- 156287
- Author
- [email protected]
- Date
- 2013-09-23 13:09:41 -0700 (Mon, 23 Sep 2013)
Log Message
[GTK][WK2] A plugin dirtyRect within iframe remains after moving to a different page.
https://bugs.webkit.org/show_bug.cgi?id=121600
Reviewed by Gustavo Noronha Silva.
Nowhere to destroy NetscapePlugin::m_platformPluginWidget even after destroying
an instance of NetscapePlugin. So the created GtkWidget remains visible.
* WebProcess/Plugins/Netscape/x11/NetscapePluginX11.cpp:
(WebKit::NetscapePlugin::platformDestroy):
Modified Paths
Diff
Modified: trunk/Source/WebKit2/ChangeLog (156286 => 156287)
--- trunk/Source/WebKit2/ChangeLog 2013-09-23 19:46:46 UTC (rev 156286)
+++ trunk/Source/WebKit2/ChangeLog 2013-09-23 20:09:41 UTC (rev 156287)
@@ -1,3 +1,16 @@
+2013-09-23 ChangSeok Oh <[email protected]>
+
+ [GTK][WK2] A plugin dirtyRect within iframe remains after moving to a different page.
+ https://bugs.webkit.org/show_bug.cgi?id=121600
+
+ Reviewed by Gustavo Noronha Silva.
+
+ Nowhere to destroy NetscapePlugin::m_platformPluginWidget even after destroying
+ an instance of NetscapePlugin. So the created GtkWidget remains visible.
+
+ * WebProcess/Plugins/Netscape/x11/NetscapePluginX11.cpp:
+ (WebKit::NetscapePlugin::platformDestroy):
+
2013-09-23 Sam Weinig <[email protected]>
Add back the SharedWorkerStrategy to prevent crashing.
Modified: trunk/Source/WebKit2/WebProcess/Plugins/Netscape/x11/NetscapePluginX11.cpp (156286 => 156287)
--- trunk/Source/WebKit2/WebProcess/Plugins/Netscape/x11/NetscapePluginX11.cpp 2013-09-23 19:46:46 UTC (rev 156286)
+++ trunk/Source/WebKit2/WebProcess/Plugins/Netscape/x11/NetscapePluginX11.cpp 2013-09-23 20:09:41 UTC (rev 156287)
@@ -297,6 +297,13 @@
XFreePixmap(hostDisplay, m_drawable);
m_drawable = 0;
}
+
+#if PLATFORM(GTK)
+ if (m_platformPluginWidget) {
+ gtk_widget_destroy(m_platformPluginWidget);
+ m_platformPluginWidget = 0;
+ }
+#endif
}
bool NetscapePlugin::platformInvalidate(const IntRect&)
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
