Title: [156288] trunk/Source
- Revision
- 156288
- Author
- [email protected]
- Date
- 2013-09-23 13:23:02 -0700 (Mon, 23 Sep 2013)
Log Message
[BlackBerry] Poor rendering opening a Google map short link
https://bugs.webkit.org/show_bug.cgi?id=121687
Source/WebCore:
Patch by Jacky Jiang <[email protected]> on 2013-09-23.
Reviewed by Yong Li.
Internally reviewed by Liam Quinn and Joe Mason.
Fix a regression. It turns out that LayerCompositingThread already has
an API named isVisible() which by default returns false. So rename the
one in the LayerData to isLayerVisible().
* platform/graphics/blackberry/LayerData.h:
(WebCore::LayerData::isLayerVisible):
* platform/graphics/blackberry/LayerRenderer.cpp:
(WebCore::LayerRenderer::compositeLayersRecursive):
Source/WebKit/blackberry:
Patch by Jacky Jiang <[email protected]> on 2013-09-23.
Reviewed by Yong Li.
Internally reviewed by Arvid Nilsson.
Clean up m_isAcceleratedCompositingActive as it has been deprecated.
* Api/WebPage_p.h:
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (156287 => 156288)
--- trunk/Source/WebCore/ChangeLog 2013-09-23 20:09:41 UTC (rev 156287)
+++ trunk/Source/WebCore/ChangeLog 2013-09-23 20:23:02 UTC (rev 156288)
@@ -1,3 +1,20 @@
+2013-09-23 Jacky Jiang <[email protected]>
+
+ [BlackBerry] Poor rendering opening a Google map short link
+ https://bugs.webkit.org/show_bug.cgi?id=121687
+
+ Reviewed by Yong Li.
+ Internally reviewed by Liam Quinn and Joe Mason.
+
+ Fix a regression. It turns out that LayerCompositingThread already has
+ an API named isVisible() which by default returns false. So rename the
+ one in the LayerData to isLayerVisible().
+
+ * platform/graphics/blackberry/LayerData.h:
+ (WebCore::LayerData::isLayerVisible):
+ * platform/graphics/blackberry/LayerRenderer.cpp:
+ (WebCore::LayerRenderer::compositeLayersRecursive):
+
2013-09-23 Antti Koivisto <[email protected]>
Rename RenderObject::first/lastChild to RenderObject::first/lastChildSlow
Modified: trunk/Source/WebCore/platform/graphics/blackberry/LayerData.h (156287 => 156288)
--- trunk/Source/WebCore/platform/graphics/blackberry/LayerData.h 2013-09-23 20:09:41 UTC (rev 156287)
+++ trunk/Source/WebCore/platform/graphics/blackberry/LayerData.h 2013-09-23 20:23:02 UTC (rev 156288)
@@ -183,7 +183,7 @@
return m_layerType == CanvasLayer;
}
- bool isVisible() const
+ bool isLayerVisible() const
{
return m_isVisible;
}
@@ -253,7 +253,7 @@
unsigned m_sizeIsScaleInvariant : 1;
unsigned m_contentsResolutionIndependent : 1;
- // The following is only available for media (video) and plugin layers.
+ // The following is only available for media (video), plugin and canvas layers.
unsigned m_isVisible : 1;
// CAUTION: all the data members are copied from one instance to another
Modified: trunk/Source/WebCore/platform/graphics/blackberry/LayerRenderer.cpp (156287 => 156288)
--- trunk/Source/WebCore/platform/graphics/blackberry/LayerRenderer.cpp 2013-09-23 20:09:41 UTC (rev 156287)
+++ trunk/Source/WebCore/platform/graphics/blackberry/LayerRenderer.cpp 2013-09-23 20:23:02 UTC (rev 156288)
@@ -891,7 +891,7 @@
#endif
if (layer->isCanvasLayer())
- layerVisible = layerVisible && layer->isVisible();
+ layerVisible = layerVisible && layer->isLayerVisible();
layer->setVisible(layerVisible);
Modified: trunk/Source/WebKit/blackberry/Api/WebPage_p.h (156287 => 156288)
--- trunk/Source/WebKit/blackberry/Api/WebPage_p.h 2013-09-23 20:09:41 UTC (rev 156287)
+++ trunk/Source/WebKit/blackberry/Api/WebPage_p.h 2013-09-23 20:23:02 UTC (rev 156288)
@@ -575,7 +575,6 @@
OwnPtr<InRegionScroller> m_inRegionScroller;
#if USE(ACCELERATED_COMPOSITING)
- bool m_isAcceleratedCompositingActive;
OwnPtr<FrameLayers> m_frameLayers; // WebKit thread only.
OwnPtr<WebCore::GraphicsLayer> m_overlayLayer;
Modified: trunk/Source/WebKit/blackberry/ChangeLog (156287 => 156288)
--- trunk/Source/WebKit/blackberry/ChangeLog 2013-09-23 20:09:41 UTC (rev 156287)
+++ trunk/Source/WebKit/blackberry/ChangeLog 2013-09-23 20:23:02 UTC (rev 156288)
@@ -1,3 +1,15 @@
+2013-09-23 Jacky Jiang <[email protected]>
+
+ [BlackBerry] Poor rendering opening a Google map short link
+ https://bugs.webkit.org/show_bug.cgi?id=121687
+
+ Reviewed by Yong Li.
+ Internally reviewed by Arvid Nilsson.
+
+ Clean up m_isAcceleratedCompositingActive as it has been deprecated.
+
+ * Api/WebPage_p.h:
+
2013-09-13 Allan Sandfeld Jensen <[email protected]>
Remove support for QXmlStream as the XML parser.
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
