Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js (157186 => 157187)
--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js 2013-10-09 21:45:44 UTC (rev 157186)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js 2013-10-09 21:56:15 UTC (rev 157187)
@@ -65,27 +65,31 @@
var layoutTestResults = iteration.layoutTestResults || {failureCount: 0};
var _javascript_TestResults = iteration._javascript_TestResults || {failureCount: 0};
+ var apiTestResults = iteration.apiTestResults || {failureCount: 0};
var pythonTestResults = iteration.pythonTestResults || {failureCount: 0};
var perlTestResults = iteration.perlTestResults || {failureCount: 0};
var bindingTestResults = iteration.bindingTestResults || {errorOccurred: false};
- if (!layoutTestResults.failureCount && !_javascript_TestResults.failureCount && !pythonTestResults.failureCount && !perlTestResults.failureCount && !bindingTestResults.errorOccurred) {
+ if (!layoutTestResults.failureCount && !_javascript_TestResults.failureCount && !apiTestResults.failureCount && !pythonTestResults.failureCount && !perlTestResults.failureCount && !bindingTestResults.errorOccurred) {
var status = new StatusLineView(messageLinkElement, StatusLineView.Status.Good, "all tests passed");
limit = 0;
- } else if (layoutTestResults.failureCount && !_javascript_TestResults.failureCount && !pythonTestResults.failureCount && !perlTestResults.failureCount && !bindingTestResults.errorOccurred) {
+ } else if (layoutTestResults.failureCount && !_javascript_TestResults.failureCount && !apiTestResults.failureCount && !pythonTestResults.failureCount && !perlTestResults.failureCount && !bindingTestResults.errorOccurred) {
var url = ""
var status = new StatusLineView(messageLinkElement, StatusLineView.Status.Bad, layoutTestResults.failureCount === 1 ? "layout test failure" : "layout test failures", layoutTestResults.tooManyFailures ? layoutTestResults.failureCount + "\uff0b" : layoutTestResults.failureCount, url);
- } else if (!layoutTestResults.failureCount && _javascript_TestResults.failureCount && !pythonTestResults.failureCount && !perlTestResults.failureCount && !bindingTestResults.errorOccurred) {
+ } else if (!layoutTestResults.failureCount && _javascript_TestResults.failureCount && !apiTestResults.failureCount && !pythonTestResults.failureCount && !perlTestResults.failureCount && !bindingTestResults.errorOccurred) {
var url = ""
var status = new StatusLineView(messageLinkElement, StatusLineView.Status.Bad, _javascript_TestResults.failureCount === 1 ? "_javascript_ test failure" : "_javascript_ test failures", _javascript_TestResults.failureCount, url);
- } else if (!layoutTestResults.failureCount && !_javascript_TestResults.failureCount && pythonTestResults.failureCount && !perlTestResults.failureCount && !bindingTestResults.errorOccurred) {
+ } else if (!layoutTestResults.failureCount && !_javascript_TestResults.failureCount && apiTestResults.failureCount && !pythonTestResults.failureCount && !perlTestResults.failureCount && !bindingTestResults.errorOccurred) {
+ var url = ""
+ var status = new StatusLineView(messageLinkElement, StatusLineView.Status.Bad, apiTestResults.failureCount === 1 ? "api test failure" : "api test failures", apiTestResults.failureCount, url);
+ } else if (!layoutTestResults.failureCount && !_javascript_TestResults.failureCount && !apiTestResults.failureCount && pythonTestResults.failureCount && !perlTestResults.failureCount && !bindingTestResults.errorOccurred) {
var status = new StatusLineView(messageLinkElement, StatusLineView.Status.Bad, pythonTestResults.failureCount === 1 ? "webkitpy test failure" : "webkitpy test failures", pythonTestResults.failureCount);
- } else if (!layoutTestResults.failureCount && !_javascript_TestResults.failureCount && !pythonTestResults.failureCount && perlTestResults.failureCount && !bindingTestResults.errorOccurred) {
+ } else if (!layoutTestResults.failureCount && !_javascript_TestResults.failureCount && !apiTestResults.failureCount && !pythonTestResults.failureCount && perlTestResults.failureCount && !bindingTestResults.errorOccurred) {
var status = new StatusLineView(messageLinkElement, StatusLineView.Status.Bad, perlTestResults.failureCount === 1 ? "webkitperl test failure" : "webkitperl test failures", perlTestResults.failureCount);
- } else if (!layoutTestResults.failureCount && !_javascript_TestResults.failureCount && !pythonTestResults.failureCount && !perlTestResults.failureCount && bindingTestResults.errorOccurred) {
+ } else if (!layoutTestResults.failureCount && !_javascript_TestResults.failureCount && !apiTestResults.failureCount && !pythonTestResults.failureCount && !perlTestResults.failureCount && bindingTestResults.errorOccurred) {
var status = new StatusLineView(messageLinkElement, StatusLineView.Status.Bad, "binding tests failed");
} else {
- var totalFailures = layoutTestResults.failureCount + _javascript_TestResults.failureCount + pythonTestResults.failureCount + perlTestResults.failureCount + bindingTestResults.errorOccurred;
+ var totalFailures = layoutTestResults.failureCount + _javascript_TestResults.failureCount + apiTestResults.failureCount + pythonTestResults.failureCount + perlTestResults.failureCount + bindingTestResults.errorOccurred;
var status = new StatusLineView(messageLinkElement, StatusLineView.Status.Bad, totalFailures === 1 ? "test failure" : "test failures", totalFailures);
}
Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js (157186 => 157187)
--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js 2013-10-09 21:45:44 UTC (rev 157186)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js 2013-10-09 21:56:15 UTC (rev 157187)
@@ -74,5 +74,10 @@
_javascript_TestResultsURLForIteration: function(iteration)
{
return this.baseURL + "builders/" + encodeURIComponent(iteration.queue.id) + "/builds/" + iteration.id + "/steps/jscore-test/logs/stdio";
+ },
+
+ apiTestResultsURLForIteration: function(iteration)
+ {
+ return this.baseURL + "builders/" + encodeURIComponent(iteration.queue.id) + "/builds/" + iteration.id + "/steps/run-api-tests/logs/stdio";
}
};
Modified: trunk/Tools/ChangeLog (157186 => 157187)
--- trunk/Tools/ChangeLog 2013-10-09 21:45:44 UTC (rev 157186)
+++ trunk/Tools/ChangeLog 2013-10-09 21:56:15 UTC (rev 157187)
@@ -1,5 +1,18 @@
2013-10-09 Timothy Hatcher <[email protected]>
+ Add API tests to the Dashbord page.
+
+ https://bugs.webkit.org/show_bug.cgi?id=122283
+
+ Reviewed by Timothy Hatcher.
+
+ * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
+ (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus):
+ * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
+ (WebKitBuildbot.prototype.apiTestResultsURLForIteration):
+
+2013-10-09 Timothy Hatcher <[email protected]>
+
Attempt to fix faulty Dashboard iteration updating by always rebuilding test result objects.
https://bugs.webkit.org/show_bug.cgi?id=122515
