Title: [157188] trunk/Tools
- Revision
- 157188
- Author
- [email protected]
- Date
- 2013-10-09 14:58:28 -0700 (Wed, 09 Oct 2013)
Log Message
Add API tests to the Dashbord page.
https://bugs.webkit.org/show_bug.cgi?id=122283
Patch by Timothy Hatcher <[email protected]> on 2013-10-09
Reviewed by Timothy Hatcher.
* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
(BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus):
* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
(WebKitBuildbot.prototype.apiTestResultsURLForIteration):
Modified Paths
Diff
Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js (157187 => 157188)
--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js 2013-10-09 21:56:15 UTC (rev 157187)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js 2013-10-09 21:58:28 UTC (rev 157188)
@@ -68,4 +68,9 @@
Buildbot.prototype = {
constructor: Buildbot,
__proto__: BaseObject.prototype,
+
+ buildPageURLForIteration: function(iteration)
+ {
+ return this.baseURL + "builders/" + encodeURIComponent(iteration.queue.id) + "/builds/" + iteration.id;
+ }
};
Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js (157187 => 157188)
--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js 2013-10-09 21:56:15 UTC (rev 157187)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js 2013-10-09 21:58:28 UTC (rev 157188)
@@ -89,8 +89,9 @@
} else if (!layoutTestResults.failureCount && !_javascript_TestResults.failureCount && !apiTestResults.failureCount && !pythonTestResults.failureCount && !perlTestResults.failureCount && bindingTestResults.errorOccurred) {
var status = new StatusLineView(messageLinkElement, StatusLineView.Status.Bad, "binding tests failed");
} else {
+ var url = ""
var totalFailures = layoutTestResults.failureCount + _javascript_TestResults.failureCount + apiTestResults.failureCount + pythonTestResults.failureCount + perlTestResults.failureCount + bindingTestResults.errorOccurred;
- var status = new StatusLineView(messageLinkElement, StatusLineView.Status.Bad, totalFailures === 1 ? "test failure" : "test failures", totalFailures);
+ var status = new StatusLineView(messageLinkElement, StatusLineView.Status.Bad, totalFailures === 1 ? "test failure" : "test failures", totalFailures, url);
}
this.element.appendChild(status.element);
Modified: trunk/Tools/ChangeLog (157187 => 157188)
--- trunk/Tools/ChangeLog 2013-10-09 21:56:15 UTC (rev 157187)
+++ trunk/Tools/ChangeLog 2013-10-09 21:58:28 UTC (rev 157188)
@@ -24,6 +24,19 @@
2013-10-09 Alexey Proskuryakov <[email protected]>
+ build.webkit.org/dashboard doesn't provide a results link when there issues at multiple steps
+ https://bugs.webkit.org/show_bug.cgi?id=122573
+
+ Reviewed by Tim Hatcher.
+
+ * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
+ (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus): Provide a URL.
+
+ * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:
+ (Buildbot.prototype.buildPageURLForIteration): Added.
+
+2013-10-09 Alexey Proskuryakov <[email protected]>
+
http://build.webkit.org/dashboard/ links to a wrong jscore-test results page
https://bugs.webkit.org/show_bug.cgi?id=122569
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
